Skip to content

Commit 651ae29

Browse files
authored
Merge pull request #14 from UdashFramework/detach-fix
Detach selector parameter is optional
2 parents c6bf2d0 + dc19bf5 commit 651ae29

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ before_script:
1717
- wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
1818
- sudo dpkg -i google-chrome*.deb
1919
# Install Selenium chromedriver
20-
- wget http://chromedriver.storage.googleapis.com/2.25/chromedriver_linux64.zip
20+
- wget http://chromedriver.storage.googleapis.com/2.38/chromedriver_linux64.zip
2121
- unzip chromedriver_linux64.zip -d selenium-bin
2222
- export PATH=$PWD/selenium-bin:$PATH
2323

src/main/scala/io/udash/wrappers/jquery/JQuery.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ trait JQuery extends js.Object {
140140

141141
/** Remove the set of matched elements from the DOM. <br/>
142142
* See: <a href="http://api.jquery.com/detach/">jQuery Docs</a> */
143-
def detach(selector: Selector): JQuery = js.native
143+
def detach(selector: Selector = js.native): JQuery = js.native
144144

145145
/** Remove all child nodes of the set of matched elements from the DOM. <br/>
146146
* See: <a href="http://api.jquery.com/empty/">jQuery Docs</a> */

0 commit comments

Comments
 (0)