Fix call to OSError constructor on Windows test, some lint stuff

Author: Diego Argueta

CHANGELOG.md

@@ -8,8 +8,6 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## Unreleased
 
-### Added
-
 ### Changed
 
 - Support more lenient usernames and group names in FTP servers

fs/error_tools.py

@@ -86,7 +86,9 @@ def __exit__(
             if _errno == errno.EACCES and sys.platform == "win32":
                 windows_error = getattr(exc_value, "winerror", 0)
                 exception_args = getattr(exc_value, "args", None) or (0,)
-                if windows_error == 32 or exception_args[0] == errno.EACCES:  # pragma: no cover
+                if (
+                    windows_error == 32 or exception_args[0] == errno.EACCES
+                ):  # pragma: no cover
                     fserror = errors.ResourceLocked
             reraise(fserror, fserror(self._path, exc=exc_value), traceback)
 

tests/test_error_tools.py

@@ -27,7 +27,8 @@ def test_convert_enametoolong(self):
 
     @unittest.skipIf(sys.platform != "win32", "requires Windows")
     def test_convert_resourcelocked_windows(self):
-        exception = OSError(32, "resource locked")
+        # errno should be ignored on Windows so we pass in a bogus number.
+        exception = OSError(123456, "resource locked", None, 32)
         with self.assertRaises(fs.errors.ResourceLocked) as ctx:
             with convert_os_errors("stat", "/tmp/test"):
                 raise exception