Skip to content

Commit 5d094fd

Browse files
committed
Rename variable
1 parent 2c2c9f6 commit 5d094fd

File tree

2 files changed

+48
-48
lines changed

2 files changed

+48
-48
lines changed

src/NppJsonViewer/JsonViewDlg.cpp

Lines changed: 47 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ JsonViewDlg::JsonViewDlg(HINSTANCE hInstance, const NppData& nppData, const bool
1818
, m_IsNppReady(isReady)
1919
, m_nDlgId(nCmdId)
2020
, m_pEditor(std::make_unique<ScintillaEditor>(nppData))
21-
, m_hTreeView(std::make_unique<TreeViewCtrl>())
21+
, m_pTreeView(std::make_unique<TreeViewCtrl>())
2222
, m_pSetting(pSetting)
2323
, m_pCurrFileName(std::make_unique<wchar_t[]>(FILENAME_LEN_IN_TITLE))
2424
{
@@ -341,7 +341,7 @@ void JsonViewDlg::DrawJsonTree()
341341
EnableControls(ctrls, false);
342342

343343
HTREEITEM rootNode = nullptr;
344-
rootNode = m_hTreeView->InitTree();
344+
rootNode = m_pTreeView->InitTree();
345345

346346
// Refresh the view
347347
m_pEditor->RefreshViewHandle();
@@ -350,7 +350,7 @@ void JsonViewDlg::DrawJsonTree()
350350

351351
if (!selectedText.has_value() || selectedText.value().empty())
352352
{
353-
m_hTreeView->InsertNode(JSON_ERR_PARSE, NULL, rootNode);
353+
m_pTreeView->InsertNode(JSON_ERR_PARSE, NULL, rootNode);
354354

355355
if (IsMultiSelection(selectedData))
356356
{
@@ -366,9 +366,9 @@ void JsonViewDlg::DrawJsonTree()
366366
// Later on second launch, don't show the error message as this could be some text file
367367
// If it is real json file but has some error, then there must be more than 1 node exist.
368368

369-
if (!m_IsNppReady && m_hTreeView->GetNodeCount() <= 1)
369+
if (!m_IsNppReady && m_pTreeView->GetNodeCount() <= 1)
370370
{
371-
m_hTreeView->InsertNode(JSON_ERR_VALIDATE, NULL, rootNode);
371+
m_pTreeView->InsertNode(JSON_ERR_VALIDATE, NULL, rootNode);
372372
}
373373
else
374374
{
@@ -377,7 +377,7 @@ void JsonViewDlg::DrawJsonTree()
377377
}
378378
}
379379

380-
m_hTreeView->Expand(rootNode);
380+
m_pTreeView->Expand(rootNode);
381381

382382
// Enable all buttons and treeView
383383
EnableControls(ctrls, true);
@@ -441,34 +441,34 @@ auto JsonViewDlg::PopulateTreeUsingSax(HTREEITEM tree_root, const std::string& j
441441
HTREEITEM JsonViewDlg::InsertToTree(HTREEITEM parent, const std::string& text)
442442
{
443443
auto wText = StringHelper::ToWstring(text, CP_UTF8);
444-
return m_hTreeView->InsertNode(wText, NULL, parent);
444+
return m_pTreeView->InsertNode(wText, NULL, parent);
445445
}
446446

447447
HTREEITEM JsonViewDlg::InsertToTree(HTREEITEM parent, const std::string& text, const Position& pos)
448448
{
449449
auto wText = StringHelper::ToWstring(text, CP_UTF8);
450450
auto lparam = new Position(pos);
451-
return m_hTreeView->InsertNode(wText, reinterpret_cast<LPARAM>(lparam), parent);
451+
return m_pTreeView->InsertNode(wText, reinterpret_cast<LPARAM>(lparam), parent);
452452
}
453453

454454
void JsonViewDlg::AppendNodeCount(HTREEITEM node, unsigned elementCount, bool bArray)
455455
{
456456
if (!node)
457457
return;
458458

459-
auto txt = m_hTreeView->GetNodeName(node, false);
459+
auto txt = m_pTreeView->GetNodeName(node, false);
460460

461461
txt += L" ";
462462
txt += bArray ? L"[" : L"{";
463463
txt += std::to_wstring(elementCount);
464464
txt += bArray ? L"]" : L"}";
465465

466-
m_hTreeView->UpdateNodeText(node, txt);
466+
m_pTreeView->UpdateNodeText(node, txt);
467467
}
468468

469469
void JsonViewDlg::UpdateNodePath(HTREEITEM htiNode)
470470
{
471-
std::wstring nodePath = m_hTreeView->GetNodePath(htiNode);
471+
std::wstring nodePath = m_pTreeView->GetNodePath(htiNode);
472472
CUtility::SetEditCtrlText(::GetDlgItem(_hSelf, IDC_EDT_NODEPATH), nodePath);
473473
}
474474

@@ -486,31 +486,31 @@ void JsonViewDlg::SearchInTree()
486486
{
487487
std::wstring itemToSearch = CUtility::GetEditCtrlText(::GetDlgItem(_hSelf, IDC_EDT_SEARCH));
488488
CUtility::SetEditCtrlText(::GetDlgItem(_hSelf, IDC_EDT_NODEPATH), STR_SRCH_SEARCHING + itemToSearch);
489-
m_hTreeView->SetSelection(nullptr);
489+
m_pTreeView->SetSelection(nullptr);
490490

491491
static int foundCount = 0;
492492
static std::wstring previousSearch;
493-
static HTREEITEM nextNode = m_hTreeView->NextItem(m_hTreeView->GetRoot());
493+
static HTREEITEM nextNode = m_pTreeView->NextItem(m_pTreeView->GetRoot());
494494

495495
// New search, hence search from beginning
496496
if (previousSearch != itemToSearch)
497497
{
498498
previousSearch = itemToSearch;
499-
nextNode = m_hTreeView->NextItem(m_hTreeView->GetRoot());
499+
nextNode = m_pTreeView->NextItem(m_pTreeView->GetRoot());
500500
foundCount = 0;
501501
}
502502
else
503503
{
504-
nextNode = m_hTreeView->NextItem(nextNode);
505-
if (nextNode == m_hTreeView->GetRoot())
504+
nextNode = m_pTreeView->NextItem(nextNode);
505+
if (nextNode == m_pTreeView->GetRoot())
506506
{
507-
nextNode = m_hTreeView->NextItem(nextNode);
507+
nextNode = m_pTreeView->NextItem(nextNode);
508508
foundCount = 0;
509509
}
510510
}
511511

512512
// Check if this is an empty json
513-
std::wstring nodeText = m_hTreeView->GetNodeName(nextNode, true);
513+
std::wstring nodeText = m_pTreeView->GetNodeName(nextNode, true);
514514
if (nodeText.empty() || wcscmp(nodeText.c_str(), JSON_ERR_PARSE) == 0)
515515
{
516516
CUtility::SetEditCtrlText(::GetDlgItem(_hSelf, IDC_EDT_NODEPATH), STR_SRCH_NOTFOUND + itemToSearch);
@@ -520,9 +520,9 @@ void JsonViewDlg::SearchInTree()
520520
bool bFound = false;
521521
while (!bFound && nextNode)
522522
{
523-
nodeText = m_hTreeView->GetNodeName(nextNode, true);
524-
auto nodeKey = m_hTreeView->GetNodeKey(nextNode);
525-
auto nodeVal = m_hTreeView->GetNodeValue(nextNode);
523+
nodeText = m_pTreeView->GetNodeName(nextNode, true);
524+
auto nodeKey = m_pTreeView->GetNodeKey(nextNode);
525+
auto nodeVal = m_pTreeView->GetNodeValue(nextNode);
526526

527527
// Search in node value
528528
// 1. If both key and value are not equal
@@ -545,13 +545,13 @@ void JsonViewDlg::SearchInTree()
545545
if (bFound)
546546
break;
547547

548-
nextNode = m_hTreeView->NextItem(nextNode);
548+
nextNode = m_pTreeView->NextItem(nextNode);
549549
}
550550

551551
if (bFound)
552552
{
553553
UpdateNodePath(nextNode);
554-
m_hTreeView->SetSelection(nextNode);
554+
m_pTreeView->SetSelection(nextNode);
555555
++foundCount;
556556
}
557557
else
@@ -719,15 +719,15 @@ void JsonViewDlg::ShowContextMenu(int x, int y)
719719

720720
TVHITTESTINFO tvHitInfo {.pt = p, .flags = 0, .hItem = nullptr};
721721

722-
m_hTreeView->ScreenToTreeView(&(tvHitInfo.pt));
722+
m_pTreeView->ScreenToTreeView(&(tvHitInfo.pt));
723723

724724
// Detect if the given position is on the element TVITEM
725-
HTREEITEM hTreeItem = m_hTreeView->HitTest(&tvHitInfo);
725+
HTREEITEM hTreeItem = m_pTreeView->HitTest(&tvHitInfo);
726726

727727
if (hTreeItem != nullptr)
728728
{
729729
// Make item selected
730-
m_hTreeView->SelectItem(hTreeItem);
730+
m_pTreeView->SelectItem(hTreeItem);
731731

732732
if (tvHitInfo.flags & (TVHT_ONITEM | TVHT_ONITEMBUTTON))
733733
{
@@ -741,7 +741,7 @@ void JsonViewDlg::ShowContextMenu(int x, int y)
741741
void JsonViewDlg::ShowContextMenu(HTREEITEM htiNode, LPPOINT lppScreen)
742742
{
743743
// Select it
744-
m_hTreeView->SelectItem(htiNode);
744+
m_pTreeView->SelectItem(htiNode);
745745

746746
// Show menu
747747
if (lppScreen != NULL)
@@ -753,19 +753,19 @@ void JsonViewDlg::ShowContextMenu(HTREEITEM htiNode, LPPOINT lppScreen)
753753
bool bEnableExpand = false;
754754
bool bEnableCollapse = false;
755755

756-
if (m_hTreeView->GetRoot() == htiNode)
756+
if (m_pTreeView->GetRoot() == htiNode)
757757
{
758758
bEnableCopyName = false;
759759
bEnableCopyValue = false;
760760
bEnableCopyPath = false;
761761
}
762762

763-
if (m_hTreeView->HasChild(htiNode))
763+
if (m_pTreeView->HasChild(htiNode))
764764
{
765765
bEnableCopyName = false;
766766
bEnableCopyValue = false;
767-
bEnableCollapse = m_hTreeView->IsThisOrAnyChildExpanded(htiNode);
768-
bEnableExpand = m_hTreeView->IsThisOrAnyChildCollapsed(htiNode);
767+
bEnableCollapse = m_pTreeView->IsThisOrAnyChildExpanded(htiNode);
768+
bEnableExpand = m_pTreeView->IsThisOrAnyChildCollapsed(htiNode);
769769
}
770770

771771
// Create menu
@@ -806,56 +806,56 @@ void JsonViewDlg::ShowContextMenu(HTREEITEM htiNode, LPPOINT lppScreen)
806806

807807
void JsonViewDlg::ContextMenuExpand(bool bExpand)
808808
{
809-
HTREEITEM htiSelected = m_hTreeView->GetSelection();
809+
HTREEITEM htiSelected = m_pTreeView->GetSelection();
810810
if (htiSelected == NULL)
811811
return;
812812

813-
HTREEITEM htiRoot = m_hTreeView->GetRoot();
813+
HTREEITEM htiRoot = m_pTreeView->GetRoot();
814814
HTREEITEM htiNext = htiSelected;
815815
while (htiNext != NULL)
816816
{
817817
if (!(htiNext == htiRoot && !bExpand))
818-
bExpand ? m_hTreeView->Expand(htiNext) : m_hTreeView->Collapse(htiNext);
819-
htiNext = m_hTreeView->NextItem(htiNext, htiSelected);
818+
bExpand ? m_pTreeView->Expand(htiNext) : m_pTreeView->Collapse(htiNext);
819+
htiNext = m_pTreeView->NextItem(htiNext, htiSelected);
820820
}
821821
}
822822

823823
auto JsonViewDlg::CopyName() const -> std::wstring
824824
{
825-
HTREEITEM selectedNode = m_hTreeView->GetSelection();
825+
HTREEITEM selectedNode = m_pTreeView->GetSelection();
826826
if (selectedNode)
827827
{
828-
return m_hTreeView->GetNodeName(selectedNode, true);
828+
return m_pTreeView->GetNodeName(selectedNode, true);
829829
}
830830
return std::wstring();
831831
}
832832

833833
auto JsonViewDlg::CopyKey() const -> std::wstring
834834
{
835-
HTREEITEM selectedNode = m_hTreeView->GetSelection();
835+
HTREEITEM selectedNode = m_pTreeView->GetSelection();
836836
if (selectedNode)
837837
{
838-
return m_hTreeView->GetNodeKey(selectedNode);
838+
return m_pTreeView->GetNodeKey(selectedNode);
839839
}
840840
return std::wstring();
841841
}
842842

843843
auto JsonViewDlg::CopyValue() const -> std::wstring
844844
{
845-
HTREEITEM selectedNode = m_hTreeView->GetSelection();
845+
HTREEITEM selectedNode = m_pTreeView->GetSelection();
846846
if (selectedNode)
847847
{
848-
return m_hTreeView->GetNodeValue(selectedNode);
848+
return m_pTreeView->GetNodeValue(selectedNode);
849849
}
850850
return std::wstring();
851851
}
852852

853853
auto JsonViewDlg::CopyPath() const -> std::wstring
854854
{
855-
HTREEITEM selectedNode = m_hTreeView->GetSelection();
855+
HTREEITEM selectedNode = m_pTreeView->GetSelection();
856856
if (selectedNode)
857857
{
858-
return m_hTreeView->GetNodePath(selectedNode);
858+
return m_pTreeView->GetNodePath(selectedNode);
859859
}
860860
return std::wstring();
861861
}
@@ -911,7 +911,7 @@ void JsonViewDlg::HandleTreeEvents(LPARAM lParam)
911911
{
912912
UpdateNodePath(hItem);
913913

914-
auto pPosition = m_hTreeView->GetNodePosition(hItem);
914+
auto pPosition = m_pTreeView->GetNodePosition(hItem);
915915
if (pPosition != nullptr)
916916
{
917917
GoToLine(pPosition->nLine);
@@ -922,9 +922,9 @@ void JsonViewDlg::HandleTreeEvents(LPARAM lParam)
922922

923923
case NM_DBLCLK:
924924
{
925-
HTREEITEM hItem = m_hTreeView->GetSelection();
925+
HTREEITEM hItem = m_pTreeView->GetSelection();
926926

927-
auto pPosition = m_hTreeView->GetNodePosition(hItem);
927+
auto pPosition = m_pTreeView->GetNodePosition(hItem);
928928
if (pPosition != nullptr)
929929
{
930930
GoToPosition(pPosition->nLine, pPosition->nColumn, pPosition->nKeyLength);
@@ -1029,7 +1029,7 @@ INT_PTR JsonViewDlg::run_dlgProc(UINT message, WPARAM wParam, LPARAM lParam)
10291029
// Save ourselves in GWLP_USERDATA.
10301030
::SetWindowLongPtr(getHSelf(), GWLP_USERDATA, reinterpret_cast<LONG_PTR>(this));
10311031

1032-
m_hTreeView->OnInit(getHSelf());
1032+
m_pTreeView->OnInit(getHSelf());
10331033

10341034
PrepareButtons();
10351035

src/NppJsonViewer/JsonViewDlg.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,6 @@ class JsonViewDlg
117117

118118
std::unique_ptr<wchar_t[]> m_pCurrFileName;
119119
std::unique_ptr<ScintillaEditor> m_pEditor = nullptr;
120-
std::unique_ptr<TreeViewCtrl> m_hTreeView = nullptr;
120+
std::unique_ptr<TreeViewCtrl> m_pTreeView = nullptr;
121121
std::shared_ptr<Setting> m_pSetting = nullptr;
122122
};

0 commit comments

Comments
 (0)