Add load statements after disabling autoloads (#391)

Explicitly loads all symbols affected by
`--incompatible_disable_autoloads_in_main_repo` to fix `last_green`
Bazel builds. Adds the flag to `.bazelrc`, adds `rules_shell` as a
dependency, and contains lots of other Buildifier formatting touch ups.

bazelbuild/bazel@d87eaf5 from
2025-05-08 at 8:03am EDT flipped
`--incompatible_disable_autoloads_in_main_repo` to `true` to prepare for
Bazel 9. See also bazel-contrib/rules_scala#1738.

Before this change, setting the flag caused these errors:

```txt
$ bazel build --incompatible_disable_autoloads_in_main_repo //...

ERROR: java/com/engflow/notificationqueue/demoserver/BUILD:5:1:
  name 'proto_library' is not defined
ERROR: /demoserver/BUILD:10:1:
  name 'java_proto_library' is not defined (did you mean 'java_grpc_library'?)
ERROR: docker/network/BUILD:19:10: //docker/network:docker-network-test:
  no such attribute 'srcs' in 'java_test' rule
ERROR: docker/network/BUILD:19:10: //docker/network:docker-network-test:
  no such attribute 'test_class' in 'java_test' rule
ERROR: docker/sandbox/BUILD:15:12: //docker/sandbox:hello-java:
  no such attribute 'srcs' in 'java_binary' rule
ERROR: docker/sandbox/BUILD:15:12: //docker/sandbox:hello-java:
  no such attribute 'main_class' in 'java_binary' rule
ERROR: docker/sysbox/dind_test/BUILD:15:1:
  name 'sh_test' is not defined (did you mean 'cc_test'?)
ERROR: package contains errors: docker/sysbox/dind_test
ERROR: python/pytest/BUILD:3:1:
  name 'py_library' is not defined (did you mean 'cc_library'?)
ERROR: package contains errors: docker/sandbox
ERROR: package contains errors: java/com/engflow/notificationqueue/demoserver
ERROR: docker/network/BUILD:39:13: //docker/network:jdk:
  no such attribute 'java_home' in 'java_runtime' rule
ERROR: package contains errors: docker/network
ERROR: package contains errors: python/pytest
ERROR: java/com/engflow/example/BUILD:3:13: //java/com/engflow/example:example:
  no such attribute 'srcs' in 'java_library' rule
ERROR: java/com/engflow/example/BUILD:8:10: //java/com/engflow/example:ExampleTest:
  no such attribute 'srcs' in 'java_test' rule
ERROR: java/com/engflow/example/BUILD:8:10: //java/com/engflow/example:ExampleTest:
  no such attribute 'deps' in 'java_test' rule
ERROR: package contains errors: java/com/engflow/example
ERROR: java/com/engflow/notificationqueue/BUILD:5:12: //java/com/engflow/notificationqueue:client:
  no such attribute 'srcs' in 'java_binary' rule
ERROR: java/com/engflow/notificationqueue/BUILD:5:12: //java/com/engflow/notificationqueue:client:
  no such attribute 'main_class' in 'java_binary' rule
ERROR: java/com/engflow/notificationqueue/BUILD:5:12: //java/com/engflow/notificationqueue:client:
  no such attribute 'deps' in 'java_binary' rule
ERROR: package contains errors: java/com/engflow/notificationqueue
WARNING: Target pattern parsing failed.
ERROR: Skipping '//...': Error evaluating '//...':
  error loading package 'docker/network':
  Package 'docker/network' contains errors
ERROR: Error evaluating '//...':
  error loading package 'docker/network':
  Package 'docker/network' contains errors
INFO: Elapsed time: 2.821s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
```

Applied the fixes using Buildifier 8.2.0 with the following script:

```bash

WARNINGS=(
  $(buildifier --lint=warn -r . 2>&1 | grep -- native- |
    awk '{print $2}' | sort | uniq | sed -e 's/:$//')
)

IFS=, WARNINGS="${WARNINGS[*]}"
echo "warnings: ${WARNINGS}"
buildifier --lint=fix --warnings="$WARNINGS" -r .
```

Author: mbland

.bazelrc

@@ -2,6 +2,7 @@
 common --@aspect_rules_ts//ts:skipLibCheck=honor_tsconfig
 common --@aspect_rules_ts//ts:default_to_tsc_transpiler
 common --noincompatible_check_sharding_support
+common --incompatible_disable_autoloads_in_main_repo
 
 # Remove once proto toolchainization becomes the default
 # - https://bazel.build/reference/command-line-reference#flag--incompatible_enable_proto_toolchain_resolution

MODULE.bazel

@@ -174,3 +174,5 @@ scala_protoc = use_extension(
     dev_dependency = True,
 )
 use_repo(scala_protoc, "rules_scala_protoc_toolchains")
+
+bazel_dep(name = "rules_shell", version = "0.4.1")

MODULE.bazel.lock

@@ -61,14 +61,14 @@ platforms = rule(
     attrs = {
         "cpu_configuration": attrs.dep(providers = [ConfigurationInfo]),
         "os_configuration": attrs.dep(providers = [ConfigurationInfo]),
-    }, 
-    impl = _platforms
+    },
+    impl = _platforms,
 )
 
 action_keys = rule(
-     attrs = {
+    attrs = {
         "cell": attrs.string(),
         "mode": attrs.string(),
-     },
-     impl = _action_keys
+    },
+    impl = _action_keys,
 )

buck2/cpp/platforms/defs.bzl

@@ -58,13 +58,13 @@ def _action_keys(ctx):
 
 platforms = rule(
     attrs = {},
-    impl = _platforms
+    impl = _platforms,
 )
 
 action_keys = rule(
-     attrs = {
+    attrs = {
         "cell": attrs.string(),
         "mode": attrs.string(),
-     },
-     impl = _action_keys
+    },
+    impl = _action_keys,
 )

buck2/golang/platforms/defs.bzl

@@ -17,7 +17,7 @@ load("@prelude//go_bootstrap:go_bootstrap.bzl", "GoBootstrapToolchainInfo")
 load("@prelude//utils:cmd_script.bzl", "ScriptOs", "cmd_script")
 
 def _remote_go_bootstrap_toolchain_impl(ctx):
-    go_arch = "amd64"  
+    go_arch = "amd64"
     go_os = "linux"
 
     script_os = ScriptOs("unix")
@@ -47,7 +47,7 @@ remote_go_bootstrap_toolchain = rule(
 )
 
 def _remote_go_toolchain_impl(ctx):
-    go_arch = "amd64"  
+    go_arch = "amd64"
     go_os = "linux"
 
     script_os = ScriptOs("unix")
@@ -76,7 +76,6 @@ def _remote_go_toolchain_impl(ctx):
             compiler_flags = [],
         ),
     ]
-   
 
 remote_go_toolchain = rule(
     impl = _remote_go_toolchain_impl,

buck2/golang/toolchains/defs.bzl

@@ -56,13 +56,13 @@ def _action_keys(ctx):
 
 platforms = rule(
     attrs = {},
-    impl = _platforms
+    impl = _platforms,
 )
 
 action_keys = rule(
-     attrs = {
+    attrs = {
         "cell": attrs.string(),
         "mode": attrs.string(),
-     },
-     impl = _action_keys
+    },
+    impl = _action_keys,
 )

buck2/python/platforms/defs.bzl

@@ -59,7 +59,6 @@ remote_python_toolchain = rule(
         "_make_source_db": attrs.default_only(attrs.dep(providers = [RunInfo], default = "prelude//python/tools:make_source_db")),
         "_make_source_db_no_deps": attrs.default_only(attrs.dep(providers = [RunInfo], default = "prelude//python/tools:make_source_db_no_deps")),
         "_runtime_library": attrs.default_only(attrs.dep(providers = [ArtifactGroupInfo], default = "prelude//python/runtime:bootstrap_files")),
-
     },
     is_toolchain_rule = True,
 )

buck2/python/toolchains/defs.bzl

@@ -62,14 +62,14 @@ platforms = rule(
     attrs = {
         "cpu_configuration": attrs.dep(providers = [ConfigurationInfo]),
         "os_configuration": attrs.dep(providers = [ConfigurationInfo]),
-    }, 
-    impl = _platforms
+    },
+    impl = _platforms,
 )
 
 action_keys = rule(
-     attrs = {
+    attrs = {
         "cell": attrs.string(),
         "mode": attrs.string(),
-     },
-     impl = _action_keys
+    },
+    impl = _action_keys,
 )

buck2/rust/platforms/defs.bzl

@@ -12,9 +12,9 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+load("@prelude//cxx:cxx_toolchain_types.bzl", "LinkerType")
 load("@prelude//rust:rust_toolchain.bzl", "PanicRuntime", "RustToolchainInfo")
 load("@prelude//rust/tools:attrs.bzl", "internal_tool_attrs")
-load("@prelude//cxx:cxx_toolchain_types.bzl", "LinkerType")
 load("@prelude//toolchains:cxx.bzl", "CxxToolsInfo")
 
 # This def is similar to the one in https://github.com/facebook/buck2/blob/804d62242214455d51787f7c8c96a1e12c75ec32/prelude/toolchains/cxx/clang/tools.bzl
@@ -42,7 +42,7 @@ path_clang_tools = rule(
     attrs = {},
 )
 
-def _remote_rust_toolchain_impl(ctx):    
+def _remote_rust_toolchain_impl(ctx):
     return [
         DefaultInfo(),
         RustToolchainInfo(

buck2/rust/toolchains/defs.bzl

@@ -12,16 +12,16 @@
 # License for the specific language governing permissions and limitations under
 # the License.
 
+load("@bazel_skylib//rules:common_settings.bzl", "string_flag")
+load("@rules_js//js:defs.bzl", "js_binary")
 load(
     "//:repo-names.bzl",
     "canonical_repo",
-    "workspace_root",
-    "repo_name_variable",
-    "repo_dir_variable",
     "gen_js_constants",
+    "repo_dir_variable",
+    "repo_name_variable",
+    "workspace_root",
 )
-load("@bazel_skylib//rules:common_settings.bzl", "string_flag")
-load("@rules_js//js:defs.bzl", "js_binary")
 
 # This value propagates through the rules below.
 # Try it with other targets of your choosing!
@@ -37,8 +37,10 @@ genrule(
     name = "repo-macros",
     outs = ["repo-macros.txt"],
     cmd = "printf '%s\n  canonical_name: %s\n  workspace_root: %s\n' >$@" % (
-      repo_target, canonical_repo(repo_target), workspace_root(repo_target)
-    )
+        repo_target,
+        canonical_repo(repo_target),
+        workspace_root(repo_target),
+    ),
 )
 
 # Demonstrates the custom Make variable-based approach. Depends on the
@@ -54,7 +56,7 @@ genrule(
     toolchains = [
         ":repo-name",
         ":repo-dir",
-    ]
+    ],
 )
 
 # This alias demonstrates how the rules from `repo-names.bzl` work with resolved
@@ -97,34 +99,34 @@ repo_dir_variable(
 # - where the repo dir is found when running under `bazel run` vs `node`
 js_binary(
     name = "repo-dir-check",
-    entry_point = "repo-dir-check.mjs",
     data = [
-      ":constants-impl",
-      repo_target,
+        ":constants-impl",
+        repo_target,
     ],
+    entry_point = "repo-dir-check.mjs",
 )
 
 # Determines which rule generates the `constants.js` module used by
 # `:repo-dir-check`, based on the value of the `--//:constants` flag.
 genrule(
     name = "constants-impl",
-    outs = ["constants.js"],
     srcs = select({
-        ":genrule":     [":genrule-constants"],
+        ":genrule": [":genrule-constants"],
         ":custom-rule": [":custom-rule-constants"],
     }),
+    outs = ["constants.js"],
     cmd = "cp $< $@",
 )
 
 # The `--//:constants` command line flag determines whether `:constants-impl`
 # selects `:genrule-constants` or `:custom-rule-constants` as input.
 string_flag(
     name = "constants",
+    build_setting_default = "genrule",
     values = [
         "genrule",
         "custom-rule",
     ],
-    build_setting_default = "genrule",
 )
 
 config_setting(
@@ -152,7 +154,7 @@ genrule(
     name = "genrule-constants",
     srcs = [":repo-target"],
     outs = ["genrule-constants.js"],
-    cmd  = r"""printf 'module.exports.%%s;\n' \
+    cmd = r"""printf 'module.exports.%%s;\n' \
         'ruleName = "genrule-constants"' \
         'target = "%s"' \
         'binDir = "$(BINDIR)"' \
@@ -161,10 +163,10 @@ genrule(
         'macroDir = "%s"' \
         'repoName = "$(repo-name)"' \
         'repoDir = "$(repo-dir)"' >$@""" % (
-            repo_target,
-            canonical_repo(repo_target),
-            workspace_root(repo_target)
-        ),
+        repo_target,
+        canonical_repo(repo_target),
+        workspace_root(repo_target),
+    ),
     toolchains = [
         ":repo-name",
         ":repo-dir",
@@ -191,14 +193,14 @@ genrule(
 # Replacing `repo_target` with the string ":repo-target" in the macros below
 # will produce the empty string, since the macros won't see the resolved alias.
 gen_js_constants(
-    name  = "custom-rule-constants",
-    deps = [":repo-target"],
-    vars  = {
-        "target":    repo_target,
-        "location":  "$(rlocationpaths :repo-target)",
+    name = "custom-rule-constants",
+    repo_dirs = {":repo-target": "repoDir"},
+    repo_names = {":repo-target": "repoName"},
+    vars = {
+        "target": repo_target,
+        "location": "$(rlocationpaths :repo-target)",
         "macroName": canonical_repo(repo_target),
-        "macroDir":  workspace_root(repo_target),
+        "macroDir": workspace_root(repo_target),
     },
-    repo_names = {":repo-target": "repoName"},
-    repo_dirs  = {":repo-target": "repoDir"},
+    deps = [":repo-target"],
 )

bzlmod/canonical-repo-name-injection/BUILD

@@ -15,7 +15,10 @@
 """Example module for canonical repo name injection"""
 
 # Main module
-module(name = "frobozz", version = "1.2.3")
+module(
+    name = "frobozz",
+    version = "1.2.3",
+)
 
 # aspect_rules_js
 bazel_dep(name = "aspect_rules_js", version = "2.0.1", repo_name = "rules_js")

bzlmod/canonical-repo-name-injection/MODULE.bazel

@@ -37,7 +37,8 @@ def _variable_info(ctx, value):
 
 repo_name_variable = rule(
     implementation = lambda ctx: _variable_info(
-        ctx, ctx.attr.dep.label.repo_name
+        ctx,
+        ctx.attr.dep.label.repo_name,
     ),
     doc = "Defines a custom variable for its dependency's repository name",
     attrs = {
@@ -50,7 +51,8 @@ repo_name_variable = rule(
 
 repo_dir_variable = rule(
     implementation = lambda ctx: _variable_info(
-        ctx, ctx.attr.dep.label.workspace_root
+        ctx,
+        ctx.attr.dep.label.workspace_root,
     ),
     doc = "Defines a custom variable for its dependency's repository dir",
     attrs = {
@@ -96,7 +98,7 @@ def _runfiles(ctx, sources, deps):
 
 def _gen_js_constants_impl(ctx):
     """Generate a JavaScript module exporting specified constants."""
-    items  = {"ruleName": ctx.attr.name, "binDir": ctx.bin_dir.path}
+    items = {"ruleName": ctx.attr.name, "binDir": ctx.bin_dir.path}
     items |= {k: ctx.expand_location(v) for k, v in ctx.attr.vars.items()}
     items |= {v: k.label.repo_name for k, v in ctx.attr.repo_names.items()}
     items |= {v: k.label.workspace_root for k, v in ctx.attr.repo_dirs.items()}
@@ -108,8 +110,8 @@ def _gen_js_constants_impl(ctx):
 
     sources = depset([outfile])
     deps = ctx.attr.deps + \
-        ctx.attr.repo_names.keys() + \
-        ctx.attr.repo_dirs.keys()
+           ctx.attr.repo_names.keys() + \
+           ctx.attr.repo_dirs.keys()
 
     return [
         _js_info(ctx.label, sources, deps),

bzlmod/canonical-repo-name-injection/repo-names.bzl

@@ -1,3 +1,7 @@
+load("@rules_cc//cc:cc_binary.bzl", "cc_binary")
+load("@rules_cc//cc:cc_library.bzl", "cc_library")
+load("@rules_cc//cc:cc_test.bzl", "cc_test")
+
 cc_binary(
     name = "cpp",
     srcs = ["main.cc"],
@@ -14,7 +18,7 @@ cc_library(
 
 cc_test(
     name = "cpp_test",
+    size = "small",
     srcs = ["hello_test.cc"],
     deps = [":cpp_lib"],
-    size = "small",
 )

cpp/BUILD

@@ -12,6 +12,9 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+load("@rules_java//java:java_test.bzl", "java_test")
+load("@rules_java//java/toolchains:java_runtime.bzl", "java_runtime")
+
 # Built from "Dockerfile"
 # TODO: edit this value to match your Docker registry, image name, and digest
 DOCKER_JDK_PSQL = "docker://gcr.io/YOUR-IMAGE-NAME@sha256:b6ed8f68abd6e23409ee7a500c2c50a8064cea11071ac447a59b88e6afa4c220"

docker/network/BUILD

@@ -1,3 +1,6 @@
+load("@rules_cc//cc:cc_binary.bzl", "cc_binary")
+load("@rules_java//java:java_binary.bzl", "java_binary")
+
 genrule(
     name = "hello",
     srcs = ["dep%d" % i for i in range(3)],

docker/sandbox/BUILD

@@ -12,14 +12,16 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+load("@rules_shell//shell:sh_test.bzl", "sh_test")
+
 sh_test(
     name = "check_docker",
     srcs = ["check_docker.sh"],
     exec_properties = {
         # Replace the container-image below to use the one you created.
         "container-image": "docker://645088952840.dkr.ecr.eu-west-1.amazonaws.com/engflow-ci/debian12-dind-x64@sha256:e9715893e041427c283808db96760634b47b276d35bef4fc2af3990553f94262",
         "dockerRuntime": "sysbox-runc",
-        "Pool": "ci_sysbox_x64", # this can change depending on what pool has sysbox enabled
+        "Pool": "ci_sysbox_x64",  # this can change depending on what pool has sysbox enabled
         "dockerNetwork": "standard",
         # DO NOT ENABLE!!! "dockerSiblingContainers": "True",
         # it will cause the worker to mount /var/run/docker.sock
@@ -28,5 +30,5 @@ sh_test(
         # DO NOT ENABLE!!! "dockerPrivileged": "True",
         # sysbox containers will refuse to start
     },
-    tags = ["manual"]
+    tags = ["manual"],
 )