move assignment outside if

samsonasik · samsonasik · commit 951098fb644e · 2018-08-14T02:14:22.000+07:00
diff --git a/src/Client.php b/src/Client.php
@@ -325,9 +325,11 @@ public function setUri($uri)
             }
 
             $uri = $this->getUri();
+            $user = $uri->getUser();
+            $password = $uri->getPassword();
 
             // Set auth if username and password has been specified in the uri
-            if (($user = $uri->getUser()) && ($password = $uri->getPassword())) {
+            if ($user && $password) {
                 $this->setAuth($user, $password);
             }
 

Original file line number	Diff line number	Diff line change
`@@ -325,9 +325,11 @@ public function setUri($uri)`
`325`	`325`	`}`
`326`	`326`
`327`	`327`	`$uri = $this->getUri();`
	`328`	`+ $user = $uri->getUser();`
	`329`	`+ $password = $uri->getPassword();`
`328`	`330`
`329`	`331`	`// Set auth if username and password has been specified in the uri`
`330`		`- if (($user = $uri->getUser()) && ($password = $uri->getPassword())) {`
	`332`	`+ if ($user && $password) {`
`331`	`333`	`$this->setAuth($user, $password);`
`332`	`334`	`}`
`333`	`335`