[Routing] support for array values in defaults

As pointed out in symfony/symfony-docs#4017, the XmlFileLoader was not
capable of defining array default values.

Author: xabbuh

src/Symfony/Component/Routing/Loader/XmlFileLoader.php

@@ -219,12 +219,9 @@ private function parseConfigs(\DOMElement $node, $path)
         foreach ($node->getElementsByTagNameNS(self::NAMESPACE_URI, '*') as $n) {
             switch ($n->localName) {
                 case 'default':
-                    if ($n->hasAttribute('xsi:nil') && 'true' == $n->getAttribute('xsi:nil')) {
-                        $defaults[$n->getAttribute('key')] = null;
-                    } else {
-                        $defaults[$n->getAttribute('key')] = trim($n->textContent);
+                    if ($node === $n->parentNode) {
+                        $defaults[$n->getAttribute('key')] = $this->parseDefaultsConfig($n);
                     }
-
                     break;
                 case 'requirement':
                     $requirements[$n->getAttribute('key')] = trim($n->textContent);
@@ -242,4 +239,27 @@ private function parseConfigs(\DOMElement $node, $path)
 
         return array($defaults, $requirements, $options, $condition);
     }
+
+    private function parseDefaultsConfig(\DOMElement $element)
+    {
+        if ($element->hasAttribute('xsi:nil') && 'true' == $element->getAttribute('xsi:nil')) {
+            return null;
+        }
+
+        if (1 === $element->childNodes->length && $element->firstChild instanceof \DOMText) {
+            return trim($element->firstChild->textContent);
+        }
+
+        $defaults = array();
+
+        foreach ($element->childNodes as $childNode) {
+            if ($childNode instanceof \DOMText) {
+                continue;
+            }
+
+            $defaults[$childNode->getAttribute('key')] = $this->parseDefaultsConfig($childNode);
+        }
+
+        return $defaults;
+    }
 }

src/Symfony/Component/Routing/Loader/schema/routing/routing-1.0.xsd

@@ -26,7 +26,7 @@
 
   <xsd:group name="configs">
     <xsd:choice>
-      <xsd:element name="default" nillable="true" type="element" />
+      <xsd:element name="default" nillable="true" type="default" />
       <xsd:element name="requirement" type="element" />
       <xsd:element name="option" type="element" />
       <xsd:element name="condition" type="condition" />
@@ -55,6 +55,13 @@
     <xsd:attribute name="methods" type="xsd:string" />
   </xsd:complexType>
 
+  <xsd:complexType name="default" mixed="true">
+    <xsd:choice minOccurs="0" maxOccurs="unbounded">
+      <xsd:element name="default" type="default" />
+    </xsd:choice>
+    <xsd:attribute name="key" type="xsd:string" use="required" />
+  </xsd:complexType>
+
   <xsd:complexType name="element">
     <xsd:simpleContent>
       <xsd:extension base="xsd:string">

src/Symfony/Component/Routing/Tests/Fixtures/array_defaults.xml

@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<routes xmlns="http://symfony.com/schema/routing"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:schemaLocation="http://symfony.com/schema/routing http://symfony.com/schema/routing/routing-1.0.xsd">
+
+    <route id="blog" path="/blog">
+        <default key="_controller">AcmeBlogBundle:Blog:index</default>
+        <default key="page">1</default>
+        <default key="foo">
+            <default key="bar">1</default>
+            <default key="baz">2</default>
+        </default>
+        <default key="foobar" xsi:nil="true" />
+    </route>
+</routes>

src/Symfony/Component/Routing/Tests/Loader/XmlFileLoaderTest.php

@@ -121,4 +121,24 @@ public function testDocTypeIsNotAllowed()
         $loader = new XmlFileLoader(new FileLocator(array(__DIR__.'/../Fixtures')));
         $loader->load('withdoctype.xml');
     }
+
+    public function testArrayDefaultsAreSupported()
+    {
+        $loader = new XmlFileLoader(new FileLocator(array(__DIR__.'/../Fixtures')));
+        $routeCollection = $loader->load('array_defaults.xml');
+        $route = $routeCollection->get('blog');
+
+        $this->assertEquals(
+            array(
+                '_controller' => 'AcmeBlogBundle:Blog:index',
+                'page' => '1',
+                'foo' => array(
+                    'bar' => '1',
+                    'baz' => '2',
+                ),
+                'foobar' => null,
+            ),
+            $route->getDefaults()
+        );
+    }
 }