Skip to content
This repository was archived by the owner on Mar 16, 2019. It is now read-only.

Commit dbafc98

Browse files
committed
Fix IOS syntax errors in #489
1 parent 39abada commit dbafc98

File tree

4 files changed

+24
-15
lines changed

4 files changed

+24
-15
lines changed

ios/RNFetchBlob/RNFetchBlob.m

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ - (NSDictionary *)constantsToExport
239239
RNFetchBlobFS * fileStream = [[RNFetchBlobFS alloc] initWithBridgeRef:self.bridge];
240240
NSFileManager * fm = [NSFileManager defaultManager];
241241
NSString * folder = [path stringByDeletingLastPathComponent];
242-
242+
NSError* err = nil;
243243
BOOL isDir = NO;
244244
BOOL exists = [fm fileExistsAtPath:path isDirectory: &isDir];
245245

@@ -257,7 +257,7 @@ - (NSDictionary *)constantsToExport
257257
}
258258

259259
NSString * streamId = [fileStream openWithPath:path encode:encoding appendData:append];
260-
callback(@[[NSNull null], @[NSNull null], streamId]);
260+
callback(@[[NSNull null], [NSNull null], streamId]);
261261
}
262262

263263
#pragma mark - fs.writeArrayChunk
@@ -467,7 +467,8 @@ - (NSDictionary *)constantsToExport
467467
resolver:(RCTPromiseResolveBlock)resolve
468468
rejecter:(RCTPromiseRejectBlock)reject)
469469
{
470-
[RNFetchBlobFS readFile:path encoding:encoding onComplete:^(id content, NSString * code, NSString * err) {
470+
471+
[RNFetchBlobFS readFile:path encoding:encoding onComplete:^(NSData * content, NSString * code, NSString * err) {
471472
if(err != nil) {
472473
reject(code, err, nil);
473474
return;

ios/RNFetchBlobFS.h

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,16 @@
5858
// fs methods
5959
+ (RNFetchBlobFS *) getFileStreams;
6060
+ (BOOL) mkdir:(NSString *) path;
61+
+ (void) mkdir:(NSString *) path resolver:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject;
62+
+ (void) hash:(NSString *)path
63+
algorithm:(NSString *)algorithm
64+
resolver:(RCTPromiseResolveBlock)resolve
65+
rejecter:(RCTPromiseRejectBlock)reject;
6166
+ (NSDictionary *) stat:(NSString *) path error:(NSError **) error;
6267
+ (void) exists:(NSString *) path callback:(RCTResponseSenderBlock)callback;
6368
+ (void) writeFileArray:(NSString *)path data:(NSArray *)data append:(BOOL)append resolver:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject;
6469
+ (void) writeFile:(NSString *)path encoding:(NSString *)encoding data:(NSString *)data append:(BOOL)append resolver:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject;
65-
+ (void) readFile:(NSString *)path encoding:(NSString *)encoding onComplete:(void (^)(NSData * content, NSString * errMsg))onComplete;
70+
+ (void) readFile:(NSString *)path encoding:(NSString *)encoding onComplete:(void (^)(NSData * content, NSString* code, NSString * errMsg))onComplete;
6671
+ (void) readAssetFile:(NSData *)assetUrl completionBlock:(void(^)(NSData * content))completionBlock failBlock:(void(^)(NSError * err))failBlock;
6772
+ (void) slice:(NSString *)path
6873
dest:(NSString *)dest

ios/RNFetchBlobFS.m

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -469,7 +469,7 @@ + (void) writeFileArray:(NSString *)path
469469

470470
+ (void) readFile:(NSString *)path
471471
encoding:(NSString *)encoding
472-
onComplete:(void (^)(id content, NSString * codeStr, NSString * errMsg))onComplete
472+
onComplete:(void (^)(NSData * content, NSString * codeStr, NSString * errMsg))onComplete
473473
{
474474
[[self class] getPathFromUri:path completionHandler:^(NSString *path, ALAssetRepresentation *asset) {
475475
__block NSData * fileContent;
@@ -535,10 +535,10 @@ + (void) readFile:(NSString *)path
535535

536536
# pragma mark - hash
537537

538-
RCT_EXPORT_METHOD(hash:(NSString *)path
538+
+ (void) hash:(NSString *)path
539539
algorithm:(NSString *)algorithm
540540
resolver:(RCTPromiseResolveBlock)resolve
541-
rejecter:(RCTPromiseRejectBlock)reject)
541+
rejecter:(RCTPromiseRejectBlock)reject
542542
{
543543
BOOL isDir = NO;
544544
BOOL exists = NO;
@@ -547,7 +547,7 @@ + (void) readFile:(NSString *)path
547547
if (isDir) {
548548
return reject(@"EISDIR", [NSString stringWithFormat:@"Expecting a file but '%@' is a directory", path], nil);
549549
}
550-
if (!fileExists) {
550+
if (!exists) {
551551
return reject(@"ENOENT", [NSString stringWithFormat:@"No such file '%@'", path], nil);
552552
}
553553

@@ -556,11 +556,13 @@ + (void) readFile:(NSString *)path
556556
NSDictionary *attributes = [[NSFileManager defaultManager] attributesOfItemAtPath:path error:&error];
557557

558558
if (error) {
559-
return [self reject:reject withError:error];
559+
reject(@"EUNKNOWN", [error description], nil);
560+
return;
560561
}
561562

562563
if ([attributes objectForKey:NSFileType] == NSFileTypeDirectory) {
563-
return reject(@"EISDIR", [NSString stringWithFormat:@"Expecting a file but '%@' is a directory", path], nil);
564+
reject(@"EISDIR", [NSString stringWithFormat:@"Expecting a file but '%@' is a directory", path], nil);
565+
return;
564566
}
565567

566568
NSData *content = [[NSFileManager defaultManager] contentsAtPath:path];
@@ -599,7 +601,8 @@ + (void) readFile:(NSString *)path
599601
} else if ([algorithm isEqualToString:@"sha512"]) {
600602
CC_SHA512(content.bytes, (CC_LONG)content.length, buffer);
601603
} else {
602-
return reject(@"EINVAL", [NSString stringWithFormat:@"Invalid algorithm '%@', must be one of md5, sha1, sha224, sha256, sha384, sha512", algorithm], nil);
604+
reject(@"EINVAL", [NSString stringWithFormat:@"Invalid algorithm '%@', must be one of md5, sha1, sha224, sha256, sha384, sha512", algorithm], nil);
605+
return;
603606
}
604607

605608
NSMutableString *output = [NSMutableString stringWithCapacity:digestLength * 2];

ios/RNFetchBlobReqBuilder.m

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -118,17 +118,17 @@ +(void) buildOctetRequest:(NSDictionary *)options
118118
if([orgPath hasPrefix:AL_PREFIX])
119119
{
120120

121-
[RNFetchBlobFS readFile:orgPath encoding:nil onComplete:^(NSData *content, NSString * err) {
121+
[RNFetchBlobFS readFile:orgPath encoding:nil onComplete:^(id content, NSString* code, NSString * err) {
122122
if(err != nil)
123123
{
124124
onComplete(nil, nil);
125125
}
126126
else
127127
{
128-
[request setHTTPBody:content];
128+
[request setHTTPBody:((NSData *)content)];
129129
[request setHTTPMethod: method];
130130
[request setAllHTTPHeaderFields:mheaders];
131-
onComplete(request, [content length]);
131+
onComplete(request, [((NSData *)content) length]);
132132
}
133133
}];
134134

@@ -222,7 +222,7 @@ void __block (^getFieldData)(id field) = ^(id field)
222222
NSString * orgPath = [content substringFromIndex:[FILE_PREFIX length]];
223223
orgPath = [RNFetchBlobFS getPathOfAsset:orgPath];
224224

225-
[RNFetchBlobFS readFile:orgPath encoding:nil onComplete:^(NSData *content, NSString * err) {
225+
[RNFetchBlobFS readFile:orgPath encoding:nil onComplete:^(NSData *content, NSString* code, NSString * err) {
226226
if(err != nil)
227227
{
228228
onComplete(formData, YES);

0 commit comments

Comments
 (0)