Fix multipart data format on Android #183

Author: wkh237

src/android/src/main/java/com/RNFetchBlob/RNFetchBlobBody.java

@@ -196,7 +196,7 @@ private File createMultipartBodyCache() throws IOException {
             // form begin
             String header = "--" + boundary + "\r\n";
             if (field.filename != null) {
-                header += "Content-Disposition: form-data; name=" + name + "; filename=" + field.filename + "\r\n";
+                header += "Content-Disposition: form-data; name=\"" + name + "\"; filename=\"" + field.filename + "\"\r\n";
                 header += "Content-Type: " + field.mime + "\r\n\r\n";
                 os.write(header.getBytes());
                 // file field header end

src/ios/RNFetchBlobReqBuilder.h

@@ -29,14 +29,6 @@
                      body:(NSString *)body
                onComplete:(void(^)(NSURLRequest * req, long bodyLength))onComplete;
 
-+(void) buildEncodedRequest:(NSDictionary *)options
-                      taskId:(NSString *)taskId
-                      method:(NSString *)method
-                         url:(NSString *)url
-                     headers:(NSDictionary *)headers
-                        form:(NSString *)body
-                  onComplete:(void(^)(__weak NSURLRequest * req, long bodyLength))onComplete;
-
 +(NSString *) getHeaderIgnoreCases:(NSString *)field fromHeaders:(NSMutableArray *) headers;
 
 

src/ios/RNFetchBlobReqBuilder.m

@@ -54,8 +54,8 @@ +(void) buildMultipartRequest:(NSDictionary *)options
                 [request setHTTPBody:postData];
             }
             // set content-length
-            [mheaders setValue:[NSString stringWithFormat:@"%d",[postData length]] forKey:@"Content-Length"];
-            [mheaders setValue:[NSString stringWithFormat:@"100-continue",[postData length]] forKey:@"Expect"];
+            [mheaders setValue:[NSString stringWithFormat:@"%lu",[postData length]] forKey:@"Content-Length"];
+            [mheaders setValue:@"100-continue" forKey:@"Expect"];
             // appaned boundary to content-type
             [mheaders setValue:[NSString stringWithFormat:@"multipart/form-data; charset=utf-8; boundary=%@", boundary] forKey:@"content-type"];
             [request setHTTPMethod: method];
@@ -176,12 +176,12 @@ void __block (^getFieldData)(id field) = ^(id field)
             {
                 i++;
                 getFieldData([form objectAtIndex:i]);
-                RCTLogWarn(@"RNFetchBlob multipart request builder has found a field without `data` or `name` property, the field will be removed implicitly.", field);
+                RCTLogWarn(@"RNFetchBlob multipart request builder has found a field without `data` or `name` property, the field will be removed implicitly.");
                 return;
             }
             contentType = contentType == nil ? @"application/octet-stream" : contentType;
             // field is a text field
-            if([field valueForKey:@"filename"] == nil || content == [NSNull null]) {
+            if([field valueForKey:@"filename"] == nil || content == nil) {
                 [formData appendData:[[NSString stringWithFormat:@"--%@\r\n", boundary] dataUsingEncoding:NSUTF8StringEncoding]];
                 [formData appendData:[[NSString stringWithFormat:@"Content-Disposition: form-data; name=\"%@\"\r\n", name] dataUsingEncoding:NSUTF8StringEncoding]];
                 [formData appendData:[[NSString stringWithFormat:@"Content-Type: text/plain\r\n\r\n"] dataUsingEncoding:NSUTF8StringEncoding]];
@@ -247,7 +247,7 @@ void __block (^getFieldData)(id field) = ^(id field)
     }
 }
 
-+(NSString *) getHeaderIgnoreCases:(NSString *)field fromHeaders:(NSMutableArray *) headers {
++(NSString *) getHeaderIgnoreCases:(NSString *)field fromHeaders:(NSMutableDictionary *) headers {
 
     NSString * normalCase = [headers valueForKey:field];
     NSString * ignoredCase = [headers valueForKey:[field lowercaseString]];