Skip to content

Commit 1c0698b

Browse files
committed
update
1 parent 74c7294 commit 1c0698b

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

cmd.go

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -597,16 +597,16 @@ func RunCmdWriterxWithContext(ctx context.Context, params []string, wait time.Du
597597
return
598598
}
599599

600-
func CloseProcessFromPidFile(pidFile string) (err error) {
600+
func CloseProcessFromPidFile(pidFile string) error {
601601
if pidFile == `` {
602-
return
602+
return nil
603603
}
604604
b, err := os.ReadFile(pidFile)
605605
if err != nil {
606606
if os.IsNotExist(err) {
607607
return nil
608608
}
609-
return
609+
return err
610610
}
611611
pid, err := strconv.Atoi(strings.TrimSpace(string(b)))
612612
if err != nil {
@@ -615,15 +615,18 @@ func CloseProcessFromPidFile(pidFile string) (err error) {
615615
return CloseProcessFromPid(pid)
616616
}
617617

618-
func CloseProcessFromPid(pid int) (err error) {
618+
func CloseProcessFromPid(pid int) error {
619619
if pid <= 0 {
620620
return nil
621621
}
622622
procs, err := os.FindProcess(pid)
623623
if err == nil {
624-
return procs.Kill()
624+
err = procs.Kill()
625625
}
626-
return
626+
if err != nil && errors.Is(err, os.ErrProcessDone) {
627+
return nil
628+
}
629+
return err
627630
}
628631

629632
func CloseProcessFromCmd(cmd *exec.Cmd) error {
@@ -634,6 +637,9 @@ func CloseProcessFromCmd(cmd *exec.Cmd) error {
634637
return nil
635638
}
636639
err := cmd.Process.Kill()
640+
if err != nil && errors.Is(err, os.ErrProcessDone) {
641+
return nil
642+
}
637643
if cmd.ProcessState == nil || cmd.ProcessState.Exited() {
638644
return nil
639645
}

0 commit comments

Comments
 (0)