From 6ad675d39fecc7b0a09af0d4af3a29ee72c9df89 Mon Sep 17 00:00:00 2001 From: EugeneHlushko Date: Tue, 7 May 2019 11:50:07 +0300 Subject: [PATCH 1/2] misc(seo) add canonical to the pages html, use trailing slash for consistency with github pages --- src/server.jsx | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/server.jsx b/src/server.jsx index 0fdebeb71bbe..9fe9bcf03850 100644 --- a/src/server.jsx +++ b/src/server.jsx @@ -20,6 +20,12 @@ const bundles = [ '/index.bundle.js' ]; +// As github pages uses trailing slash, we need to provide it to canonicals for consistency +// between canonical href and final url served by github pages. +function enforceTrailingSlash (url) { + return url.replace(/\/?$/, '/'); +} + // Export method for `SSGPlugin` export default locals => { let { assets } = locals.webpackStats.compilation; @@ -49,6 +55,7 @@ export default locals => { ))} +
From 5e2977a5c9d70876ced2323261b3f553cbe5ff6b Mon Sep 17 00:00:00 2001 From: EugeneHlushko Date: Wed, 8 May 2019 18:37:31 +0300 Subject: [PATCH 2/2] misc(seo) fix sitemap to not mention index.html for each page --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index b1a71983a3ab..e8611c167ebd 100644 --- a/package.json +++ b/package.json @@ -45,7 +45,7 @@ "lint:prose": "cp .proselintrc ~/ && proselint src/content", "lint:links": "hyperlink -r dist/index.html --canonicalroot https://webpack.js.org/ -i --todo https://img.shields.io --todo https://codecov.io/gh --todo 'content-type-mismatch https://travis-ci.org' --todo 'Asset is used as both Html and Image' | tee internal-links.tap | tap-spot", "linkcheck": "hyperlink -r dist/index.html --canonicalroot https://webpack.js.org/ --skip support__ --skip sidecar.gitter.im --skip vimdoc.sourceforge.net --skip img.shields.io --skip npmjs.com/package/ --skip opencollective.com/webpack --todo external-redirect | tee external-links.tap | tap-spot", - "sitemap": "cd dist && sitemap-static --prefix=https://webpack.js.org/ > sitemap.xml", + "sitemap": "cd dist && sitemap-static --pretty --prefix=https://webpack.js.org/ > sitemap.xml", "serve": "npm run build && sirv start ./dist --port 4000", "deploy": "gh-pages -d dist" },