Skip to content

Commit f6d0c17

Browse files
fix: linting, update dependencies and github api package name
1 parent 708c776 commit f6d0c17

File tree

8 files changed

+9543
-17
lines changed

8 files changed

+9543
-17
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@
3838
"deploy": "gh-pages -d build"
3939
},
4040
"devDependencies": {
41-
"alex": "^4.1.0",
41+
"@octokit/rest": "^15.2.6",
42+
"alex": "^5.1.0",
4243
"async": "^2.5.0",
4344
"autoprefixer": "^7.2.3",
4445
"babel-core": "^6.26.0",
@@ -62,7 +63,6 @@
6263
"fontgen-loader": "^0.2.1",
6364
"front-matter": "^2.3.0",
6465
"gh-pages": "^1.0.0",
65-
"github": "^10.0.0",
6666
"html-webpack-plugin": "^2.30.1",
6767
"html-webpack-template": "^6.1.0",
6868
"http-server": "^0.10.0",

src/scripts/fetch.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ set -e # Exit with nonzero exit code if anything fails
1313
# node ./src/scripts/fetch_package_names.js "webpack-contrib" "-loader" | node ./src/scripts/fetch_package_files.js "README.md" "./generated/loaders"
1414
# node ./src/scripts/fetch_package_names.js "babel" "babel-loader" | node ./src/scripts/fetch_package_files.js "README.md" "./generated/loaders"
1515
# node ./src/scripts/fetch_package_names.js "postcss" "postcss-loader" | node ./src/scripts/fetch_package_files.js "README.md" "./generated/loaders"
16-
# node ./src/scripts/fetch_package_names.js "peerigon" "extract-loader" | node ./src/scripts/fetch_package_files.js "README.md" "./generated/loaders"
16+
node ./src/scripts/fetch_package_names.js "peerigon" "extract-loader" | node ./src/scripts/fetch_package_files.js "README.md" "./generated/loaders"
1717

1818
# Fetch webpack-contrib (and various other) plugin repositories
1919
# node ./src/scripts/fetch_package_names.js "webpack-contrib" "-webpack-plugin" | node ./src/scripts/fetch_package_files.js "README.md" "./generated/plugins"

src/scripts/fetch_package_names.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#!/usr/bin/env node
22
// ./fetch_package_names <suffix> > output
33
// ./fetch_package_names "-loader" > output.json
4-
const GitHubApi = require("github");
4+
const GitHubApi = require('@octokit/rest');
55

66
if (require.main === module) {
77
main();
@@ -39,13 +39,13 @@ function fetchPackageNames(options, cb) {
3939
github.repos.getForOrg({
4040
org: options.organization,
4141
per_page: 100
42-
}, function (err, d) {
42+
}, function (err, response) {
4343
if (err) {
4444
return cb(err);
4545
}
4646

47-
return cb(null, d.data.filter(function(o) {
48-
return o.name.endsWith(options.suffix);
47+
return cb(null, response.data.filter(function(organization) {
48+
return organization.name.endsWith(options.suffix);
4949
}));
5050
});
5151
}

src/scripts/fetch_supporters.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ const fs = require('fs');
33
const request = require('request');
44

55
const REQUIRED_KEYS = ['totalDonations', 'id'];
6-
const filename = '_supporters.json'
6+
const filename = '_supporters.json';
77

88
request('https://opencollective.com/api/groups/webpack/backers', (err, response, body) => {
99
if (err) console.error('Failed to fetch backers: ', err);

webpack.common.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -114,14 +114,14 @@ module.exports = (env = {}) => ({
114114
.replace(item.extension, '')
115115
.replace(options.dir, '')
116116
.replace(/\/index$/, '')
117-
.replace(/^$/, '/')
117+
.replace(/^$/, '/');
118118

119119
// TODO: Strip `_` prefix from filenames in `url`
120120
if (item.type === 'file') {
121-
let content = fs.readFileSync(item.path, 'utf8')
122-
let { attributes } = FrontMatter(content)
123-
Object.assign(item, attributes)
124-
item.anchors = [] // TODO: Add actual anchors
121+
let content = fs.readFileSync(item.path, 'utf8');
122+
let { attributes } = FrontMatter(content);
123+
Object.assign(item, attributes);
124+
item.anchors = []; // TODO: Add actual anchors
125125

126126
} else {
127127
// TODO: Add directory (section) attributes and index url (if necessary)
@@ -137,4 +137,4 @@ module.exports = (env = {}) => ({
137137
publicPath: '/',
138138
filename: '[name].bundle.js'
139139
}
140-
})
140+
});

webpack.dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,4 +32,4 @@ module.exports = env => merge(common(env), {
3232
compress: true,
3333
historyApiFallback: true
3434
}
35-
})
35+
});

webpack.prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ const prod = {
1717
'process.env.NODE_ENV': JSON.stringify('production')
1818
})
1919
]
20-
}
20+
};
2121

2222
// Export both SSG and SPA configurations
2323
module.exports = env => [
@@ -81,4 +81,4 @@ module.exports = env => [
8181
})
8282
]
8383
})
84-
]
84+
];

0 commit comments

Comments
 (0)