Skip to content

Commit 8b4123d

Browse files
committed
Resolve conflicts
1 parent 388bec7 commit 8b4123d

File tree

5 files changed

+10
-5
lines changed

5 files changed

+10
-5
lines changed

src/components/SidebarItem/SidebarItem.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838
padding-left: 1.5em;
3939
overflow: hidden;
4040
list-style: none;
41+
line-height: 19px;
4142

4243
&:before {
4344
content: '';

src/content/api/stats.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ title: Stats Data
33
sort: 3
44
contributors:
55
- skipjack
6+
- franjohn21
67
---
78

89
When compiling source code with webpack, users can generate a JSON file containing statistics about modules. These statistics can be used to analyze an application's dependency graph as well as to optimize compilation speed. The file is typically generated with the following CLI command:
@@ -24,6 +25,7 @@ The top-level structure of the output JSON file is fairly straightforward but th
2425
"hash": "11593e3b3ac85436984a", // Compilation specific hash
2526
"time": 2469, // Compilation time in milliseconds
2627
"filteredModules": 0, // A count of excluded modules when [`exclude`](/configuration/stats/#stats) is passed to the [`toJson`](/api/node/#stats-tojson-options-) method
28+
"outputPath": "/", // path to webpack output directory
2729
"assetsByChunkName": {
2830
// Chunk name to emitted asset(s) mapping
2931
"main": "web.js?h=11593e3b3ac85436984a",

src/content/guides/production.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ __webpack.prod.js__
177177
+ sourceMap: true
178178
+ })
179179
]
180-
})
180+
});
181181
```
182182

183183
T> Avoid `inline-***` and `eval-***` use in production as they can increase bundle size and reduce the overall performance.
@@ -200,12 +200,13 @@ __webpack.prod.js__
200200
plugins: [
201201
new UglifyJSPlugin({
202202
sourceMap: true
203-
}),
203+
- })
204+
+ }),
204205
+ new webpack.DefinePlugin({
205206
+ 'process.env.NODE_ENV': JSON.stringify('production')
206207
+ })
207208
]
208-
})
209+
});
209210
```
210211

211212
T> Technically, `NODE_ENV` is a system environment variable that Node.js exposes into running scripts. It is used by convention to determine dev-vs-prod behavior by server tools, build scripts, and client-side libraries. Contrary to expectations, `process.env.NODE_ENV` is not set to `"production"` __within__ the build script `webpack.config.js`, see [#2537](https://github.com/webpack/webpack/issues/2537). Thus, conditionals like `process.env.NODE_ENV === 'production' ? '[name].[hash].bundle.js' : '[name].bundle.js'` within webpack configurations do not work as expected.

src/content/guides/progressive-web-application.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ title: Progressive Web Application
33
sort: 14
44
contributors:
55
- johnnyreilly
6+
- chenxsan
67
---
78

89
T> This guide extends on code examples found in the [Output Management](/guides/output-management) guide.
@@ -78,7 +79,7 @@ __webpack.config.js__
7879
+ title: 'Progressive Web Application'
7980
- })
8081
+ }),
81-
+ new WorkboxPlugin({
82+
+ new WorkboxPlugin.GenerateSW({
8283
+ // these options encourage the ServiceWorkers to get in there fast
8384
+ // and not allow any straggling "old" SWs to hang around
8485
+ clientsClaim: true,

src/content/guides/tree-shaking.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ webpack-demo
4040
|- index.html
4141
|- /src
4242
|- index.js
43-
|- math.js
43+
+ |- math.js
4444
|- /node_modules
4545
```
4646

0 commit comments

Comments
 (0)