fix lint (#4231)

chenxsan · web-flow · commit 13edb7abf9da · 2020-12-03T12:53:33.000+08:00
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -14,10 +14,7 @@ module.exports = {
     __DEV__: true,
   },
   rules: {
-    'no-undef': 2,
-    'no-unreachable': 2,
-    'no-unused-vars': 0,
-    'no-console': 0,
+    'no-console': 'off',
     semi: ['error', 'always'],
     quotes: ['error', 'single'],
     'react/jsx-uses-react': 'off', // no longer needed with new jsx transform
@@ -39,10 +36,11 @@ module.exports = {
       rules: {
         indent: ['error', 2],
         quotes: ['error', 'single'],
-        'no-undef': 0,
-        'no-constant-condition': 0,
-        'no-useless-escape': 0,
-        'no-dupe-keys': 0,
+        'no-undef': 'off',
+        'no-unused-vars': 'off',
+        'no-constant-condition': 'off',
+        'no-useless-escape': 'off',
+        'no-dupe-keys': 'off',
       },
     },
   ],
diff --git a/cypress/plugins/index.js b/cypress/plugins/index.js
@@ -15,7 +15,7 @@
 /**
  * @type {Cypress.PluginConfig}
  */
-module.exports = (on, config) => {
+module.exports = () => {
   // `on` is used to hook into various events Cypress emits
   // `config` is the resolved Cypress config
 };
diff --git a/cypress/support/commands.js b/cypress/support/commands.js
@@ -1,5 +1,3 @@
-const windowInnerWidth = Cypress.config('viewportWidth');
-const windowInnerHeight = Cypress.config('viewportHeight');
 Cypress.Commands.add('isNotInViewport', element => {
   cy.get(element).then($el => {
     // we won't have horizontal scollbar
diff --git a/src/components/Configuration/Configuration.jsx b/src/components/Configuration/Configuration.jsx
@@ -1,6 +1,5 @@
 import { Children, isValidElement } from 'react';
 import { Details } from './components';
-import PropTypes from 'prop-types';
 
 const detailComponentsList = ['link', 'mode', 'entry', 'path', 'filename', 'publicPath', 'library', 'libraryType', 'libraryName', 'advancedLibrary', 'advancedOutput', 'expertOutput', 'expertOutputB', 'expert', 'advancedConditions', 'moduleType', 'advancedActions', 'advancedModule', 'modules', 'alias', 'advancedResolve', 'expertResolve', 'hints', 'devtool', 'target', 'externals', 'externalsType', 'externalsPresets', 'ignoreWarnings', 'stats', 'preset', 'advancedGlobal', 'advancedAssets', 'advancedChunkGroups', 'advancedChunks', 'advancedModules', 'expertModules', 'advancedStatsOptimization', 'advancedOptimization', 'cacheGroupAdvancedSelectors', 'cacheGroupAdvancedEffects', 'advancedSelectors', 'advancedEffects', 'fallbackCacheGroup', 'advanced', 'advancedCaching', 'advancedBuild'];
 export const Pre = props => {
diff --git a/src/components/Configuration/components.js b/src/components/Configuration/components.js
@@ -1,7 +1,6 @@
 import { isValidElement, Component } from 'react';
 import Popover from 'react-tiny-popover';
 import './Configuration.scss';
-import { timeout } from 'q';
 import PropTypes from 'prop-types';
 
 const DEFAULT_CHILDREN_SIZE = 4;
diff --git a/src/components/Cube/Cube.jsx b/src/components/Cube/Cube.jsx
@@ -208,7 +208,7 @@ export default class Cube extends Component {
    *
    * @param {object} e - Native event
    */
-  _spin = e => {
+  _spin = () => {
     let obj = {};
     let axis = this._getRandomAxis();
     let sign = Math.random() < 0.5 ? -1 : 1;
@@ -223,7 +223,7 @@ export default class Cube extends Component {
    *
    * @param {object} e - Native event
    */
-  _reset = e => {
+  _reset = () => {
     this.setState({
       x: 0,
       y: 0,
diff --git a/src/components/Dropdown/Dropdown.jsx b/src/components/Dropdown/Dropdown.jsx
@@ -103,7 +103,7 @@ export default class Dropdown extends Component {
     this.links[newIndex].focus();
   }
 
-  _handleClick(e) {
+  _handleClick() {
     this.setState({active: !this.state.active}, () => {
       if (this.state.active) {
         this.links[0].focus();
diff --git a/src/components/Link/Link.jsx b/src/components/Link/Link.jsx
@@ -9,6 +9,7 @@ export default ({
   // mimick the `NavLink` API
   if ( url ) to = url;
 
+  // eslint-disable-next-line
   const {isActive, ...others} = props;
   if ( to.startsWith('http') || to.startsWith('//') )
     {
diff --git a/src/components/NotificationBar/NotificationBar.jsx b/src/components/NotificationBar/NotificationBar.jsx
@@ -46,7 +46,7 @@ class MessageBar extends Component {
    *
    * @param {object} e - Click event
    */
-  close(e) {
+  close() {
     localStorage.setItem('notification-dismissed', version);
     this.props.onClose();
   }
diff --git a/src/components/Organization/Organization.jsx b/src/components/Organization/Organization.jsx
@@ -5,7 +5,7 @@ import Shield from '../Shield/Shield';
 import Items from './projects.json';
 import './Organization.scss';
 
-const Organization = props => {
+const Organization = () => {
   return (
     <Container className='organization page__content markdown'>
       <h1>The Organization</h1>
diff --git a/src/components/Page/Page.jsx b/src/components/Page/Page.jsx
@@ -61,7 +61,7 @@ class Page extends Component {
 
           })
         )
-        .catch(error =>
+        .catch(() =>
           this.setState({
             content: 'Error loading content.'
           })
diff --git a/src/components/PageLinks/PageLinks.jsx b/src/components/PageLinks/PageLinks.jsx
@@ -7,7 +7,6 @@ const baseURL = 'https://github.com/webpack/webpack.js.org/edit/master/';
 
 export default function PageLinks({
   page = {},
-  ...props
 }) {
   const editLink = page.edit || Url.resolve(baseURL, page.path);
 
diff --git a/src/components/SidebarItem/SidebarItem.jsx b/src/components/SidebarItem/SidebarItem.jsx
@@ -22,7 +22,7 @@ export default class SidebarItem extends Component {
   renderAnchors(anchors) {
     return (
       <ul className={`${block}__anchors`}>
-        {anchors.map((anchor, i) => (
+        {anchors.map((anchor) => (
           <li
             key={this._generateAnchorURL(anchor)}
             className={`${block}__anchor`}
@@ -95,7 +95,7 @@ export default class SidebarItem extends Component {
    *
    * @param {object} e - Click event
    */
-  _toggle(e) {
+  _toggle() {
     this.setState({
       open: !this.state.open
     });
diff --git a/src/components/Site/Site.jsx b/src/components/Site/Site.jsx
@@ -104,7 +104,7 @@ class Site extends Component {
           <Route exact strict path="/:url*" render={props => <Redirect to={`${props.location.pathname}/`}/>} />
           <Route path="/" exact component={Splash} />
           <Route
-            render={props => (
+            render={() => (
               <Container className="site__content">
                 <Switch>
                   <Route path="/vote" component={Vote} />
@@ -116,7 +116,7 @@ class Site extends Component {
                       key={page.url}
                       exact={true}
                       path={page.url}
-                      render={props => {
+                      render={() => {
                         let path = page.path.replace('src/content/', '');
                         let content = this.props.import(path);
                         const { previous, next } = getAdjacentPages(
@@ -144,7 +144,7 @@ class Site extends Component {
                       }}
                     />
                   ))}
-                  <Route render={props => <PageNotFound />} />
+                  <Route render={() => <PageNotFound />} />
                 </Switch>
               </Container>
             )}
diff --git a/src/components/Sponsors/Sponsors.jsx b/src/components/Sponsors/Sponsors.jsx
@@ -1,4 +1,3 @@
-import PropTypes from 'prop-types';
 // Import External Dependencies
 import Link from '../Link/Link';
 
@@ -10,7 +9,7 @@ import WebpackIcon from '../../assets/icon-square-small.svg';
 import '../Sponsors/Sponsors.scss';
 
 // Create and export the component
-const Sponsors = (props) => {
+const Sponsors = () => {
   return (
     <div className="sponsors">
       <Link
diff --git a/src/components/StarterKits/StarterKits.jsx b/src/components/StarterKits/StarterKits.jsx
@@ -13,7 +13,7 @@ import isClient from '../../utilities/is-client';
 
 const StarterKitsTable = lazy(() => import('./StarterKitsTable'));
 
-const StarterKits = props => (
+const StarterKits = () => (
   <Container className="starter-kits page__content markdown">
     <h1>Starter Kits</h1>
 
diff --git a/src/components/StarterKits/StarterKitsTable.jsx b/src/components/StarterKits/StarterKitsTable.jsx
@@ -1,7 +1,7 @@
 import Kits from './_starter-kits.json';
 import Link from '../Link/Link';
 
-const StarterKitsTable = props => (
+const StarterKitsTable = () => (
   <tbody className="table-body">
     {Kits.map((kit, i) => (
       <tr className="table-tr" key={i}>
diff --git a/src/scripts/concatenate-docs.js b/src/scripts/concatenate-docs.js
@@ -33,7 +33,7 @@ function getDirectoryRecursive(basePath) {
 			if (fs.statSync(fullPath).isDirectory()) {
 				getDirectoryRecursive(fullPath);
 			} else if (fullPath.endsWith('.md') || fullPath.endsWith('.mdx')) {
-				let fc = fileContents[fileContents.length] = front(fs.readFileSync(fullPath).toString());
+				fileContents[fileContents.length] = front(fs.readFileSync(fullPath).toString());
 			}
 		}
 
diff --git a/src/utilities/content-tree-enhancers.js b/src/utilities/content-tree-enhancers.js
@@ -62,7 +62,7 @@ const enhance = (tree, options) => {
   }
 };
 
-const filter = item => true;
+const filter = () => true;
 
 const sort = (a, b) => {
   let group1 = (a.group || '').toLowerCase();
diff --git a/src/utilities/fetch-package-readmes.js b/src/utilities/fetch-package-readmes.js
@@ -28,7 +28,7 @@ async function main() {
     const repos = JSON.parse(await readFile(path.resolve(__dirname, `../../repositories/${type}.json`)));
 
     for (const repo of repos) {
-      const [org, packageName] = repo.split('/');
+      const [, packageName] = repo.split('/');
       const url = `https://raw.githubusercontent.com/${repo}/master/README.md`;
       const htmlUrl = `https://github.com/${repo}`;
       const editUrl = `${htmlUrl}/edit/master/README.md`;
diff --git a/webpack.common.js b/webpack.common.js
@@ -19,7 +19,7 @@ const mdPlugins = [
     require('remark-autolink-headings'),
     {
       behavior: 'append',
-      content(node) {
+      content() {
         return [
           h('span.header-link')
         ];
@@ -41,7 +41,7 @@ const mdPlugins = [
   require('remark-refractor')
 ];
 
-module.exports = (env = {}) => ({
+module.exports = () => ({
   context: path.resolve(__dirname, './src'),
   cache: {
     type: 'filesystem',

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-const windowInnerWidth = Cypress.config('viewportWidth');`
`2`		`-const windowInnerHeight = Cypress.config('viewportHeight');`
`3`	`1`	`Cypress.Commands.add('isNotInViewport', element => {`
`4`	`2`	`cy.get(element).then($el => {`
`5`	`3`	`// we won't have horizontal scollbar`
Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ export default class Dropdown extends Component {`
`103`	`103`	`this.links[newIndex].focus();`
`104`	`104`	`}`
`105`	`105`
`106`		`- _handleClick(e) {`
	`106`	`+ _handleClick() {`
`107`	`107`	`this.setState({active: !this.state.active}, () => {`
`108`	`108`	`if (this.state.active) {`
`109`	`109`	`this.links[0].focus();`
Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@ export default ({`
`9`	`9`	// mimick the `NavLink` API
`10`	`10`	`if ( url ) to = url;`
`11`	`11`
	`12`	`+ // eslint-disable-next-line`
`12`	`13`	`const {isActive, ...others} = props;`
`13`	`14`	`if ( to.startsWith('http') \|\| to.startsWith('//') )`
`14`	`15`	`{`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ class MessageBar extends Component {`
`46`	`46`	`*`
`47`	`47`	`* @param {object} e - Click event`
`48`	`48`	`*/`
`49`		`- close(e) {`
	`49`	`+ close() {`
`50`	`50`	`localStorage.setItem('notification-dismissed', version);`
`51`	`51`	`this.props.onClose();`
`52`	`52`	`}`
Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ class Page extends Component {`
`61`	`61`
`62`	`62`	`})`
`63`	`63`	`)`
`64`		`- .catch(error =>`
	`64`	`+ .catch(() =>`
`65`	`65`	`this.setState({`
`66`	`66`	`content: 'Error loading content.'`
`67`	`67`	`})`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ function getDirectoryRecursive(basePath) {`
`33`	`33`	`if (fs.statSync(fullPath).isDirectory()) {`
`34`	`34`	`getDirectoryRecursive(fullPath);`
`35`	`35`	`} else if (fullPath.endsWith('.md') \|\| fullPath.endsWith('.mdx')) {`
`36`		`- let fc = fileContents[fileContents.length] = front(fs.readFileSync(fullPath).toString());`
	`36`	`+ fileContents[fileContents.length] = front(fs.readFileSync(fullPath).toString());`
`37`	`37`	`}`
`38`	`38`	`}`
`39`	`39`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ const enhance = (tree, options) => {`
`62`	`62`	`}`
`63`	`63`	`};`
`64`	`64`
`65`		`-const filter = item => true;`
	`65`	`+const filter = () => true;`
`66`	`66`
`67`	`67`	`const sort = (a, b) => {`
`68`	`68`	`let group1 = (a.group \|\| '').toLowerCase();`