refactor: rename WEBPACK_DEV_SERVER env variable to WEBPACK_SERVE (#3000)

BRAKING CHANGE: the `WEBPACK_DEV_SERVER` env variable was renamed to `WEBPACK_SERVE`

Author: snitin315

.github/workflows/nodejs.yml

@@ -84,7 +84,10 @@ jobs:
         with:
           # npm cache files are stored in `~/.npm` on Linux/macOS
           path: ~/.npm
-          key: ${{ runner.OS }}-${{ matrix.node-version }}-${{ hashFiles('**/package-lock.json') }}
+          key: ${{ runner.OS }}-${{ matrix.node-version }}-${{ matrix.webpack-version }}-${{ hashFiles('**/package-lock.json') }}
+          restore-keys: |
+            ${{ runner.OS }}-${{ matrix.node-version }}-${{ matrix.webpack-version }}-
+            ${{ runner.OS }}-
 
       - name: Install dependencies
         if: steps.cache.outputs.cache-hit != 'true'

lib/Server.js

@@ -34,8 +34,8 @@ const setupExitSignals = require('./utils/setupExitSignals');
 const findPort = require('./utils/findPort');
 const schema = require('./options.json');
 
-if (!process.env.WEBPACK_DEV_SERVER) {
-  process.env.WEBPACK_DEV_SERVER = true;
+if (!process.env.WEBPACK_SERVE) {
+  process.env.WEBPACK_SERVE = true;
 }
 
 class Server {

test/server/Server.test.js

@@ -164,7 +164,7 @@ describe('Server', () => {
     });
   });
 
-  describe('WEBPACK_DEV_SERVER environment variable', () => {
+  describe('WEBPACK_SERVE environment variable', () => {
     const OLD_ENV = process.env;
 
     beforeEach(() => {
@@ -173,19 +173,19 @@ describe('Server', () => {
 
       process.env = { ...OLD_ENV };
 
-      delete process.env.WEBPACK_DEV_SERVER;
+      delete process.env.WEBPACK_SERVE;
     });
 
     afterEach(() => {
       process.env = OLD_ENV;
     });
 
     it('should be present', () => {
-      expect(process.env.WEBPACK_DEV_SERVER).toBeUndefined();
+      expect(process.env.WEBPACK_SERVE).toBeUndefined();
 
       require('../../lib/Server');
 
-      expect(process.env.WEBPACK_DEV_SERVER).toBe(true);
+      expect(process.env.WEBPACK_SERVE).toBe(true);
     });
   });
 });