Tests

Author: drudrum

src/options.json

@@ -50,11 +50,7 @@
     },
     "historyApiFallback": {
       "description": "When using the HTML5 History API, the index.html page will likely have to be served in place of any 404 responses. Enable historyApiFallback by setting it to true",
-      "anyOf": [
-        {
-          "type": "boolean"
-        }
-      ]
+      "type": "boolean"
     },
     "stats": {
       "description": "Stats options object or preset name.",

src/utils/getFilenameFromUrl.js

@@ -53,7 +53,10 @@ export default function getFilenameFromUrl(context, url) {
         filename = path.join(outputPath, querystring.unescape(pathname));
       }
 
-      if (!context.outputFileSystem.existsSync(filename) && options.historyApiFallback){
+      if (
+        !context.outputFileSystem.existsSync(filename) &&
+        options.historyApiFallback
+      ) {
         filename = path.join(outputPath);
       }
 

test/middleware.test.js

@@ -2566,6 +2566,27 @@ describe.each([
       });
     });
 
+    describe("historyApiFallback option", () => {
+      describe("index.html page will likely have to be served in place of any 404 responses", () => {
+        beforeAll((done) => {
+          const compiler = getCompiler(webpackConfig);
+
+          instance = middleware(compiler, { historyApiFallback: true });
+
+          app = framework();
+          app.use(instance);
+
+          listen = listenShorthand(done);
+        });
+
+        afterAll(close);
+
+        it('should return the "200" code for the "GET" request', (done) => {
+          request(app).get("/foo/bar/baz").expect(200, done);
+        });
+      });
+    });
+
     describe("serverSideRender option", () => {
       let locals;
 

test/validation-options.test.js

@@ -35,6 +35,10 @@ describe("validation", () => {
       success: ["/foo", "", "auto", () => "/public/path"],
       failure: [false],
     },
+    historyApiFallback: {
+      success: [true],
+      failure: [],
+    },
     serverSideRender: {
       success: [true],
       failure: ["foo", 0],