chore: update README, default options, breaking changes

Author: laverdet

CHANGELOG.md

@@ -2,6 +2,13 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### **7.0.0**
+
+### ⚠ BREAKING CHANGES
+
+* minimum supported `Node.js` version is `16.0.0`
+* default value of `exportLocalsConvention` is now `"asIs"`, even when the `namedExport` option is set
+
 ### [6.8.1](https://github.com/webpack-contrib/css-loader/compare/v6.8.0...v6.8.1) (2023-05-28)
 
 
@@ -150,7 +157,7 @@ All notable changes to this project will be documented in this file. See [standa
 * `new URL()` syntax used for `url()`, only when the `esModules` option is enabled (enabled by default), it means you can bundle CSS for libraries
 * [data URI](https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/Data_URIs) are handling in `url()`, it means you can register loaders for them, [example](https://webpack.js.org/configuration/module/#rulescheme)
 * aliases with `false` value for `url()` now generate empty data URI (i.e. `data:0,`), only when the `esModules` option is enabled (enabled by default)
-* `[ext]` placeholder don't need `.` (dot) before for the `localIdentName` option, i.e. please change `.[ext]` on `[ext]` (no dot before) 
+* `[ext]` placeholder don't need `.` (dot) before for the `localIdentName` option, i.e. please change `.[ext]` on `[ext]` (no dot before)
 * `[folder]` placeholder was removed without replacement for the `localIdentName` option, please use a custom function if you need complex logic
 * `[emoji]` placeholder was removed without replacement for the `localIdentName` option, please use a custom function if you need complex logic
 * the `localIdentHashPrefix` was removed in favor the `localIdentHashSalt` option
@@ -169,7 +176,7 @@ All notable changes to this project will be documented in this file. See [standa
 
 ### Notes
 
-* **we strongly recommend not to add `.css` to `resolve.extensions`, it reduces performance and in most cases it is simply not necessary, alternative you can set resolve options [by dependency](https://webpack.js.org/configuration/resolve/#resolvebydependency)**   
+* **we strongly recommend not to add `.css` to `resolve.extensions`, it reduces performance and in most cases it is simply not necessary, alternative you can set resolve options [by dependency](https://webpack.js.org/configuration/resolve/#resolvebydependency)**
 
 ### [5.2.7](https://github.com/webpack-contrib/css-loader/compare/v5.2.6...v5.2.7) (2021-07-13)
 

README.md

@@ -1117,17 +1117,6 @@ Default: `false`
 
 Enables/disables ES modules named export for locals.
 
-> **Warning**
->
-> Names of locals are converted to camelcase, i.e. the `exportLocalsConvention` option has
-> `camelCaseOnly` value by default. You can set this back to any other valid option but selectors
-> which are not valid JavaScript identifiers may run into problems which do not implement the entire
-> modules specification.
-
-> **Warning**
->
-> It is not allowed to use JavaScript reserved words in css class names.
-
 **styles.css**
 
 ```css
@@ -1142,7 +1131,7 @@ Enables/disables ES modules named export for locals.
 **index.js**
 
 ```js
-import { fooBaz, bar } from "./styles.css";
+import { "foo-baz" as fooBaz, bar } from "./styles.css";
 
 console.log(fooBaz, bar);
 ```
@@ -1219,18 +1208,14 @@ type exportLocalsConvention =
   | ((name: string) => string);
 ```
 
-Default: based on the `modules.namedExport` option value, if `true` - `camelCaseOnly`, otherwise `asIs`
+Default: `asIs`
 
 Style of exported class names.
 
 ###### `string`
 
 By default, the exported JSON keys mirror the class names (i.e `asIs` value).
 
-> **Warning**
->
-> Only `camelCaseOnly` value allowed if you set the `namedExport` value to `true`.
-
 |         Name          |   Type   | Description                                                                                      |
 | :-------------------: | :------: | :----------------------------------------------------------------------------------------------- |
 |     **`'asIs'`**      | `string` | Class names will be exported as is.                                                              |

package.json

@@ -1,6 +1,6 @@
 {
   "name": "css-loader",
-  "version": "6.8.1",
+  "version": "7.0.0-pre",
   "description": "css loader module for webpack",
   "license": "MIT",
   "repository": "webpack-contrib/css-loader",
@@ -13,7 +13,7 @@
   },
   "main": "dist/cjs.js",
   "engines": {
-    "node": ">= 12.13.0"
+    "node": ">= 16.0.0"
   },
   "scripts": {
     "start": "npm run build -- -w",

src/utils.js

@@ -587,11 +587,7 @@ function getModulesOptions(rawOptions, exportType, loaderContext) {
     // eslint-disable-next-line no-undefined
     getLocalIdent: undefined,
     namedExport: needNamedExport || false,
-    exportLocalsConvention:
-      (rawModulesOptions.namedExport === true || needNamedExport) &&
-      typeof rawModulesOptions.exportLocalsConvention === "undefined"
-        ? "camelCaseOnly"
-        : "asIs",
+    exportLocalsConvention: "asIs",
     exportOnlyLocals: false,
     ...rawModulesOptions,
   };

test/exportType.test.js

@@ -72,7 +72,9 @@ describe("'exportType' option", () => {
   it("should work with 'string' value and CSS modules", async () => {
     const compiler = getCompiler("./basic-string-css-modules.js", {
       exportType: "string",
-      modules: true,
+      modules: {
+        exportLocalsConvention: "camelCaseOnly",
+      },
     });
     const stats = await compile(compiler);
 
@@ -185,7 +187,9 @@ describe("'exportType' option", () => {
       "./modules/composes/composes-css-style-sheet.js",
       {
         exportType: "css-style-sheet",
-        modules: true,
+        modules: {
+          exportLocalsConvention: "camelCaseOnly",
+        },
       }
     );
     const stats = await compile(compiler);
@@ -206,6 +210,7 @@ describe("'exportType' option", () => {
       {
         exportType: "css-style-sheet",
         modules: {
+          exportLocalsConvention: "camelCaseOnly",
           exportOnlyLocals: true,
         },
       }

test/modules-option.test.js

@@ -1565,6 +1565,7 @@ describe('"modules" option', () => {
   it('should work with the "namedExport" option', async () => {
     const compiler = getCompiler("./modules/namedExport/base/index.js", {
       modules: {
+        exportLocalsConvention: "camelCaseOnly",
         namedExport: true,
       },
     });
@@ -1604,6 +1605,7 @@ describe('"modules" option', () => {
     const compiler = getCompiler("./modules/namedExport/nested/index.js", {
       esModule: true,
       modules: {
+        exportLocalsConvention: "camelCaseOnly",
         namedExport: true,
       },
     });
@@ -1623,6 +1625,7 @@ describe('"modules" option', () => {
     const compiler = getCompiler("./modules/namedExport/template/index.js", {
       esModule: true,
       modules: {
+        exportLocalsConvention: "camelCaseOnly",
         localIdentName: "[local]",
         namedExport: true,
       },
@@ -1820,6 +1823,7 @@ describe('"modules" option', () => {
         mode: "local",
         localIdentName: "_[local]",
         namedExport: true,
+        exportLocalsConvention: "camelCaseOnly",
         exportOnlyLocals: true,
       },
       esModule: true,
@@ -1839,6 +1843,7 @@ describe('"modules" option', () => {
   it('should work with "url" and "namedExport"', async () => {
     const compiler = getCompiler("./modules/url/source.js", {
       modules: {
+        exportLocalsConvention: "camelCaseOnly",
         namedExport: true,
       },
     });
@@ -1859,6 +1864,7 @@ describe('"modules" option', () => {
       "./modules/url/source.js",
       {
         modules: {
+          exportLocalsConvention: "camelCaseOnly",
           namedExport: true,
         },
       },
@@ -2035,6 +2041,7 @@ describe('"modules" option', () => {
         modules: {
           mode: "icss",
           namedExport: true,
+          exportLocalsConvention: "camelCaseOnly",
         },
       }
     );