Skip to content

Commit 8120b78

Browse files
iluuu1994charmitro
authored andcommitted
Hide xfail/xleak test summary
We don't show succeeding tests in the summary, and for all intents and purposes, these tests have succeeded, in that they behave as expected. I've seen the output confuse people on multiple occasions, for example phpGH-17105. Closes phpGH-17109
1 parent 481f511 commit 8120b78

File tree

1 file changed

+0
-25
lines changed

1 file changed

+0
-25
lines changed

run-tests.php

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -3271,18 +3271,6 @@ function get_summary(bool $show_ext_summary): string
32713271
$failed_test_summary .= "=====================================================================\n";
32723272
}
32733273

3274-
if (count($PHP_FAILED_TESTS['XFAILED'])) {
3275-
$failed_test_summary .= '
3276-
=====================================================================
3277-
EXPECTED FAILED TEST SUMMARY
3278-
---------------------------------------------------------------------
3279-
';
3280-
foreach ($PHP_FAILED_TESTS['XFAILED'] as $failed_test_data) {
3281-
$failed_test_summary .= $failed_test_data['test_name'] . $failed_test_data['info'] . "\n";
3282-
}
3283-
$failed_test_summary .= "=====================================================================\n";
3284-
}
3285-
32863274
if (count($PHP_FAILED_TESTS['BORKED'])) {
32873275
$failed_test_summary .= '
32883276
=====================================================================
@@ -3333,19 +3321,6 @@ function get_summary(bool $show_ext_summary): string
33333321
$failed_test_summary .= "=====================================================================\n";
33343322
}
33353323

3336-
if (count($PHP_FAILED_TESTS['XLEAKED'])) {
3337-
$failed_test_summary .= '
3338-
=====================================================================
3339-
EXPECTED LEAK TEST SUMMARY
3340-
---------------------------------------------------------------------
3341-
';
3342-
foreach ($PHP_FAILED_TESTS['XLEAKED'] as $failed_test_data) {
3343-
$failed_test_summary .= $failed_test_data['test_name'] . $failed_test_data['info'] . "\n";
3344-
}
3345-
3346-
$failed_test_summary .= "=====================================================================\n";
3347-
}
3348-
33493324
if ($failed_test_summary && !getenv('NO_PHPTEST_SUMMARY')) {
33503325
$summary .= $failed_test_summary;
33513326
}

0 commit comments

Comments
 (0)