fix($core): Set production mode before creating VuePress app on build mode

kefranabg · kefranabg · commit c932991ddb12 · 2019-10-23T12:05:28.000+02:00
diff --git a/packages/@vuepress/core/lib/index.js b/packages/@vuepress/core/lib/index.js
@@ -16,6 +16,7 @@ async function dev (options) {
 }
 
 async function build (options) {
+  process.env.NODE_ENV = 'production'
   const app = createApp(options)
   await app.process()
   return app.build()
diff --git a/packages/@vuepress/core/lib/node/build/index.js b/packages/@vuepress/core/lib/node/build/index.js
@@ -18,7 +18,6 @@ const { normalizeHeadTag, applyUserWebpackConfig } = require('../util/index')
 module.exports = class Build extends EventEmitter {
   constructor (context) {
     super()
-    process.env.NODE_ENV = 'production'
     this.context = context
     this.outDir = this.context.outDir
   }

Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,7 @@ async function dev (options) {`
`16`	`16`	`}`
`17`	`17`
`18`	`18`	`async function build (options) {`
	`19`	`+ process.env.NODE_ENV = 'production'`
`19`	`20`	`const app = createApp(options)`
`20`	`21`	`await app.process()`
`21`	`22`	`return app.build()`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,6 @@ const { normalizeHeadTag, applyUserWebpackConfig } = require('../util/index')`
`18`	`18`	`module.exports = class Build extends EventEmitter {`
`19`	`19`	`constructor (context) {`
`20`	`20`	`super()`
`21`		`- process.env.NODE_ENV = 'production'`
`22`	`21`	`this.context = context`
`23`	`22`	`this.outDir = this.context.outDir`
`24`	`23`	`}`