refactor: refactor options.intercept route to remove reference to globals

Author: eddyerburgh

src/lib/add-globals.js

@@ -2,7 +2,7 @@
 
 import Vue from 'vue'
 import addSlots from './add-slots'
-import addGlobals from './add-globals'
+import createInterceptPlugin from './create-intercept-plugin'
 import addProvide from './add-provide'
 import { stubComponents } from './stub-components'
 import { throwError } from './util'
@@ -38,8 +38,10 @@ export default function createConstructor (component: Component, options: Option
   const Constructor = vue.extend(component)
 
   if (options.intercept) {
-    const globals = addGlobals(options.intercept)
-    Constructor.use(globals)
+    // creates a plugin that adds properties, and then install on local Constructor
+    // this does not affect the base Vue class
+    const interceptPlugin = createInterceptPlugin(options.intercept)
+    Constructor.use(interceptPlugin)
   }
 
   const vm = new Constructor(options)

src/lib/create-instance.js

@@ -0,0 +1,11 @@
+// @flow
+
+export default function createInterceptPlugin (interceptedProperties: Object) {
+  return {
+    install: function (Vue: Object) {
+      Object.keys(interceptedProperties).forEach((key) => {
+        Vue.prototype[key] = interceptedProperties[key]
+      })
+    }
+  }
+}

src/lib/create-intercept-plugin.js

@@ -2,7 +2,7 @@ import mount from '~src/mount'
 import Component from '~resources/components/component.vue'
 
 describe('mount.intercept', () => {
-  it('injects global variables when passed as intercept object', () => {
+  it('adds variables to vm when passed as intercept object', () => {
     const $store = { store: true }
     const $route = { path: 'http://test.com' }
     const wrapper = mount(Component, {
@@ -14,4 +14,16 @@ describe('mount.intercept', () => {
     expect(wrapper.vm.$store).to.equal($store)
     expect(wrapper.vm.$route).to.equal($route)
   })
+
+  it('does not affect global vue class when passed as intercept object', () => {
+    const $store = { store: true }
+    const wrapper = mount(Component, {
+      intercept: {
+        $store
+      }
+    })
+    expect(wrapper.vm.$store).to.equal($store)
+    const freshWrapper = mount(Component)
+    expect(typeof freshWrapper.vm.$store).to.equal('undefined')
+  })
 })