From 826f4497122476f813b49d95b4f2d41bfda0b42b Mon Sep 17 00:00:00 2001 From: yosuke ota Date: Sun, 15 Aug 2021 04:30:05 +0900 Subject: [PATCH 1/2] Chores: Add engines compatibility check --- .eslintrc.yml | 5 +++++ .vscode/settings.json | 10 +++++++++- package.json | 4 +++- tsconfig.json | 8 ++------ 4 files changed, 19 insertions(+), 8 deletions(-) diff --git a/.eslintrc.yml b/.eslintrc.yml index 6119e624..5d54ddb2 100644 --- a/.eslintrc.yml +++ b/.eslintrc.yml @@ -1,6 +1,8 @@ extends: - plugin:@mysticatea/es2015 - plugin:@mysticatea/+node + - plugin:node-dependencies/recommended + - plugin:jsonc/recommended-with-jsonc globals: { root: "off" } @@ -19,6 +21,9 @@ overrides: - error - allowModules: - estree + - files: "package.json" + rules: + '@mysticatea/prettier': off settings: node: diff --git a/.vscode/settings.json b/.vscode/settings.json index 72446f43..6b4cd2be 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -1,3 +1,11 @@ { - "typescript.tsdk": "node_modules/typescript/lib" + "typescript.tsdk": "node_modules/typescript/lib", + "eslint.validate": [ + "javascript", + "javascriptreact", + "typescript", + "typescriptreact", + "json", + "jsonc" + ], } diff --git a/package.json b/package.json index 81be9300..5197b8e0 100644 --- a/package.json +++ b/package.json @@ -38,6 +38,8 @@ "cross-spawn": "^6.0.5", "dts-bundle": "^0.7.3", "eslint": "^7.0.0", + "eslint-plugin-jsonc": "^1.4.0", + "eslint-plugin-node-dependencies": "^0.5.0", "fs-extra": "^7.0.1", "jsonc-eslint-parser": "^0.6.0", "mocha": "^6.1.4", @@ -60,7 +62,7 @@ "clean": "rimraf .nyc_output .temp coverage index.*", "codecov": "codecov", "coverage": "opener ./coverage/lcov-report/index.html", - "lint": "eslint src test --ext .js,.ts", + "lint": "eslint src test package.json --ext .js,.ts", "setup": "git submodule update --init && cd test/fixtures/eslint && npm install", "pretest": "run-s build lint", "test": "npm run -s test:mocha", diff --git a/tsconfig.json b/tsconfig.json index 69ed4035..189d89e2 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -12,9 +12,7 @@ "esModuleInterop": true, "forceConsistentCasingInFileNames": true, "inlineSources": true, - "lib": [ - "es2015" - ], + "lib": ["es2015"], "module": "commonjs", "moduleResolution": "node", "newLine": "LF", @@ -37,7 +35,5 @@ "strictNullChecks": true, "target": "es2015" }, - "include": [ - "src/**/*.ts" - ] + "include": ["src/**/*.ts"] } From 1efe1e5154a4dc0adc56cd11ff69f5ec1bb1eb15 Mon Sep 17 00:00:00 2001 From: yosuke ota Date: Sun, 15 Aug 2021 04:33:41 +0900 Subject: [PATCH 2/2] Revert --- .vscode/settings.json | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/.vscode/settings.json b/.vscode/settings.json index 6b4cd2be..72446f43 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -1,11 +1,3 @@ { - "typescript.tsdk": "node_modules/typescript/lib", - "eslint.validate": [ - "javascript", - "javascriptreact", - "typescript", - "typescriptreact", - "json", - "jsonc" - ], + "typescript.tsdk": "node_modules/typescript/lib" }