From fc0aa865f37474e3fc94b81c5cf16c7da3b12e2b Mon Sep 17 00:00:00 2001 From: Muzafar Umarov Date: Sat, 3 Mar 2018 20:36:17 -0500 Subject: [PATCH] fix(cli-plugin-pwa): Set cacheid in GenerateSW mode only --- packages/@vue/cli-plugin-pwa/index.js | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/packages/@vue/cli-plugin-pwa/index.js b/packages/@vue/cli-plugin-pwa/index.js index bde560d26f..6f76d4004b 100644 --- a/packages/@vue/cli-plugin-pwa/index.js +++ b/packages/@vue/cli-plugin-pwa/index.js @@ -24,15 +24,20 @@ module.exports = (api, options) => { ) } - const workBoxConfig = Object.assign({ - cacheId: name, + const defaultOptions = { exclude: [ /\.map$/, /img\/icons\//, /favicon\.ico$/, /manifest\.json$/ ] - }, userOptions.workboxOptions) + } + + const defaultGenerateSWOptions = workboxPluginMode === 'GenerateSW' ? { + cacheId: name + } : {} + + const workBoxConfig = Object.assign(defaultOptions, defaultGenerateSWOptions, userOptions.workboxOptions) webpackConfig .plugin('workbox')