From 85e84721f9605630a73cd763ebde00b52b55eb39 Mon Sep 17 00:00:00 2001 From: Haoqun Jiang Date: Mon, 22 Jun 2020 15:17:43 +0800 Subject: [PATCH] fix(nightwatch): compat with legacy presets without `webdrivers` field --- packages/@vue/cli-plugin-e2e-nightwatch/generator/index.js | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/packages/@vue/cli-plugin-e2e-nightwatch/generator/index.js b/packages/@vue/cli-plugin-e2e-nightwatch/generator/index.js index 3ead67a59b..c0120e9db8 100644 --- a/packages/@vue/cli-plugin-e2e-nightwatch/generator/index.js +++ b/packages/@vue/cli-plugin-e2e-nightwatch/generator/index.js @@ -11,6 +11,13 @@ module.exports = (api, { webdrivers }) => { // Use devDependencies to store latest version number so as to automate update const pluginDeps = require('../package.json').devDependencies + // In some legacy presets, they may forget to add a `webdrivers` field + // (which works fine before PR #5528). + // So we should add both drivers by default in that circumstance. + if (typeof webdrivers === 'undefined') { + webdrivers = ['firefox', 'chrome'] + } + if (webdrivers && webdrivers.includes('firefox')) { devDependencies.geckodriver = pluginDeps.geckodriver }