From 10dd08ae17a3844f653aa7058d67b97f18cc6408 Mon Sep 17 00:00:00 2001 From: Roman Seidelsohn Date: Thu, 7 Nov 2019 14:36:46 +0100 Subject: [PATCH 1/2] fix(lib): replace "url" module with simple string split (close #4667) Fixes issue #4667 by implementing the proposal https://github.com/vuejs/vue-cli/issues/4667#issuecomment-548464520 Also gets rid of a node module by using simpler code for removing eventual GET parameters --- packages/@vue/cli-service/lib/commands/build/formatStats.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/@vue/cli-service/lib/commands/build/formatStats.js b/packages/@vue/cli-service/lib/commands/build/formatStats.js index dec529c1ef..22f9872e88 100644 --- a/packages/@vue/cli-service/lib/commands/build/formatStats.js +++ b/packages/@vue/cli-service/lib/commands/build/formatStats.js @@ -4,7 +4,6 @@ module.exports = function formatStats (stats, dir, api) { const zlib = require('zlib') const chalk = require('chalk') const ui = require('cliui')({ width: 80 }) - const url = require('url') const json = stats.toJson({ hash: false, @@ -22,7 +21,7 @@ module.exports = function formatStats (stats, dir, api) { const isMinJS = val => /\.min\.js$/.test(val) assets = assets .map(a => { - a.name = url.parse(a.name).pathname + a.name = a.name.split(`?`)[0] return a }) .filter(a => { From 7ed67ed97efd8682d255960025ad1b725d73e274 Mon Sep 17 00:00:00 2001 From: Roman Seidelsohn Date: Fri, 8 Nov 2019 07:48:46 +0100 Subject: [PATCH 2/2] Update packages/@vue/cli-service/lib/commands/build/formatStats.js Co-Authored-By: Haoqun Jiang --- packages/@vue/cli-service/lib/commands/build/formatStats.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/@vue/cli-service/lib/commands/build/formatStats.js b/packages/@vue/cli-service/lib/commands/build/formatStats.js index 22f9872e88..f683e214c8 100644 --- a/packages/@vue/cli-service/lib/commands/build/formatStats.js +++ b/packages/@vue/cli-service/lib/commands/build/formatStats.js @@ -21,7 +21,7 @@ module.exports = function formatStats (stats, dir, api) { const isMinJS = val => /\.min\.js$/.test(val) assets = assets .map(a => { - a.name = a.name.split(`?`)[0] + a.name = a.name.split('?')[0] return a }) .filter(a => {