From 480aa653066a5be39efc5884aed780a2c7bb9bce Mon Sep 17 00:00:00 2001 From: Haoqun Jiang Date: Wed, 22 Aug 2018 22:29:29 +0800 Subject: [PATCH 1/2] Revert "fix: avoid hash collisions (#1959)" This reverts commit 4b5a63441b385d5d7f9b92cf5ed4d61d4eae39c9. --- packages/@vue/cli-service/lib/config/app.js | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/@vue/cli-service/lib/config/app.js b/packages/@vue/cli-service/lib/config/app.js index 6b14fcc7f1..cb567a13ca 100644 --- a/packages/@vue/cli-service/lib/config/app.js +++ b/packages/@vue/cli-service/lib/config/app.js @@ -133,7 +133,6 @@ module.exports = (api, options) => { const joinedHash = hash(modules.map(m => m.id).join('_')) let len = nameLength while (seen.has(joinedHash.substr(0, len))) len++ - seen.add(joinedHash.substr(0, len)) return `chunk-${joinedHash.substr(0, len)}` } else { return modules[0].id From a2d356e94620854af43fce62173eb1e113d03490 Mon Sep 17 00:00:00 2001 From: Haoqun Jiang Date: Wed, 22 Aug 2018 22:29:40 +0800 Subject: [PATCH 2/2] Revert "refactor: improve chunk name aesthetics" This reverts commit 625d541715e232140e53814fd914090f6f5b5041. --- packages/@vue/cli-service/lib/config/app.js | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/packages/@vue/cli-service/lib/config/app.js b/packages/@vue/cli-service/lib/config/app.js index cb567a13ca..5497ea6e38 100644 --- a/packages/@vue/cli-service/lib/config/app.js +++ b/packages/@vue/cli-service/lib/config/app.js @@ -119,24 +119,15 @@ module.exports = (api, options) => { }) // keep chunk ids stable so async chunks have consistent hash (#1916) - const seen = new Set() - const nameLength = 4 webpackConfig .plugin('named-chunks') .use(require('webpack/lib/NamedChunksPlugin'), [chunk => { if (chunk.name) { return chunk.name } - const modules = Array.from(chunk.modulesIterable) - if (modules.length > 1) { - const hash = require('hash-sum') - const joinedHash = hash(modules.map(m => m.id).join('_')) - let len = nameLength - while (seen.has(joinedHash.substr(0, len))) len++ - return `chunk-${joinedHash.substr(0, len)}` - } else { - return modules[0].id - } + return `chunk-` + Array.from(chunk.modulesIterable, m => { + return m.id + }).join('_') }]) }