Skip to content

Commit f4aa40d

Browse files
author
Guillaume Chau
committed
fix(pwa): wrong config, closes #1890
1 parent a352bdc commit f4aa40d

File tree

2 files changed

+3
-6
lines changed
  • packages/@vue

2 files changed

+3
-6
lines changed

packages/@vue/cli-plugin-eslint/ui.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,6 @@ module.exports = api => {
246246
label: 'org.vue.eslint.suggestions.open-eslintrc.label',
247247
handler () {
248248
const file = config.foundFiles.eslint.path
249-
console.log('open', file)
250249
const launch = require('launch-editor')
251250
launch(file)
252251
return {

packages/@vue/cli-plugin-pwa/ui.js

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -83,21 +83,21 @@ module.exports = api => {
8383
onWrite: async ({ api, prompts, cwd }) => {
8484
const result = {}
8585
for (const prompt of prompts.filter(p => !p.raw.skipSave)) {
86-
result[`org.vue.pwa.${prompt.id}`] = await api.getAnswer(prompt.id)
86+
result[`pwa.${prompt.id}`] = await api.getAnswer(prompt.id)
8787
}
8888
api.setData('vue', result)
8989

9090
// Update app manifest
9191

92-
const name = result['org.vue.pwa.name']
92+
const name = result['name']
9393
if (name) {
9494
api.setData('manifest', {
9595
name,
9696
short_name: name
9797
})
9898
}
9999

100-
const themeColor = result['org.vue.pwa.themeColor']
100+
const themeColor = result['themeColor']
101101
if (themeColor) {
102102
api.setData('manifest', {
103103
theme_color: themeColor
@@ -131,7 +131,6 @@ module.exports = api => {
131131
label: 'org.vue.pwa.suggestions.open-vue.label',
132132
handler () {
133133
const file = config.foundFiles.vue.path
134-
console.log('open', file)
135134
const launch = require('launch-editor')
136135
launch(file)
137136
return {
@@ -149,7 +148,6 @@ module.exports = api => {
149148
label: 'org.vue.pwa.suggestions.open-manifest.label',
150149
handler () {
151150
const file = config.foundFiles.manifest.path
152-
console.log('open', file)
153151
const launch = require('launch-editor')
154152
launch(file)
155153
return {

0 commit comments

Comments
 (0)