Skip to content

Commit c889073

Browse files
authored
chore: improve error message when get metadata failed (#5604)
1 parent b66bc8c commit c889073

File tree

3 files changed

+10
-0
lines changed

3 files changed

+10
-0
lines changed

packages/@vue/cli-shared-utils/lib/logger.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ const stripAnsi = require('strip-ansi')
33
const readline = require('readline')
44
const EventEmitter = require('events')
55

6+
const { stopSpinner } = require('./spinner')
7+
68
exports.events = new EventEmitter()
79

810
function _log (type, tag, message) {
@@ -46,6 +48,7 @@ exports.warn = (msg, tag = null) => {
4648
}
4749

4850
exports.error = (msg, tag = null) => {
51+
stopSpinner()
4952
console.error(format(chalk.bgRed(' ERROR ') + (tag ? chalkTag(tag) : ''), chalk.red(msg)))
5053
_log('error', tag, msg)
5154
if (msg instanceof Error) {

packages/@vue/cli-shared-utils/lib/spinner.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,10 @@ exports.logWithSpinner = (symbol, msg) => {
2525
}
2626

2727
exports.stopSpinner = (persist) => {
28+
if (!spinner.isSpinning) {
29+
return
30+
}
31+
2832
if (lastMsg && persist !== false) {
2933
spinner.stopAndPersist({
3034
symbol: lastMsg.symbol,

packages/@vue/cli/lib/util/ProjectPackageManager.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -258,6 +258,9 @@ class PackageManager {
258258
const url = `${registry.replace(/\/$/g, '')}/${packageName}`
259259
try {
260260
metadata = (await request.get(url, { headers })).body
261+
if (metadata.error) {
262+
throw new Error(metadata.error)
263+
}
261264
metadataCache.set(metadataKey, metadata)
262265
return metadata
263266
} catch (e) {

0 commit comments

Comments
 (0)