refactor: use the title option in the html template, instead… (#5060)

haoqunjiang · pksunkara · commit bc3e4af3c053 · 2020-01-13T19:34:41.000+05:30
closes #5056
diff --git a/packages/@vue/cli-service/generator/template/public/index.html b/packages/@vue/cli-service/generator/template/public/index.html
@@ -5,11 +5,11 @@
     <meta http-equiv="X-UA-Compatible" content="IE=edge">
     <meta name="viewport" content="width=device-width,initial-scale=1.0">
     <link rel="icon" href="<%%= BASE_URL %%>favicon.ico">
-    <title><%= rootOptions.projectName %></title>
+    <title><%%= htmlWebpackPlugin.options.title %%></title>
   </head>
   <body>
     <noscript>
-      <strong>We're sorry but <%= rootOptions.projectName %> doesn't work properly without JavaScript enabled. Please enable it to continue.</strong>
+      <strong>We're sorry but <%%= htmlWebpackPlugin.options.title %%> doesn't work properly without JavaScript enabled. Please enable it to continue.</strong>
     </noscript>
     <div id="app"></div>
     <!-- built files will be auto injected -->
diff --git a/packages/@vue/cli-service/lib/config/app.js b/packages/@vue/cli-service/lib/config/app.js
@@ -84,6 +84,7 @@ module.exports = (api, options) => {
     }
 
     const htmlOptions = {
+      title: api.service.pkg.name,
       templateParameters: (compilation, assets, pluginOptions) => {
         // enhance html-webpack-plugin's built in template params
         let stats

Original file line number	Diff line number	Diff line change
`@@ -84,6 +84,7 @@ module.exports = (api, options) => {`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`const htmlOptions = {`
	`87`	`+ title: api.service.pkg.name,`
`87`	`88`	`templateParameters: (compilation, assets, pluginOptions) => {`
`88`	`89`	`// enhance html-webpack-plugin's built in template params`
`89`	`90`	`let stats`