chore: remove tslint specific code

Author: Christopher Quadflieg

packages/@vue/cli-plugin-e2e-cypress/__tests__/cypressPlugin.spec.js

@@ -30,7 +30,6 @@ test('should work with TS', async () => {
     plugins: {
       '@vue/cli-plugin-typescript': {
         'classComponent': true,
-        'tsLint': true,
         'lintOn': ['save']
       },
       '@vue/cli-plugin-e2e-cypress': {}

packages/@vue/cli-plugin-typescript/__tests__/tsConvertLintFlags.spec.js

@@ -81,12 +81,11 @@ test('use with router', async () => {
 })
 
 test('lint', async () => {
-  const { pkg, files } = await generateWithPlugin([
+  const { pkg } = await generateWithPlugin([
     {
       id: 'ts',
       apply: require('../generator'),
       options: {
-        tsLint: true,
         lintOn: ['save', 'commit']
       }
     }
@@ -99,8 +98,6 @@ test('lint', async () => {
     '*.ts': ['vue-cli-service lint', 'git add'],
     '*.vue': ['vue-cli-service lint', 'git add']
   })
-
-  expect(files['tslint.json']).toBeTruthy()
 })
 
 test('lint with no lintOnSave', async () => {
@@ -109,7 +106,6 @@ test('lint with no lintOnSave', async () => {
       id: 'ts',
       apply: require('../generator'),
       options: {
-        tsLint: true,
         lintOn: ['commit']
       }
     }

packages/@vue/cli-plugin-typescript/__tests__/tsGenerator.spec.js

@@ -1,37 +1,31 @@
-module.exports = (api, { tsLint = false, convertJsToTs = true } = {}) => {
-  const jsRE = /\.js$/
-  let excludeRE = /^tests\/e2e\/|(\.config|rc)\.js$/
+module.exports = (api, { convertJsToTs = true } = {}) => {
+  const jsRE = /\.js$/;
+  let excludeRE = /^tests\/e2e\/|(\.config|rc)\.js$/;
 
-  if (api.hasPlugin('e2e-webdriverio')) {
-    excludeRE = /(\.config|rc)\.js$/
+  if (api.hasPlugin("e2e-webdriverio")) {
+    excludeRE = /(\.config|rc)\.js$/;
   }
-  const convertLintFlags = require('../lib/convertLintFlags')
-  api.postProcessFiles(files => {
+  const convertLintFlags = require("../lib/convertLintFlags");
+  api.postProcessFiles((files) => {
     if (convertJsToTs) {
       // delete all js files that have a ts file of the same name
       // and simply rename other js files to ts
       for (const file in files) {
         if (jsRE.test(file) && !excludeRE.test(file)) {
-          const tsFile = file.replace(jsRE, '.ts')
+          const tsFile = file.replace(jsRE, ".ts");
           if (!files[tsFile]) {
-            let content = files[file]
-            if (tsLint) {
-              content = convertLintFlags(content)
-            }
-            files[tsFile] = content
+            const content = files[file];
+            files[tsFile] = content;
           }
-          delete files[file]
+          delete files[file];
         }
       }
     } else {
       // rename only main file to main.ts
-      const tsFile = api.entryFile.replace(jsRE, '.ts')
-      let content = files[api.entryFile]
-      if (tsLint) {
-        content = convertLintFlags(content)
-      }
-      files[tsFile] = content
-      delete files[api.entryFile]
+      const tsFile = api.entryFile.replace(jsRE, ".ts");
+      const content = files[api.entryFile];
+      files[tsFile] = content;
+      delete files[api.entryFile];
     }
-  })
-}
+  });
+};

packages/@vue/cli-plugin-typescript/__tests__/tsPluginTSLint.spec.js

@@ -1,114 +1,76 @@
-const pluginDevDeps = require('../package.json').devDependencies
+const pluginDevDeps = require("../package.json").devDependencies;
 
-module.exports = (api, {
-  classComponent,
-  tsLint,
-  lintOn = [],
-  skipLibCheck = true,
-  convertJsToTs,
-  allowJs
-}, rootOptions, invoking) => {
-  if (typeof lintOn === 'string') {
-    lintOn = lintOn.split(',')
+module.exports = (
+  api,
+  { classComponent, lintOn = [], skipLibCheck = true, convertJsToTs, allowJs },
+  rootOptions,
+  invoking
+) => {
+  if (typeof lintOn === "string") {
+    lintOn = lintOn.split(",");
   }
-  const isVue3 = rootOptions && rootOptions.vueVersion === '3'
+  const isVue3 = rootOptions && rootOptions.vueVersion === "3";
 
   api.extendPackage({
     devDependencies: {
-      typescript: pluginDevDeps.typescript
-    }
-  })
+      typescript: pluginDevDeps.typescript,
+    },
+  });
 
   if (classComponent) {
     if (isVue3) {
       api.extendPackage({
         dependencies: {
-          'vue-class-component': '^8.0.0-0'
-        }
-      })
+          "vue-class-component": "^8.0.0-0",
+        },
+      });
     } else {
       api.extendPackage({
         dependencies: {
-          'vue-class-component': pluginDevDeps['vue-class-component'],
-          'vue-property-decorator': pluginDevDeps['vue-property-decorator']
-        }
-      })
-    }
-  }
-
-  if (tsLint) {
-    api.extendPackage({
-      scripts: {
-        lint: 'vue-cli-service lint'
-      }
-    })
-
-    if (!lintOn.includes('save')) {
-      api.extendPackage({
-        vue: {
-          lintOnSave: false
-        }
-      })
-    }
-
-    if (lintOn.includes('commit')) {
-      api.extendPackage({
-        devDependencies: {
-          'lint-staged': '^9.5.0'
-        },
-        gitHooks: {
-          'pre-commit': 'lint-staged'
+          "vue-class-component": pluginDevDeps["vue-class-component"],
+          "vue-property-decorator": pluginDevDeps["vue-property-decorator"],
         },
-        'lint-staged': {
-          '*.ts': ['vue-cli-service lint', 'git add'],
-          '*.vue': ['vue-cli-service lint', 'git add']
-        }
-      })
+      });
     }
-
-    // lint and fix files on creation complete
-    api.onCreateComplete(() => {
-      return require('../lib/tslint')({}, api, true)
-    })
   }
 
   // late invoke compat
   if (invoking) {
-    if (api.hasPlugin('unit-mocha')) {
+    if (api.hasPlugin("unit-mocha")) {
       // eslint-disable-next-line node/no-extraneous-require
-      require('@vue/cli-plugin-unit-mocha/generator').applyTS(api)
+      require("@vue/cli-plugin-unit-mocha/generator").applyTS(api);
     }
 
-    if (api.hasPlugin('unit-jest')) {
+    if (api.hasPlugin("unit-jest")) {
       // eslint-disable-next-line node/no-extraneous-require
-      require('@vue/cli-plugin-unit-jest/generator').applyTS(api)
+      require("@vue/cli-plugin-unit-jest/generator").applyTS(api);
     }
 
-    if (api.hasPlugin('eslint')) {
+    if (api.hasPlugin("eslint")) {
       // eslint-disable-next-line node/no-extraneous-require
-      require('@vue/cli-plugin-eslint/generator').applyTS(api)
+      require("@vue/cli-plugin-eslint/generator").applyTS(api);
     }
 
-    if (api.hasPlugin('e2e-webdriverio')) {
+    if (api.hasPlugin("e2e-webdriverio")) {
       // eslint-disable-next-line node/no-extraneous-require
-      require('@vue/cli-plugin-e2e-webdriverio/generator').applyTS(api)
+      require("@vue/cli-plugin-e2e-webdriverio/generator").applyTS(api);
     }
   }
 
-  api.render('./template', {
+  api.render("./template", {
     skipLibCheck,
-    hasMocha: api.hasPlugin('unit-mocha'),
-    hasJest: api.hasPlugin('unit-jest'),
-    hasWebDriverIO: api.hasPlugin('e2e-webdriverio')
-  })
+    hasMocha: api.hasPlugin("unit-mocha"),
+    hasJest: api.hasPlugin("unit-jest"),
+    hasWebDriverIO: api.hasPlugin("e2e-webdriverio"),
+  });
 
   if (isVue3) {
-    api.render('./template-vue3')
+    api.render("./template-vue3");
 
     // In Vue 3, TSX interface is defined in https://github.com/vuejs/vue-next/blob/master/packages/runtime-dom/types/jsx.d.ts
     // So no need to manually add a shim.
-    api.render((files) => delete files['src/shims-tsx.d.ts'])
+    api.render((files) => delete files["src/shims-tsx.d.ts"]);
   }
 
-  require('./convert')(api, { tsLint, convertJsToTs })
-}
+  require("./convert")(api, { tsLint, convertJsToTs });
+};

packages/@vue/cli-plugin-typescript/generator/convert.js

@@ -2,9 +2,7 @@ import Vue, { VNode } from 'vue'
 
 declare global {
   namespace JSX {
-    // tslint:disable no-empty-interface
     interface Element extends VNode {}
-    // tslint:disable no-empty-interface
     interface ElementClass extends Vue {}
     interface IntrinsicElements {
       [elem: string]: any