chore!: upgrade chromedriver to 74 and make it a peer dependency (#3916)

haoqunjiang · web-flow · commit 990f4c231310 · 2019-04-30T10:14:36.000+08:00
diff --git a/packages/@vue/cli-plugin-e2e-nightwatch/generator/index.js b/packages/@vue/cli-plugin-e2e-nightwatch/generator/index.js
@@ -6,6 +6,9 @@ module.exports = api => {
   api.extendPackage({
     scripts: {
       'test:e2e': 'vue-cli-service test:e2e'
+    },
+    devDependencies: {
+      chromedriver: '^74.0.0'
     }
   })
 }
diff --git a/packages/@vue/cli-plugin-e2e-nightwatch/package.json b/packages/@vue/cli-plugin-e2e-nightwatch/package.json
@@ -24,10 +24,15 @@
   },
   "dependencies": {
     "@vue/cli-shared-utils": "^3.6.0",
-    "chromedriver": "^2.46.0",
     "deepmerge": "^3.2.0",
     "execa": "^1.0.0",
     "nightwatch": "^1.0.18",
     "selenium-server": "^3.141.59"
+  },
+  "devDependencies": {
+    "chromedriver": "^74.0.0"
+  },
+  "peerDependencies": {
+    "chromedriver": "*"
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,9 @@ module.exports = api => {`
`6`	`6`	`api.extendPackage({`
`7`	`7`	`scripts: {`
`8`	`8`	`'test:e2e': 'vue-cli-service test:e2e'`
	`9`	`+ },`
	`10`	`+ devDependencies: {`
	`11`	`+ chromedriver: '^74.0.0'`
`9`	`12`	`}`
`10`	`13`	`})`
`11`	`14`	`}`