refactor: extract the utility to detect changed files in git

Author: haoqunjiang

packages/@vue/cli/lib/Upgrader.js

@@ -2,25 +2,22 @@ const fs = require('fs')
 const path = require('path')
 const {
   chalk,
-  execa,
   semver,
 
   log,
   done,
-
   logWithSpinner,
   stopSpinner,
 
   isPlugin,
   resolvePluginId,
-  loadModule,
-
-  hasProjectGit
+  loadModule
 } = require('@vue/cli-shared-utils')
 
 const Migrator = require('./Migrator')
 const tryGetNewerRange = require('./util/tryGetNewerRange')
 const readFiles = require('./util/readFiles')
+const getChangedFiles = require('./util/getChangedFiles')
 
 const getPackageJson = require('./util/getPackageJson')
 const PackageManager = require('./util/ProjectPackageManager')
@@ -155,34 +152,23 @@ module.exports = class Upgrader {
       log()
     }
 
-    log(`${chalk.green('✔')}  Successfully invoked migrator for plugin: ${chalk.cyan(plugin.id)}`)
-    if (!process.env.VUE_CLI_TEST && hasProjectGit(this.context)) {
-      const { stdout } = await execa('git', [
-        'ls-files',
-        '--exclude-standard',
-        '--modified',
-        '--others'
-      ], {
-        cwd: this.context
-      })
-      if (stdout.trim()) {
-        log(`   The following files have been updated / added:\n`)
-        log(
-          chalk.red(
-            stdout
-              .split(/\r?\n/g)
-              .map(line => `     ${line}`)
-              .join('\n')
-          )
-        )
-        log()
-        log(
-          `   You should review these changes with ${chalk.cyan(
-            `git diff`
-          )} and commit them.`
-        )
-        log()
-      }
+    log(
+      `${chalk.green(
+        '✔'
+      )}  Successfully invoked migrator for plugin: ${chalk.cyan(plugin.id)}`
+    )
+
+    const changedFiles = getChangedFiles(this.context)
+    if (changedFiles.length) {
+      log(`   The following files have been updated / added:\n`)
+      log(chalk.red(changedFiles.map(line => `     ${line}`).join('\n')))
+      log()
+      log(
+        `   You should review these changes with ${chalk.cyan(
+          'git diff'
+        )} and commit them.`
+      )
+      log()
     }
 
     migrator.printExitLogs()

packages/@vue/cli/lib/invoke.js

@@ -3,15 +3,12 @@ const path = require('path')
 const inquirer = require('inquirer')
 const {
   chalk,
-  execa,
 
   log,
   error,
   logWithSpinner,
   stopSpinner,
 
-  hasProjectGit,
-
   resolvePluginId,
 
   loadModule
@@ -21,6 +18,7 @@ const Generator = require('./Generator')
 
 const confirmIfGitDirty = require('./util/confirmIfGitDirty')
 const readFiles = require('./util/readFiles')
+const getChangedFiles = require('./util/getChangedFiles')
 const PackageManager = require('./util/ProjectPackageManager')
 
 function getPkg (context) {
@@ -152,33 +150,17 @@ async function runGenerator (context, plugin, pkg = getPkg(context)) {
   }
 
   log(`${chalk.green('✔')}  Successfully invoked generator for plugin: ${chalk.cyan(plugin.id)}`)
-  if (!process.env.VUE_CLI_TEST && hasProjectGit(context)) {
-    const { stdout } = await execa('git', [
-      'ls-files',
-      '--exclude-standard',
-      '--modified',
-      '--others'
-    ], {
-      cwd: context
-    })
-    if (stdout.trim()) {
-      log(`   The following files have been updated / added:\n`)
-      log(
-        chalk.red(
-          stdout
-            .split(/\r?\n/g)
-            .map(line => `     ${line}`)
-            .join('\n')
-        )
-      )
-      log()
-      log(
-        `   You should review these changes with ${chalk.cyan(
-          `git diff`
-        )} and commit them.`
-      )
-      log()
-    }
+  const changedFiles = getChangedFiles(context)
+  if (changedFiles.length) {
+    log(`   The following files have been updated / added:\n`)
+    log(chalk.red(changedFiles.map(line => `     ${line}`).join('\n')))
+    log()
+    log(
+      `   You should review these changes with ${chalk.cyan(
+        'git diff'
+      )} and commit them.`
+    )
+    log()
   }
 
   generator.printExitLogs()

packages/@vue/cli/lib/util/getChangedFiles.js

@@ -0,0 +1,18 @@
+const { execa, hasProjectGit } = require('@vue/cli-shared-utils')
+
+module.exports = async function getChangedFiles (context) {
+  if (!hasProjectGit(context)) return []
+
+  const { stdout } = await execa('git', [
+    'ls-files',
+    '-o',
+    '--exclude-standard',
+    '--full-name'
+  ], {
+    cwd: context
+  })
+  if (stdout.trim()) {
+    return stdout.split(/\r?\n/g)
+  }
+  return []
+}