Skip to content

Commit 96890b5

Browse files
authored
fix: do not install core plugins that have major version bumps (#4720)
* fix: fix version check for core plugins in v4 * fix: fix the error when the diff result is null
1 parent 85c9cbf commit 96890b5

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

packages/@vue/cli/lib/Creator.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,8 +129,13 @@ module.exports = class Creator extends EventEmitter {
129129
const { current, latest } = await getVersions()
130130
let latestMinor = `${semver.major(latest)}.${semver.minor(latest)}.0`
131131

132-
// if using `next` branch of cli
133-
if (semver.gte(current, latest) && semver.prerelease(current)) {
132+
if (
133+
// if the latest version contains breaking changes
134+
/major/.test(semver.diff(current, latest)) ||
135+
// or if using `next` branch of cli
136+
(semver.gte(current, latest) && semver.prerelease(current))
137+
) {
138+
// fallback to the current cli version number
134139
latestMinor = current
135140
}
136141
// generate package.json with plugin dependencies

0 commit comments

Comments
 (0)