fix(cli-plugin-eslint): fix(eslint-config-airbnb): default rules accept mutation of vuex „state“ argument.

close #3954

Author: LinusBorg

packages/@vue/cli-plugin-eslint/eslintOptions.js

@@ -1,4 +1,4 @@
-exports.config = api => {
+exports.config = (api, _config) => {
   const config = {
     root: true,
     env: { node: true },
@@ -8,6 +8,22 @@ exports.config = api => {
       'no-debugger': makeJSOnlyValue(`process.env.NODE_ENV === 'production' ? 'error' : 'off'`)
     }
   }
+  if (_config === 'airbnb') {
+    config.rules['no-param-reassign'] = ['error', {
+      props: true,
+      ignorePropertyModificationsFor: [
+        'state', // for vuex state
+        'acc', // for reduce accumulators
+        'e', // for e.returnvalue
+        'ctx', // for Koa routing
+        'req', // for Express requests
+        'request', // for Express requests
+        'res', // for Express responses
+        'response', // for Express responses
+        '$scope', // for Angular 1 scopes
+      ]
+    }]
+  } 
   if (!api.hasPlugin('typescript')) {
     config.parserOptions = {
       parser: 'babel-eslint'

packages/@vue/cli-plugin-eslint/generator/index.js

@@ -6,7 +6,7 @@ module.exports = (api, { config, lintOn = [] }, _, invoking) => {
     lintOn = lintOn.split(',')
   }
 
-  const eslintConfig = require('../eslintOptions').config(api)
+  const eslintConfig = require('../eslintOptions').config(api, config)
 
   const pkg = {
     scripts: {

packages/@vue/cli/__tests__/invoke.spec.js

@@ -43,7 +43,25 @@ async function assertUpdates (project) {
 
   const eslintrc = parseJS(await project.read('.eslintrc.js'))
   expect(eslintrc).toEqual(Object.assign({}, baseESLintConfig, {
-    extends: ['plugin:vue/essential', '@vue/airbnb']
+    extends: ['plugin:vue/essential', '@vue/airbnb'],
+    rules: {
+      'no-console': 'off',
+      'no-debugger': 'off',
+      'no-param-reassign': ['error', {
+        props: true,
+        ignorePropertyModificationsFor: [
+          'state', // for vuex state
+          'acc', // for reduce accumulators
+          'e', // for e.returnvalue
+          'ctx', // for Koa routing
+          'req', // for Express requests
+          'request', // for Express requests
+          'res', // for Express responses
+          'response', // for Express responses
+          '$scope' // for Angular 1 scopes
+        ]
+      }]
+    }
   }))
 
   const lintedMain = await project.read('src/main.js')