fix: correctly catch errors of offline install

haoqunjiang · haoqunjiang · commit 76c173693e51 · 2020-02-01T14:41:14.000+08:00
diff --git a/packages/@vue/cli/lib/util/ProjectPackageManager.js b/packages/@vue/cli/lib/util/ProjectPackageManager.js
@@ -243,9 +243,9 @@ class PackageManager {
   async install () {
     if (process.env.VUE_CLI_TEST) {
       try {
-        return this.runCommand([PACKAGE_MANAGER_CONFIG[this.bin].install, '--offline'])
+        await this.runCommand([PACKAGE_MANAGER_CONFIG[this.bin].install, '--offline'])
       } catch (e) {
-        this.runCommand([PACKAGE_MANAGER_CONFIG[this.bin].install])
+        await this.runCommand([PACKAGE_MANAGER_CONFIG[this.bin].install])
       }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -243,9 +243,9 @@ class PackageManager {`
`243`	`243`	`async install () {`
`244`	`244`	`if (process.env.VUE_CLI_TEST) {`
`245`	`245`	`try {`
`246`		`- return this.runCommand([PACKAGE_MANAGER_CONFIG[this.bin].install, '--offline'])`
	`246`	`+ await this.runCommand([PACKAGE_MANAGER_CONFIG[this.bin].install, '--offline'])`
`247`	`247`	`} catch (e) {`
`248`		`- this.runCommand([PACKAGE_MANAGER_CONFIG[this.bin].install])`
	`248`	`+ await this.runCommand([PACKAGE_MANAGER_CONFIG[this.bin].install])`
`249`	`249`	`}`
`250`	`250`	`}`
`251`	`251`