Skip to content

Commit 5efbd1b

Browse files
author
Guillaume Chau
committed
feat(configuration details): better loading UX
1 parent f8ccef1 commit 5efbd1b

File tree

1 file changed

+12
-1
lines changed

1 file changed

+12
-1
lines changed

packages/@vue/cli-ui/src/views/ProjectConfigurationDetails.vue

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,11 @@
2828
</div>
2929
</template>
3030

31+
<VueLoadingIndicator
32+
v-else
33+
class="loading"
34+
/>
35+
3136
<div class="actions-bar">
3237
<VueButton
3338
v-if="configuration && configuration.link"
@@ -102,13 +107,15 @@ export default {
102107
id: this.id
103108
}
104109
},
110+
manual: true,
105111
async result ({ data, loading }) {
106112
if (!this.$_init && !loading && data && data.configuration) {
107113
this.$_init = true
108114
this.tabsHaveChanges = data.configuration.tabs.reduce((obj, tab) => {
109115
obj[tab.id] = false
110116
return obj
111117
}, {})
118+
this.configuration = data.configuration
112119
await this.$nextTick()
113120
this.currentTab = data.configuration.tabs[0].id
114121
}
@@ -136,6 +143,7 @@ export default {
136143
methods: {
137144
init (tab) {
138145
this.currentTab = '__default'
146+
this.configuration = null
139147
this.$_init = false
140148
},
141149
@@ -176,9 +184,12 @@ export default {
176184
align-items stretch
177185
height 100%
178186
179-
.content
187+
.content,
188+
.loading
180189
flex 100% 1 1
181190
height 0
191+
192+
.content
182193
overflow-x hidden
183194
overflow-y auto
184195

0 commit comments

Comments
 (0)