Skip to content

Commit 5cb988c

Browse files
authored
fix(GeneratorAPI): remove warning when using extendPackage with prune (#5202)
Currently, if we use `api.extendPackage({foo: null}, {prune: true})` the dependency is removed but a warning is logged as the range is invalid: ``` WARN invalid version range for dependency "foo": - null injected by generator "my-plugin" ```
1 parent 69f6805 commit 5cb988c

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

packages/@vue/cli/__tests__/Generator.spec.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -457,6 +457,9 @@ test('api: extendPackage + { prune: true }', async () => {
457457

458458
await generator.generate()
459459

460+
// should not warn about the null versions
461+
expect(logs.warn.length).toBe(0)
462+
460463
const pkg = JSON.parse(fs.readFileSync('/package.json', 'utf-8'))
461464
expect(pkg).toEqual({
462465
version: '0.0.0',

packages/@vue/cli/lib/util/mergeDeps.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ module.exports = function mergeDeps (
4242

4343
if (prune && injectingRange == null) {
4444
delete result[depName]
45+
continue
4546
}
4647

4748
if (!isValidRange(injectingRange)) {

0 commit comments

Comments
 (0)