Skip to content

Commit 47b7dda

Browse files
authored
fix : accessibility issue for the navigation (#6812) [skip ci]
Co-authored-by: MasihTak <masihtak@outlook.com> Fixes #6811
1 parent 281c799 commit 47b7dda

File tree

2 files changed

+14
-14
lines changed
  • packages/@vue/cli-plugin-router/generator

2 files changed

+14
-14
lines changed

packages/@vue/cli-plugin-router/generator/template-vue3/src/App.vue

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ replace:
88
99
<%# REPLACE %>
1010
<template>
11-
<div id="nav">
11+
<nav>
1212
<router-link to="/">Home</router-link> |
1313
<router-link to="/about">About</router-link>
14-
</div>
14+
</nav>
1515
<router-view/>
1616
</template>
1717
<%# END_REPLACE %>
@@ -24,20 +24,20 @@ replace:
2424
2525
<%_ if (rootOptions.cssPreprocessor !== 'stylus') { _%>
2626
<%_ if (!rootOptions.cssPreprocessor) { _%>
27-
#nav {
27+
nav {
2828
padding: 30px;
2929
}
3030
31-
#nav a {
31+
nav a {
3232
font-weight: bold;
3333
color: #2c3e50;
3434
}
3535
36-
#nav a.router-link-exact-active {
36+
nav a.router-link-exact-active {
3737
color: #42b983;
3838
}
3939
<%_ } else { _%>
40-
#nav {
40+
nav {
4141
padding: 30px;
4242
4343
a {
@@ -51,7 +51,7 @@ replace:
5151
}
5252
<%_ } _%>
5353
<%_ } else { _%>
54-
#nav
54+
nav
5555
padding 30px
5656
a
5757
font-weight bold

packages/@vue/cli-plugin-router/generator/template/src/App.vue

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@ replace:
99
<%# REPLACE %>
1010
<template>
1111
<div id="app">
12-
<div id="nav">
12+
<nav>
1313
<router-link to="/">Home</router-link> |
1414
<router-link to="/about">About</router-link>
15-
</div>
15+
</nav>
1616
<router-view/>
1717
</div>
1818
</template>
@@ -26,20 +26,20 @@ replace:
2626
2727
<%_ if (rootOptions.cssPreprocessor !== 'stylus') { _%>
2828
<%_ if (!rootOptions.cssPreprocessor) { _%>
29-
#nav {
29+
nav {
3030
padding: 30px;
3131
}
3232
33-
#nav a {
33+
nav a {
3434
font-weight: bold;
3535
color: #2c3e50;
3636
}
3737
38-
#nav a.router-link-exact-active {
38+
nav a.router-link-exact-active {
3939
color: #42b983;
4040
}
4141
<%_ } else { _%>
42-
#nav {
42+
nav {
4343
padding: 30px;
4444
4545
a {
@@ -53,7 +53,7 @@ replace:
5353
}
5454
<%_ } _%>
5555
<%_ } else { _%>
56-
#nav
56+
nav
5757
padding 30px
5858
a
5959
font-weight bold

0 commit comments

Comments
 (0)