Skip to content

Commit 1bc8006

Browse files
committed
chore: move yorkie from cli-service to plugin-eslint & plugin-typescript (#4153)
It is because yorkie is not used anywhere in @vue/cli-service, but only included for the `lintOn: 'commit'` feature of eslint & typescript plugin. Also, a lot of global installation issues are caused by the yorkie postinstall script. Moving it out of the dependency chain of `@vue/cli` mitigates such issues. (cherry picked from commit 271bf39)
1 parent 4f379d4 commit 1bc8006

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

packages/@vue/cli-plugin-eslint/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@
2727
"babel-eslint": "^10.0.1",
2828
"eslint-loader": "^2.1.2",
2929
"globby": "^9.2.0",
30-
"webpack": ">=4 < 4.29"
30+
"webpack": ">=4 < 4.29",
31+
"yorkie": "^2.0.0"
3132
},
3233
"optionalDependencies": {
3334
"eslint": "^4.19.1",

packages/@vue/cli-plugin-typescript/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@
2929
"globby": "^9.2.0",
3030
"ts-loader": "^5.3.3",
3131
"tslint": "^5.15.0",
32-
"webpack": ">=4 < 4.29"
32+
"webpack": ">=4 < 4.29",
33+
"yorkie": "^2.0.0"
3334
},
3435
"peerDependencies": {
3536
"typescript": ">=2"

packages/@vue/cli-service/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,7 @@
7878
"webpack-bundle-analyzer": "^3.3.0",
7979
"webpack-chain": "^4.11.0",
8080
"webpack-dev-server": "^3.4.1",
81-
"webpack-merge": "^4.2.1",
82-
"yorkie": "^2.0.0"
81+
"webpack-merge": "^4.2.1"
8382
},
8483
"peerDependencies": {
8584
"vue-template-compiler": "^2.0.0"

0 commit comments

Comments
 (0)