chore!: change default value of lintOnSave option (#3975)

BREAKING CHANGE:
See #3572

Author: haoqunjiang

packages/@vue/cli-plugin-eslint/__tests__/eslintPlugin.spec.js

@@ -61,7 +61,7 @@ test('should work', async () => {
     done = resolve
   })
   // enable lintOnSave
-  await write('vue.config.js', 'module.exports = { lintOnSave: true }')
+  await write('vue.config.js', "module.exports = { lintOnSave: 'default' }")
   // write invalid file
   const app = await read('src/App.vue')
   const updatedApp = app.replace(/;/, '')
@@ -74,7 +74,7 @@ test('should work', async () => {
     data = data.toString()
     if (isFirstMsg) {
       // should fail on start
-      expect(data).toMatch(/Compiled with \d warning/)
+      expect(data).toMatch(/Failed to compile with \d error/)
       isFirstMsg = false
 
       // fix it

packages/@vue/cli-service-global/index.js

@@ -73,7 +73,7 @@ function createService (context, entry, asLib) {
   return new Service(context, {
     projectOptions: {
       compiler: true,
-      lintOnSave: true
+      lintOnSave: 'default'
     },
     plugins: [
       babelPlugin,

packages/@vue/cli-service/__tests__/Service.spec.js

@@ -77,11 +77,11 @@ test('loading plugins from package.json', () => {
 test('load project options from package.json', () => {
   mockPkg({
     vue: {
-      lintOnSave: true
+      lintOnSave: 'default'
     }
   })
   const service = createMockService()
-  expect(service.projectOptions.lintOnSave).toBe(true)
+  expect(service.projectOptions.lintOnSave).toBe('default')
 })
 
 test('deprecate baseUrl', () => {
@@ -144,7 +144,7 @@ test('load project options from vue.config.js', () => {
   fs.writeFileSync('/vue.config.js', `module.exports = { lintOnSave: false }`)
   mockPkg({
     vue: {
-      lintOnSave: true
+      lintOnSave: 'default'
     }
   })
   const service = createMockService()
@@ -160,7 +160,7 @@ test('load project options from vue.config.js', () => {
   jest.mock('/vue.config.js', () => function () { return { lintOnSave: false } }, { virtual: true })
   mockPkg({
     vue: {
-      lintOnSave: true
+      lintOnSave: 'default'
     }
   })
   const service = createMockService()

packages/@vue/cli-service/lib/options.js

@@ -128,7 +128,7 @@ exports.defaults = () => ({
   },
 
   // whether to use eslint-loader
-  lintOnSave: true,
+  lintOnSave: 'default',
 
   devServer: {
     /*

packages/@vue/cli-ui-addon-widgets/src/components/News.vue

@@ -161,6 +161,7 @@ export default {
         this.widget.customTitle = this.feed.title
       } catch (e) {
         this.error = 'fetch'
+        // eslint-disable-next-line no-console
         console.error(e)
       }
       this.loading = false

packages/@vue/cli/__tests__/Generator.spec.js

@@ -584,7 +584,7 @@ test('api: addConfigTransform (multiple)', async () => {
 test('api: addConfigTransform transform vue warn', async () => {
   const configs = {
     vue: {
-      lintOnSave: true
+      lintOnSave: 'default'
     }
   }
 
@@ -606,7 +606,7 @@ test('api: addConfigTransform transform vue warn', async () => {
     extractConfigFiles: true
   })
 
-  expect(fs.readFileSync('/vue.config.js', 'utf-8')).toMatch('module.exports = {\n  lintOnSave: true\n}')
+  expect(fs.readFileSync('/vue.config.js', 'utf-8')).toMatch(`module.exports = {\n  lintOnSave: 'default'\n}`)
   expect(logs.warn.some(([msg]) => {
     return msg.match(/Reserved config transform 'vue'/)
   })).toBe(true)

packages/@vue/cli/__tests__/invoke.spec.js

@@ -90,7 +90,7 @@ test('invoke with ts', async () => {
   await project.write('package.json', JSON.stringify(pkg, null, 2))
 
   // mock existing vue.config.js
-  await project.write('vue.config.js', `module.exports = { lintOnSave: true }`)
+  await project.write('vue.config.js', `module.exports = { lintOnSave: 'default' }`)
 
   const eslintrc = parseJS(await project.read('.eslintrc.js'))
   expect(eslintrc).toEqual(Object.assign({}, baseESLintConfig, {