From f6247273bd8c2ec54f76ee91291e4c1dc0b9b75d Mon Sep 17 00:00:00 2001 From: Bruno Lesieur Date: Sat, 14 Oct 2017 10:19:57 +0200 Subject: [PATCH 1/6] New in with + symbol Signed-off-by: Bruno Lesieur --- src/v2/guide/events.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/v2/guide/events.md b/src/v2/guide/events.md index bb084488d9..1172992559 100644 --- a/src/v2/guide/events.md +++ b/src/v2/guide/events.md @@ -259,7 +259,7 @@ In the above example, the handler will only be called if `$event.key === 'PageDo ## System Modifier Keys -> New in 2.1.0 +> New in 2.1.0+ You can use the following modifiers to trigger mouse or keyboard event listeners only when the corresponding modifier key is pressed: @@ -284,7 +284,7 @@ For example: ### `.exact` Modifier -> New in 2.5.0 +> New in 2.5.0+ The `.exact` modifier should be used in combination with other system modifiers to indicate that the exact combination of modifiers must be pressed for the handler to fire. From b64e9cfe6026dcdfae7ce4fbf6fe192a0406f5e8 Mon Sep 17 00:00:00 2001 From: Bruno Lesieur Date: Sat, 14 Oct 2017 10:54:47 +0200 Subject: [PATCH 2/6] Review of 2.5.0 doc Signed-off-by: Bruno Lesieur --- src/v2/guide/typescript.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/v2/guide/typescript.md b/src/v2/guide/typescript.md index eb78541d58..922a523745 100644 --- a/src/v2/guide/typescript.md +++ b/src/v2/guide/typescript.md @@ -4,7 +4,7 @@ type: guide order: 404 --- -> In Vue 2.5.0 we have greatly improved our type declarations to work with the default object-based API. At the same time it introduces a few changes that require upgrade actions. Read [this blog post](https://medium.com/the-vue-point/upcoming-typescript-changes-in-vue-2-5-e9bd7e2ecf08) for more details. +> In Vue 2.5.0+ we have greatly improved our type declarations to work with the default object-based API. At the same time it introduces a few changes that require upgrade actions. Read [this blog post](https://medium.com/the-vue-point/upcoming-typescript-changes-in-vue-2-5-e9bd7e2ecf08) for more details. ## Official Declaration in NPM Packages @@ -128,7 +128,7 @@ import Vue from 'vue' declare module 'vue/types/vue' { // Global properties can be declared - // on the VueConstructor interface + // on the `VueConstructor` interface interface VueConstructor { $myGlobal: string } From 22e62ea938ce70240ac9aaebc3f8e73eaf47a102 Mon Sep 17 00:00:00 2001 From: Bruno Lesieur Date: Sat, 14 Oct 2017 11:30:15 +0200 Subject: [PATCH 3/6] Review Signed-off-by: Bruno Lesieur --- src/v2/api/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/v2/api/index.md b/src/v2/api/index.md index 6c766df1a2..33abc848f7 100644 --- a/src/v2/api/index.md +++ b/src/v2/api/index.md @@ -115,7 +115,7 @@ type: api Vue.config.ignoredElements = [ 'my-custom-web-component', 'another-web-component', - // Use a RegExp to ignore all elements that start with "ion-" + // Use a `RegExp` to ignore all elements that start with "ion-" // 2.5+ only /^ion-/ ] From e681bc4faeaec92bf4b8ebbd80a6fe2364f876a8 Mon Sep 17 00:00:00 2001 From: Bruno Lesieur Date: Tue, 12 Dec 2017 18:09:30 +0100 Subject: [PATCH 4/6] Fix syntax typo Signed-off-by: Bruno Lesieur --- src/v2/style-guide/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/v2/style-guide/index.md b/src/v2/style-guide/index.md index 9d4ebf6413..f88fdb2f02 100644 --- a/src/v2/style-guide/index.md +++ b/src/v2/style-guide/index.md @@ -313,7 +313,7 @@ There are two common cases where this can be tempting: - To filter items in a list (e.g. `v-for="user in users" v-if="user.isActive"`). In these cases, replace `users` with a new computed property that returns your filtered list (e.g. `activeUsers`). -- To avoid rendering a list if it should be hidden (e.g. `v-for="user in users" v-if="shouldShowUsers"). In these cases, move the `v-if` to a container element (e.g. `ul`, `ol`). +- To avoid rendering a list if it should be hidden (e.g. `v-for="user in users" v-if="shouldShowUsers"`). In these cases, move the `v-if` to a container element (e.g. `ul`, `ol`). {% raw %}
From 60d918cccda4e08ad389ca5777decba18e618c83 Mon Sep 17 00:00:00 2001 From: MachinisteWeb Date: Tue, 2 Jan 2018 13:20:12 +0100 Subject: [PATCH 5/6] Add space between new line of documentation Signed-off-by: MachinisteWeb --- src/v2/guide/events.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/v2/guide/events.md b/src/v2/guide/events.md index 34f4da1ee7..6a7a1d5e5d 100644 --- a/src/v2/guide/events.md +++ b/src/v2/guide/events.md @@ -213,7 +213,9 @@ Unlike the other modifiers, which are exclusive to native DOM events, the `.once ``` In addition to these modifiers, Vue provides `.passive` modifier to improve the performance on mobile especially. + For example, when performing a scroll, the browser will scroll after the process has completed because the browser doesn’t know if the event is going to call `event.preventDefault()` within its handler. + `.passive` modifier can be used to tell the browser that this event will not cancel the default event behavior in advance.

Don't use `.passive` and `.prevent` together. Passive handler can't prevent default event.

From e3c42c0a266efba230e11ec9385b1f624e875e01 Mon Sep 17 00:00:00 2001 From: MachinisteWeb Date: Tue, 2 Jan 2018 14:11:37 +0100 Subject: [PATCH 6/6] Add @posva review Signed-off-by: MachinisteWeb --- src/v2/guide/events.md | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/v2/guide/events.md b/src/v2/guide/events.md index 6a7a1d5e5d..c138031194 100644 --- a/src/v2/guide/events.md +++ b/src/v2/guide/events.md @@ -212,11 +212,7 @@ Unlike the other modifiers, which are exclusive to native DOM events, the `.once
...
``` -In addition to these modifiers, Vue provides `.passive` modifier to improve the performance on mobile especially. - -For example, when performing a scroll, the browser will scroll after the process has completed because the browser doesn’t know if the event is going to call `event.preventDefault()` within its handler. - -`.passive` modifier can be used to tell the browser that this event will not cancel the default event behavior in advance. +In addition to these modifiers, Vue provides `.passive` modifier to improve the performance on mobile especially. For example, when performing a scroll, the browser will scroll after the process has completed because the browser doesn’t know if the event is going to call `event.preventDefault()` within its handler. `.passive` modifier can be used to tell the browser that this event will not cancel the default event behavior in advance.

Don't use `.passive` and `.prevent` together. Passive handler can't prevent default event.