From f6247273bd8c2ec54f76ee91291e4c1dc0b9b75d Mon Sep 17 00:00:00 2001 From: Bruno Lesieur Date: Sat, 14 Oct 2017 10:19:57 +0200 Subject: [PATCH 1/6] New in with + symbol Signed-off-by: Bruno Lesieur --- src/v2/guide/events.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/v2/guide/events.md b/src/v2/guide/events.md index bb084488d9..1172992559 100644 --- a/src/v2/guide/events.md +++ b/src/v2/guide/events.md @@ -259,7 +259,7 @@ In the above example, the handler will only be called if `$event.key === 'PageDo ## System Modifier Keys -> New in 2.1.0 +> New in 2.1.0+ You can use the following modifiers to trigger mouse or keyboard event listeners only when the corresponding modifier key is pressed: @@ -284,7 +284,7 @@ For example: ### `.exact` Modifier -> New in 2.5.0 +> New in 2.5.0+ The `.exact` modifier should be used in combination with other system modifiers to indicate that the exact combination of modifiers must be pressed for the handler to fire. From b64e9cfe6026dcdfae7ce4fbf6fe192a0406f5e8 Mon Sep 17 00:00:00 2001 From: Bruno Lesieur Date: Sat, 14 Oct 2017 10:54:47 +0200 Subject: [PATCH 2/6] Review of 2.5.0 doc Signed-off-by: Bruno Lesieur --- src/v2/guide/typescript.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/v2/guide/typescript.md b/src/v2/guide/typescript.md index eb78541d58..922a523745 100644 --- a/src/v2/guide/typescript.md +++ b/src/v2/guide/typescript.md @@ -4,7 +4,7 @@ type: guide order: 404 --- -> In Vue 2.5.0 we have greatly improved our type declarations to work with the default object-based API. At the same time it introduces a few changes that require upgrade actions. Read [this blog post](https://medium.com/the-vue-point/upcoming-typescript-changes-in-vue-2-5-e9bd7e2ecf08) for more details. +> In Vue 2.5.0+ we have greatly improved our type declarations to work with the default object-based API. At the same time it introduces a few changes that require upgrade actions. Read [this blog post](https://medium.com/the-vue-point/upcoming-typescript-changes-in-vue-2-5-e9bd7e2ecf08) for more details. ## Official Declaration in NPM Packages @@ -128,7 +128,7 @@ import Vue from 'vue' declare module 'vue/types/vue' { // Global properties can be declared - // on the VueConstructor interface + // on the `VueConstructor` interface interface VueConstructor { $myGlobal: string } From 22e62ea938ce70240ac9aaebc3f8e73eaf47a102 Mon Sep 17 00:00:00 2001 From: Bruno Lesieur Date: Sat, 14 Oct 2017 11:30:15 +0200 Subject: [PATCH 3/6] Review Signed-off-by: Bruno Lesieur --- src/v2/api/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/v2/api/index.md b/src/v2/api/index.md index 6c766df1a2..33abc848f7 100644 --- a/src/v2/api/index.md +++ b/src/v2/api/index.md @@ -115,7 +115,7 @@ type: api Vue.config.ignoredElements = [ 'my-custom-web-component', 'another-web-component', - // Use a RegExp to ignore all elements that start with "ion-" + // Use a `RegExp` to ignore all elements that start with "ion-" // 2.5+ only /^ion-/ ] From 6ceee4ef92284839f7e13ea6570a0290f84c6219 Mon Sep 17 00:00:00 2001 From: Bruno Lesieur Date: Thu, 2 Nov 2017 10:18:23 +0100 Subject: [PATCH 4/6] Correct line return Signed-off-by: Bruno Lesieur --- src/v2/guide/typescript.md | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/v2/guide/typescript.md b/src/v2/guide/typescript.md index e5283d8443..334c024caf 100644 --- a/src/v2/guide/typescript.md +++ b/src/v2/guide/typescript.md @@ -144,8 +144,7 @@ var vm = new Vue({ ## Annotating Return Types -Because of the circular nature of Vue's declaration files, TypeScript may have difficulties inferring the types of certain methods. -For this reason, you may need to annotate the return type on methods like `render` and those in `computed`. +Because of the circular nature of Vue's declaration files, TypeScript may have difficulties inferring the types of certain methods. For this reason, you may need to annotate the return type on methods like `render` and those in `computed`. ```ts import Vue, { VNode } from 'vue' @@ -175,5 +174,4 @@ const Component = Vue.extend({ }) ``` -If you find type inference or member completion isn't working, annotating certain methods may help address these problems. -Using the `--noImplicitAny` option will help find many of these unannotated methods. +If you find type inference or member completion isn't working, annotating certain methods may help address these problems. Using the `--noImplicitAny` option will help find many of these unannotated methods. From cef849f4c99da37b795730855cede1ce38512ca1 Mon Sep 17 00:00:00 2001 From: Bruno Lesieur Date: Fri, 3 Nov 2017 16:43:32 +0100 Subject: [PATCH 5/6] Good list number Signed-off-by: Bruno Lesieur --- src/v2/style-guide/index.md | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/v2/style-guide/index.md b/src/v2/style-guide/index.md index 3e40a7c0bb..fbdf84428e 100644 --- a/src/v2/style-guide/index.md +++ b/src/v2/style-guide/index.md @@ -1377,34 +1377,34 @@ This is the default order we recommend for component options. They're split into 2. **List Rendering** (creates multiple variations of the same element) - `v-for` -2. **Conditionals** (whether the element is rendered/shown) +3. **Conditionals** (whether the element is rendered/shown) - `v-if` - `v-else-if` - `v-else` - `v-show` - `v-cloak` -3. **Render Modifiers** (changes the way the element renders) +4. **Render Modifiers** (changes the way the element renders) - `v-pre` - `v-once` -4. **Global Awareness** (requires knowledge beyond the component) +5. **Global Awareness** (requires knowledge beyond the component) - `id` -5. **Unique Attributes** (attributes that require unique values) +6. **Unique Attributes** (attributes that require unique values) - `ref` - `key` - `slot` -6. **Two-Way Binding** (combining binding and events) +7. **Two-Way Binding** (combining binding and events) - `v-model` -7. **Other Attributes** (all unspecified bound & unbound attributes) +8. **Other Attributes** (all unspecified bound & unbound attributes) -8. **Events** (component event listeners) +9. **Events** (component event listeners) - `v-on` -9. **Content** (overrides the content of the element) +10. **Content** (overrides the content of the element) - `v-html` - `v-text` From e74438083df8ae698ff80cfe602ce1cd491cd106 Mon Sep 17 00:00:00 2001 From: Bruno Lesieur Date: Fri, 3 Nov 2017 16:49:16 +0100 Subject: [PATCH 6/6] fix typo in style-guide/index.md Signed-off-by: Bruno Lesieur --- src/v2/style-guide/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/v2/style-guide/index.md b/src/v2/style-guide/index.md index fbdf84428e..c368162e0b 100644 --- a/src/v2/style-guide/index.md +++ b/src/v2/style-guide/index.md @@ -1476,7 +1476,7 @@ computed: { ### Single-file component top-level element order recommended -**[Single-file components](../guide/single-file-components.html) should always order `template`, `script`, and `style` tags consistently, with `