Skip to content

Commit d80b664

Browse files
authored
chore: remove vueschool banner (#2796)
1 parent 74f42ca commit d80b664

File tree

13 files changed

+14
-303
lines changed

13 files changed

+14
-303
lines changed

themes/vue/layout/index.ejs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -163,11 +163,10 @@
163163
})
164164
165165
window.addEventListener('scroll', function () {
166-
var offset = 20
167-
if (window.pageYOffset > offset && !topScrolled) {
166+
if (window.pageYOffset > 165 && !topScrolled) {
168167
topScrolled = true
169168
document.getElementById('mobile-bar').classList.remove('top')
170-
} else if (window.pageYOffset <= offset && topScrolled) {
169+
} else if (window.pageYOffset <= 165 && topScrolled) {
171170
topScrolled = false
172171
document.getElementById('mobile-bar').classList.add('top')
173172
}

themes/vue/layout/layout.ejs

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
<% var isIndex = page.path === 'index.html' %>
22
<% var isThemes = page.path === 'resources/themes.html' %>
3-
<% var hasVueSchoolBanner = true %>
43

54
<!DOCTYPE html>
65
<html lang="en" class="with-v3-banner">
@@ -55,7 +54,7 @@
5554
<link href="https://fonts.gstatic.com" rel="preconnect" crossorigin>
5655
<link href="https://maxcdn.bootstrapcdn.com" rel="preconnect" crossorigin>
5756

58-
<link href="https://fonts.googleapis.com/css?family=Source+Sans+Pro:300,400,600|Roboto|Roboto Mono&display=swap" rel="stylesheet">
57+
<link href="https://fonts.googleapis.com/css?family=Source+Sans+Pro:300,400,600|Roboto Mono&display=swap" rel="stylesheet">
5958
<link href="https://fonts.googleapis.com/css?family=Dosis:500&text=Vue.js&display=swap" rel="stylesheet">
6059

6160
<link href="https://maxcdn.bootstrapcdn.com/font-awesome/4.7.0/css/font-awesome.min.css" rel="stylesheet">
@@ -91,11 +90,6 @@
9190
<script type="text/javascript" defer="defer" src="https://extend.vimeocdn.com/ga/72160148.js"></script>
9291
</head>
9392
<body class="<%- isIndex ? '' : 'docs' -%>">
94-
95-
<% if (hasVueSchoolBanner) { %>
96-
<%- partial('partials/vueschool_banner') %>
97-
<% } %>
98-
9993
<div id="mobile-bar" <%- isIndex ? 'class="top"' : '' %>>
10094
<a class="menu-button"></a>
10195
<a class="logo" href="/"></a>

themes/vue/layout/partials/vueschool_banner.ejs

Lines changed: 0 additions & 22 deletions
This file was deleted.

themes/vue/source/css/_header.styl

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
@import "_settings"
21
$header-height = 40px
32

43
red-dot-before(leftPos = -8px)
@@ -13,12 +12,10 @@ red-dot-before(leftPos = -8px)
1312

1413
#header
1514
background-color: #fff
16-
padding: $heading-padding-vertical 30px $heading-padding-vertical 60px
15+
height: $header-height
16+
padding: $heading-padding-vertical 60px
1717
position: relative
1818
z-index: $z-header
19-
display: flex
20-
justify-content: space-between
21-
box-sizing: border-box
2219

2320
#v3-banner
2421
background-color: $green
@@ -43,11 +40,18 @@ body.docs
4340
position: fixed
4441
width: 100%
4542
top: 0
43+
#nav
44+
position: fixed
45+
top: $heading-padding-vertical
4646

4747
#nav
4848
list-style-type: none
4949
margin: 0
5050
padding: 0
51+
position: absolute
52+
right: 30px
53+
top: $heading-padding-vertical
54+
height: $header-height
5155
line-height: $header-height
5256
.break
5357
display: none
@@ -143,7 +147,6 @@ body.docs
143147
display: none
144148
box-shadow: 0 0 2px rgba(0,0,0,.25)
145149
pointer-events: none
146-
transition: background-color 0.25s ease-in
147150
> *
148151
pointer-events: auto
149152
.menu-button

themes/vue/source/css/_sidebar.styl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@
6767
position: fixed
6868
background-color: #f9f9f9
6969
height: 100%
70-
top: 40px
70+
top: 0
7171
left: 0
7272
box-shadow: 0 0 10px rgba(0,0,0,.2)
7373
transition: all .4s cubic-bezier(0.4, 0, 0, 1)

themes/vue/source/css/_vueschool.styl

Lines changed: 0 additions & 142 deletions
This file was deleted.

themes/vue/source/css/index.styl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
@import "_sponsors-index"
55
@import "_modal"
66
@import "_themes"
7-
@import "_vueschool.styl"
87

98
$width = 900px
109
$space = 40px

themes/vue/source/css/page.styl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
@import "_scrimba"
1717
@import "_vue-mastery"
1818
@import "_themes"
19-
@import "_vueschool.styl"
2019

2120
#header
2221
box-shadow: 0 0 1px rgba(0,0,0,.25)

themes/vue/source/images/banners/close.svg

Lines changed: 0 additions & 7 deletions
This file was deleted.

0 commit comments

Comments
 (0)