From 683ced973709358f41dba1732b1d4704a5fac940 Mon Sep 17 00:00:00 2001 From: Lachlan Miller Date: Sun, 18 Oct 2020 11:27:13 +1000 Subject: [PATCH] refactor: do not pollute markup with useless id --- src/constants.ts | 1 - src/mount.ts | 7 +------ 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/constants.ts b/src/constants.ts index a48a34fab..5e7d403f1 100644 --- a/src/constants.ts +++ b/src/constants.ts @@ -1,3 +1,2 @@ -export const MOUNT_ELEMENT_ID = 'app' export const MOUNT_COMPONENT_REF = 'VTU_COMPONENT' export const MOUNT_PARENT_NAME = 'VTU_ROOT' diff --git a/src/mount.ts b/src/mount.ts index ada6d81b5..775c8b5dd 100644 --- a/src/mount.ts +++ b/src/mount.ts @@ -27,11 +27,7 @@ import { processSlot } from './utils/compileSlots' import { createWrapper, VueWrapper } from './vueWrapper' import { attachEmitListener } from './emitMixin' import { createDataMixin } from './dataMixin' -import { - MOUNT_COMPONENT_REF, - MOUNT_ELEMENT_ID, - MOUNT_PARENT_NAME -} from './constants' +import { MOUNT_COMPONENT_REF, MOUNT_PARENT_NAME } from './constants' import { stubComponents } from './stubs' type Slot = VNode | string | { render: Function } | Function | Component @@ -194,7 +190,6 @@ export function mount( : { ...originalComponent } const el = document.createElement('div') - el.id = MOUNT_ELEMENT_ID if (options?.attachTo) { let to: Element | null