Skip to content

Commit 3b3ac91

Browse files
authored
Merge pull request #225 from vuejs/remove-useless-id
refactor: do not pollute markup with useless id
2 parents 02cd7c9 + 683ced9 commit 3b3ac91

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

src/constants.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
1-
export const MOUNT_ELEMENT_ID = 'app'
21
export const MOUNT_COMPONENT_REF = 'VTU_COMPONENT'
32
export const MOUNT_PARENT_NAME = 'VTU_ROOT'

src/mount.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,7 @@ import { processSlot } from './utils/compileSlots'
3232
import { createWrapper, VueWrapper } from './vueWrapper'
3333
import { attachEmitListener } from './emitMixin'
3434
import { createDataMixin } from './dataMixin'
35-
import {
36-
MOUNT_COMPONENT_REF,
37-
MOUNT_ELEMENT_ID,
38-
MOUNT_PARENT_NAME
39-
} from './constants'
35+
import { MOUNT_COMPONENT_REF, MOUNT_PARENT_NAME } from './constants'
4036
import { stubComponents } from './stubs'
4137

4238
// NOTE this should come from `vue`
@@ -241,7 +237,6 @@ export function mount(
241237
: { ...originalComponent }
242238

243239
const el = document.createElement('div')
244-
el.id = MOUNT_ELEMENT_ID
245240

246241
if (options?.attachTo) {
247242
let to: Element | null

0 commit comments

Comments
 (0)