From 03b53c753d4ecb6b211627926dd944d3361c23b6 Mon Sep 17 00:00:00 2001 From: Eduardo San Martin Morote Date: Tue, 28 Mar 2017 13:45:05 +0200 Subject: [PATCH 1/3] Add failing test for uppercase copmonent Currently the compiled result of a template yields a lowercase version while it should keep the original case. --- test/expects/compileTemplateLocalComponent.js | 9 +++++++++ test/fixtures/compileTemplateLocalComponent.vue | 15 +++++++++++++++ test/test.js | 2 +- 3 files changed, 25 insertions(+), 1 deletion(-) create mode 100755 test/expects/compileTemplateLocalComponent.js create mode 100755 test/fixtures/compileTemplateLocalComponent.vue diff --git a/test/expects/compileTemplateLocalComponent.js b/test/expects/compileTemplateLocalComponent.js new file mode 100755 index 0000000..138d012 --- /dev/null +++ b/test/expects/compileTemplateLocalComponent.js @@ -0,0 +1,9 @@ +var compileTemplate = {render: function(){var _vm=this;var _h=_vm.$createElement;var _c=_vm._self._c||_h;return _c('div',[_c('Msg')], 1)},staticRenderFns: [], + components: { + Msg: { + render: h => h('div', ['Hello']), + }, + }, +}; + +export default compileTemplateLocalComponent; diff --git a/test/fixtures/compileTemplateLocalComponent.vue b/test/fixtures/compileTemplateLocalComponent.vue new file mode 100755 index 0000000..d1588df --- /dev/null +++ b/test/fixtures/compileTemplateLocalComponent.vue @@ -0,0 +1,15 @@ + + + diff --git a/test/test.js b/test/test.js index f4d7203..35585a7 100644 --- a/test/test.js +++ b/test/test.js @@ -33,7 +33,7 @@ function test(name) { modules: { generateScopedName: '[name]__[local]' }, - compileTemplate: ['compileTemplate', 'slot', 'table', 'table-n-slot'].indexOf(name) > -1 + compileTemplate: ['compileTemplate', 'compileTemplateLocalComponent', 'slot', 'table', 'table-n-slot'].indexOf(name) > -1 })] }).then(function (bundle) { var result = bundle.generate({ format: 'es' }) From 30b428ebf433bed9a182659e10fc5f631f9938e8 Mon Sep 17 00:00:00 2001 From: Rahul Kadyan Date: Wed, 3 May 2017 12:41:08 +0530 Subject: [PATCH 2/3] Update test.js Just to trigger CI build. --- test/test.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/test/test.js b/test/test.js index 35585a7..b7e2e7c 100644 --- a/test/test.js +++ b/test/test.js @@ -33,7 +33,13 @@ function test(name) { modules: { generateScopedName: '[name]__[local]' }, - compileTemplate: ['compileTemplate', 'compileTemplateLocalComponent', 'slot', 'table', 'table-n-slot'].indexOf(name) > -1 + compileTemplate: [ + 'compileTemplate', + 'compileTemplateLocalComponent', + 'slot', + 'table', + 'table-n-slot' + ].indexOf(name) > -1 })] }).then(function (bundle) { var result = bundle.generate({ format: 'es' }) From 2b2ee446bcafe59c03f5957604baa63b3190a8e9 Mon Sep 17 00:00:00 2001 From: Eduardo San Martin Morote Date: Mon, 8 May 2017 20:20:05 +0200 Subject: [PATCH 3/3] =?UTF-8?q?=F0=9F=90=9B=20Set=20caseSensitive=20option?= =?UTF-8?q?=20in=20html-minifier?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix #81 --- src/options.js | 1 + test/expects/compileTemplateLocalComponent.js | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/options.js b/src/options.js index b7aba4f..19f6910 100644 --- a/src/options.js +++ b/src/options.js @@ -14,6 +14,7 @@ export default { // Config for html-minifier. htmlMinifier: { + caseSensitive: true, customAttrSurround: [[/@/, new RegExp('')], [/:/, new RegExp('')]], collapseWhitespace: true, removeComments: true diff --git a/test/expects/compileTemplateLocalComponent.js b/test/expects/compileTemplateLocalComponent.js index 138d012..042c4a5 100755 --- a/test/expects/compileTemplateLocalComponent.js +++ b/test/expects/compileTemplateLocalComponent.js @@ -1,4 +1,4 @@ -var compileTemplate = {render: function(){var _vm=this;var _h=_vm.$createElement;var _c=_vm._self._c||_h;return _c('div',[_c('Msg')], 1)},staticRenderFns: [], +var compileTemplateLocalComponent = {render: function(){var _vm=this;var _h=_vm.$createElement;var _c=_vm._self._c||_h;return _c('div',[_c('Msg')],1)},staticRenderFns: [], components: { Msg: { render: h => h('div', ['Hello']),