From ff58f630629f3ba0ef0c0c06160a23587e12407e Mon Sep 17 00:00:00 2001
From: Toru Nagashima <star.ctor@gmail.com>
Date: Sat, 5 Jan 2019 16:22:07 +0900
Subject: [PATCH 1/2] Chore: update vue-eslint-parser

Fixes #716
Fiees #722
Fixes #733

As a side effect, it gets ignoring expressions on outside of the
template.
---
 package.json                       |  2 +-
 tests/lib/rules/no-unused-vars.js  |  4 +-
 tests/lib/rules/valid-v-else-if.js |  2 +-
 tests/lib/rules/valid-v-else.js    |  2 +-
 tests/lib/rules/valid-v-for.js     | 75 ++++++++++++++++++------------
 5 files changed, 50 insertions(+), 35 deletions(-)

diff --git a/package.json b/package.json
index 6389b7db1..e28f6ff88 100644
--- a/package.json
+++ b/package.json
@@ -46,7 +46,7 @@
     "eslint": "^5.0.0"
   },
   "dependencies": {
-    "vue-eslint-parser": "^4.0.2"
+    "vue-eslint-parser": "^5.0.0"
   },
   "devDependencies": {
     "@types/node": "^4.2.16",
diff --git a/tests/lib/rules/no-unused-vars.js b/tests/lib/rules/no-unused-vars.js
index e033d4871..799444703 100644
--- a/tests/lib/rules/no-unused-vars.js
+++ b/tests/lib/rules/no-unused-vars.js
@@ -57,11 +57,11 @@ tester.run('no-unused-vars', rule, {
       errors: ["'i' is defined but never used."]
     },
     {
-      code: '<template scope="props"></template>',
+      code: '<template><template scope="props"></template></template>',
       errors: ["'props' is defined but never used."]
     },
     {
-      code: '<template v-for="i in 5"><comp v-for="j in 10">{{i}}{{i}}</comp></template>',
+      code: '<template><template v-for="i in 5"><comp v-for="j in 10">{{i}}{{i}}</comp></template></template>',
       errors: ["'j' is defined but never used."]
     },
     {
diff --git a/tests/lib/rules/valid-v-else-if.js b/tests/lib/rules/valid-v-else-if.js
index dd0b0724c..ca2b3ba50 100644
--- a/tests/lib/rules/valid-v-else-if.js
+++ b/tests/lib/rules/valid-v-else-if.js
@@ -43,7 +43,7 @@ tester.run('valid-v-else-if', rule, {
   invalid: [
     {
       filename: 'test.vue',
-      code: '<template v-else-if="foo"><div></div></template>',
+      code: '<template><template v-else-if="foo"><div></div></template></template>',
       errors: ["'v-else-if' directives require being preceded by the element which has a 'v-if' or 'v-else-if' directive."]
     },
     {
diff --git a/tests/lib/rules/valid-v-else.js b/tests/lib/rules/valid-v-else.js
index bce681521..21608b0da 100644
--- a/tests/lib/rules/valid-v-else.js
+++ b/tests/lib/rules/valid-v-else.js
@@ -43,7 +43,7 @@ tester.run('valid-v-else', rule, {
   invalid: [
     {
       filename: 'test.vue',
-      code: '<template v-else><div></div></template>',
+      code: '<template><template v-else><div></div></template></template>',
       errors: ["'v-else' directives require being preceded by the element which has a 'v-if' or 'v-else' directive."]
     },
     {
diff --git a/tests/lib/rules/valid-v-for.js b/tests/lib/rules/valid-v-for.js
index 6fe1f0f1c..2593b8a85 100644
--- a/tests/lib/rules/valid-v-for.js
+++ b/tests/lib/rules/valid-v-for.js
@@ -90,24 +90,30 @@ tester.run('valid-v-for', rule, {
     {
       filename: 'test.vue',
       code: `
-        <template v-for="x in xs">
-          <template v-for="y in x.ys">
-            <li v-for="z in y.zs" :key="z.id">
-              123
-            </li>
+        <template>
+          <template v-for="x in xs">
+            <template v-for="y in x.ys">
+              <li v-for="z in y.zs" :key="z.id">
+                123
+              </li>
+            </template>
           </template>
-        </template>`
+        </template>
+      `
     },
     {
       filename: 'test.vue',
       code: `
-        <template v-for="x in xs">
-          <template v-for="y in ys">
-            <li v-for="z in zs" :key="x.id + y.id + z.id">
-              123
-            </li>
+        <template>
+          <template v-for="x in xs">
+            <template v-for="y in ys">
+              <li v-for="z in zs" :key="x.id + y.id + z.id">
+                123
+              </li>
+            </template>
           </template>
-        </template>`
+        </template>
+      `
     }
   ],
   invalid: [
@@ -215,37 +221,46 @@ tester.run('valid-v-for', rule, {
       filename: 'test.vue',
       errors: ["Expected 'v-bind:key' directive to use the variables which are defined by the 'v-for' directive."],
       code: `
-        <template v-for="x in xs">
-          <template v-for="y in a.ys">
-            <li v-for="z in y.zs" :key="z.id">
-              123
-            </li>
+        <template>
+          <template v-for="x in xs">
+            <template v-for="y in a.ys">
+              <li v-for="z in y.zs" :key="z.id">
+                123
+              </li>
+            </template>
           </template>
-        </template>`
+        </template>
+      `
     },
     {
       filename: 'test.vue',
       errors: ["Expected 'v-bind:key' directive to use the variables which are defined by the 'v-for' directive."],
       code: `
-        <template v-for="x in xs">
-          <template v-for="y in x.ys">
-            <li v-for="z in a.zs" :key="z.id">
-              123
-            </li>
+        <template>
+          <template v-for="x in xs">
+            <template v-for="y in x.ys">
+              <li v-for="z in a.zs" :key="z.id">
+                123
+              </li>
+            </template>
           </template>
-        </template>`
+        </template>
+      `
     },
     {
       filename: 'test.vue',
       errors: ["Expected 'v-bind:key' directive to use the variables which are defined by the 'v-for' directive."],
       code: `
-        <template v-for="x in xs">
-          <template v-for="y in x.ys">
-            <li v-for="z in x.zs" :key="z.id">
-              123
-            </li>
+        <template>
+          <template v-for="x in xs">
+            <template v-for="y in x.ys">
+              <li v-for="z in x.zs" :key="z.id">
+                123
+              </li>
+            </template>
           </template>
-        </template>`
+        </template>
+      `
     }
 
   ]

From af20f892f73211fcb62dfe44c38892b329f5ff6e Mon Sep 17 00:00:00 2001
From: michalsnik <msajnog93@gmail.com>
Date: Sat, 5 Jan 2019 00:40:06 +0100
Subject: [PATCH 2/2] Update tests cases

---
 tests/lib/rules/no-unused-vars.js | 14 +++++++++++---
 tests/lib/rules/valid-v-for.js    |  5 ++---
 2 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/tests/lib/rules/no-unused-vars.js b/tests/lib/rules/no-unused-vars.js
index 799444703..f717e7af9 100644
--- a/tests/lib/rules/no-unused-vars.js
+++ b/tests/lib/rules/no-unused-vars.js
@@ -36,10 +36,10 @@ tester.run('no-unused-vars', rule, {
       code: '<template><ol v-for="i in data"><li v-for="f in i">{{ f.bar.baz }}</li></ol></template>'
     },
     {
-      code: '<template scope="props">{{props}}</template>'
+      code: '<template><template scope="props">{{props}}</template></template>'
     },
     {
-      code: '<template scope="props"><span v-if="props"></span></template>'
+      code: '<template><template scope="props"><span v-if="props"></span></template></template>'
     },
     {
       code: '<template><div v-for="(item, key) in items" :key="key">{{item.name}}</div></template>'
@@ -61,7 +61,15 @@ tester.run('no-unused-vars', rule, {
       errors: ["'props' is defined but never used."]
     },
     {
-      code: '<template><template v-for="i in 5"><comp v-for="j in 10">{{i}}{{i}}</comp></template></template>',
+      code: '<template><span slot-scope="props"></span></template>',
+      errors: ["'props' is defined but never used."]
+    },
+    {
+      code: '<template><span><template scope="props"></template></span></template>',
+      errors: ["'props' is defined but never used."]
+    },
+    {
+      code: '<template><div v-for="i in 5"><comp v-for="j in 10">{{i}}{{i}}</comp></div></template>',
       errors: ["'j' is defined but never used."]
     },
     {
diff --git a/tests/lib/rules/valid-v-for.js b/tests/lib/rules/valid-v-for.js
index 2593b8a85..d36d1172f 100644
--- a/tests/lib/rules/valid-v-for.js
+++ b/tests/lib/rules/valid-v-for.js
@@ -77,11 +77,11 @@ tester.run('valid-v-for', rule, {
     },
     {
       filename: 'test.vue',
-      code: '<template v-for="x of list"><slot name="item" /></template>'
+      code: '<template><template v-for="x of list"><slot name="item" /></template></template>'
     },
     {
       filename: 'test.vue',
-      code: '<template v-for="x of list">foo<div></div></template>'
+      code: '<template><template v-for="x of list">foo<div></div></template></template>'
     },
     {
       filename: 'test.vue',
@@ -262,6 +262,5 @@ tester.run('valid-v-for', rule, {
         </template>
       `
     }
-
   ]
 })