From 6afb16bdca931ed9d8f2e351c4015de1488d684a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jes=C3=BAs=20=C3=81ngel?= <jesusgonzaleznovez@gmail.com>
Date: Fri, 13 May 2022 16:44:13 +0200
Subject: [PATCH 1/6] feat: add no-early-return base rule

---
 docs/rules/no-early-return.md      | 103 +++++++++++++++
 lib/rules/no-early-return.js       |  72 ++++++++++
 tests/lib/rules/no-early-return.js | 203 +++++++++++++++++++++++++++++
 3 files changed, 378 insertions(+)
 create mode 100644 docs/rules/no-early-return.md
 create mode 100644 lib/rules/no-early-return.js
 create mode 100644 tests/lib/rules/no-early-return.js

diff --git a/docs/rules/no-early-return.md b/docs/rules/no-early-return.md
new file mode 100644
index 000000000..56939eb5d
--- /dev/null
+++ b/docs/rules/no-early-return.md
@@ -0,0 +1,103 @@
+---
+pageClass: rule-details
+sidebarDepth: 0
+title: vue/no-early-return
+description: disallow early returns in setup and data functions
+---
+# vue/no-early-return
+
+> disallow early returns in setup and data functions
+
+- :exclamation: <badge text="This rule has not been released yet." vertical="middle" type="error"> ***This rule has not been released yet.*** </badge>
+
+## :book: Rule Details
+
+This rule helps to identify accidental `return` statements in the `setup` block of a Vue component, these are `return` statements that would exit the `setup` block skipping part of the block itself (not allowing to each the end of the block).
+
+On the other hand, the rule checks the `data` block too, applying the same logic.
+
+<eslint-code-block :rules="{'vue/no-early-return': ['error']}">
+
+```vue
+<!-- ✓ GOOD -->
+<script>
+  export default {
+    setup () {
+      const foo = ref()
+      return { foo }
+    }
+  }
+</script>
+```
+
+</eslint-code-block>
+
+<eslint-code-block :rules="{'vue/no-early-return': ['error']}">
+
+```vue
+<!-- ✗ BAD -->
+<script>
+  export default {
+    setup () {
+      const foo = ref()
+
+      if (maybe) {
+        return
+      }
+
+      for (const t of foo.value) {
+        if (t) {
+          return
+        }
+      }
+
+      return { foo }
+    }
+  }
+</script>
+```
+
+</eslint-code-block>
+
+<eslint-code-block :rules="{'vue/no-early-return': ['error']}">
+
+```vue
+<!-- ✓ GOOD -->
+<script>
+  export default {
+    data () {
+      return { foo: true }
+    }
+  }
+</script>
+```
+
+</eslint-code-block>
+
+<eslint-code-block :rules="{'vue/no-early-return': ['error']}">
+
+```vue
+<!-- ✗ BAD -->
+<script>
+  export default {
+    data () {
+      if (maybe) {
+        return { foo: false }
+      }
+
+      return { foo: true }
+    }
+  }
+</script>
+```
+
+</eslint-code-block>
+
+## :wrench: Options
+
+Nothing.
+
+## :mag: Implementation
+
+- [Rule source](https://github.com/vuejs/eslint-plugin-vue/blob/master/lib/rules/no-early-return.js)
+- [Test source](https://github.com/vuejs/eslint-plugin-vue/blob/master/tests/lib/rules/no-early-return.js)
diff --git a/lib/rules/no-early-return.js b/lib/rules/no-early-return.js
new file mode 100644
index 000000000..50f376e1d
--- /dev/null
+++ b/lib/rules/no-early-return.js
@@ -0,0 +1,72 @@
+/**
+ * @author *****your name*****
+ * See LICENSE file in root directory for full license.
+ */
+'use strict'
+
+// ------------------------------------------------------------------------------
+// Requirements
+// ------------------------------------------------------------------------------
+
+const utils = require('../utils')
+
+// ------------------------------------------------------------------------------
+// Rule Definition
+// ------------------------------------------------------------------------------
+
+module.exports = {
+  meta: {
+    type: 'problem',
+    docs: {
+      description: 'disallow early returns in setup and data functions',
+      categories: undefined,
+      url: ''
+    },
+    fixable: null,
+    schema: []
+  },
+
+  /** @param {RuleContext} context */
+  create(context) {
+    const rStatementLocs = []
+    return utils.compositingVisitors(
+      utils.defineVueVisitor(context, {
+        ReturnStatement (node) {
+          if (context.getScope().type === 'function') {
+            return
+          }
+          rStatementLocs.push(node.loc)
+        },
+
+        onSetupFunctionExit() {
+          if (!rStatementLocs.length) {
+            return
+          }
+
+          for (const loc of rStatementLocs) {
+            context.report({
+              loc,
+              message: 'Extra return statement in setup function.'
+            })
+          }
+        },
+        onVueObjectEnter(node) {
+          const dataProperty = utils.findProperty(node, 'data')
+          if (
+            !dataProperty ||
+            (dataProperty.value.type !== 'FunctionExpression' &&
+              dataProperty.value.type !== 'ArrowFunctionExpression')
+          ) {
+            return
+          }
+          if (context.getSourceCode().ast.tokens.filter(t => t.value === 'return').length > 1) {
+            context.report({
+                node,
+                message: 'Extra return statement in data function.'
+            })
+          }
+        },
+      })
+    )
+  }
+}
diff --git a/tests/lib/rules/no-early-return.js b/tests/lib/rules/no-early-return.js
new file mode 100644
index 000000000..f027b1467
--- /dev/null
+++ b/tests/lib/rules/no-early-return.js
@@ -0,0 +1,203 @@
+/**
+ * @author *****your name*****
+ * See LICENSE file in root directory for full license.
+ */
+'use strict'
+
+const RuleTester = require('eslint').RuleTester
+const rule = require('../../../lib/rules/no-early-return')
+
+const tester = new RuleTester({
+  parser: require.resolve('vue-eslint-parser'),
+  parserOptions: {
+    ecmaVersion: 2020,
+    sourceType: 'module'
+  }
+})
+
+tester.run('no-early-return', rule, {
+  valid: [
+    {
+      filename: 'test.vue',
+      code: `
+      <script setup>
+        const foo = ref()
+      </script>
+      `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      <script setup>
+      </script>
+      `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      <script>
+      export default {
+        setup () {
+          const foo = ref()
+        }
+      }
+      </script>
+      `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      <script>
+      export default {
+        setup () {
+          const foo = ref()
+          return { foo }
+        }
+      }
+      </script>
+      `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      <script>
+      export default {
+        setup () {
+          const foo = ref()
+          function bar () {
+            return 1
+          }
+          return { foo }
+        }
+      }
+      </script>
+      `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      <script>
+      export default {
+        data () {
+          return { foo: true }
+        }
+      }
+      </script>
+      `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      <script>
+      export default {
+        data: () => ({ foo: true })
+      }
+      </script>
+      `
+    },
+  ],
+  invalid: [
+     {
+      filename: 'test.vue',
+      code: `
+      <script>
+      export default {
+        setup () {
+          const foo = ref()
+
+          function bar () {
+            return 1
+          }
+
+          for (const f of [1]) {
+            if (1) {
+              return 2
+            }
+          }
+
+          if (foo) {
+            return
+          }
+
+          return { foo }
+        }
+      }
+      </script>
+      `,
+      errors: [
+        {
+          message: 'Extra return statement in setup function.',
+          line: 13
+        },
+        {
+          message: 'Extra return statement in setup function.',
+          line: 18
+        },
+      ]
+    },
+     {
+      filename: 'test.vue',
+      code: `
+      <script>
+      export default {
+        setup () {
+          const foo = ref()
+
+          if (foo) {
+            return { foo }
+          }
+        }
+      }
+      </script>
+      `,
+      errors: [
+        {
+          message: 'Extra return statement in setup function.',
+          line: 8
+        },
+      ]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      <script>
+      export default {
+        data () {
+          if (this.bar) {
+            return { foo: false }
+          }
+          return { foo: true }
+        }
+      }
+      </script>
+      `,
+      errors: [
+        {
+          message: 'Extra return statement in data function.',
+          line: 3
+        },
+      ]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      <script>
+      export default {
+        data: () => {
+          if (maybe) {
+            return { foo: false }
+          }
+          return { foo: true }
+        }
+      }
+      </script>
+      `,
+      errors: [
+        {
+          message: 'Extra return statement in data function.',
+          line: 3
+        },
+      ]
+    }
+  ]
+})

From 7929a2c4fcab9325f3f9133f536c04c86bdebede Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jes=C3=BAs=20=C3=81ngel?= <jesusgonzaleznovez@gmail.com>
Date: Fri, 13 May 2022 16:48:19 +0200
Subject: [PATCH 2/6] lint: no-early-return files

---
 lib/rules/no-early-return.js       | 18 +++++++++++-------
 tests/lib/rules/no-early-return.js | 14 +++++++-------
 2 files changed, 18 insertions(+), 14 deletions(-)

diff --git a/lib/rules/no-early-return.js b/lib/rules/no-early-return.js
index 50f376e1d..f9247d2d7 100644
--- a/lib/rules/no-early-return.js
+++ b/lib/rules/no-early-return.js
@@ -20,7 +20,7 @@ module.exports = {
     docs: {
       description: 'disallow early returns in setup and data functions',
       categories: undefined,
-      url: ''
+      url: 'https://eslint.vuejs.org/rules/no-early-return.html'
     },
     fixable: null,
     schema: []
@@ -31,7 +31,7 @@ module.exports = {
     const rStatementLocs = []
     return utils.compositingVisitors(
       utils.defineVueVisitor(context, {
-        ReturnStatement (node) {
+        ReturnStatement(node) {
           if (context.getScope().type === 'function') {
             return
           }
@@ -39,7 +39,7 @@ module.exports = {
         },
 
         onSetupFunctionExit() {
-          if (!rStatementLocs.length) {
+          if (rStatementLocs.length === 0) {
             return
           }
 
@@ -59,13 +59,17 @@ module.exports = {
           ) {
             return
           }
-          if (context.getSourceCode().ast.tokens.filter(t => t.value === 'return').length > 1) {
+          if (
+            context
+              .getSourceCode()
+              .ast.tokens.filter((t) => t.value === 'return').length > 1
+          ) {
             context.report({
-                node,
-                message: 'Extra return statement in data function.'
+              node,
+              message: 'Extra return statement in data function.'
             })
           }
-        },
+        }
       })
     )
   }
diff --git a/tests/lib/rules/no-early-return.js b/tests/lib/rules/no-early-return.js
index f027b1467..6fe3bca12 100644
--- a/tests/lib/rules/no-early-return.js
+++ b/tests/lib/rules/no-early-return.js
@@ -94,10 +94,10 @@ tester.run('no-early-return', rule, {
       }
       </script>
       `
-    },
+    }
   ],
   invalid: [
-     {
+    {
       filename: 'test.vue',
       code: `
       <script>
@@ -132,10 +132,10 @@ tester.run('no-early-return', rule, {
         {
           message: 'Extra return statement in setup function.',
           line: 18
-        },
+        }
       ]
     },
-     {
+    {
       filename: 'test.vue',
       code: `
       <script>
@@ -154,7 +154,7 @@ tester.run('no-early-return', rule, {
         {
           message: 'Extra return statement in setup function.',
           line: 8
-        },
+        }
       ]
     },
     {
@@ -175,7 +175,7 @@ tester.run('no-early-return', rule, {
         {
           message: 'Extra return statement in data function.',
           line: 3
-        },
+        }
       ]
     },
     {
@@ -196,7 +196,7 @@ tester.run('no-early-return', rule, {
         {
           message: 'Extra return statement in data function.',
           line: 3
-        },
+        }
       ]
     }
   ]

From 85b54cb23596a8e3f456b6b2bcae6ccc0f0d60a4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jes=C3=BAs=20=C3=81ngel?= <jesusgonzaleznovez@gmail.com>
Date: Fri, 13 May 2022 16:49:17 +0200
Subject: [PATCH 3/6] chore: changes after running update for new rule

---
 docs/rules/README.md | 1 +
 lib/index.js         | 1 +
 2 files changed, 2 insertions(+)

diff --git a/docs/rules/README.md b/docs/rules/README.md
index 0f39db375..413b0fa7b 100644
--- a/docs/rules/README.md
+++ b/docs/rules/README.md
@@ -223,6 +223,7 @@ For example:
 | [vue/no-bare-strings-in-template](./no-bare-strings-in-template.md) | disallow the use of bare strings in `<template>` |  | :hammer: |
 | [vue/no-boolean-default](./no-boolean-default.md) | disallow boolean defaults | :wrench: | :hammer: |
 | [vue/no-duplicate-attr-inheritance](./no-duplicate-attr-inheritance.md) | enforce `inheritAttrs` to be set to `false` when using `v-bind="$attrs"` |  | :hammer: |
+| [vue/no-early-return](./no-early-return.md) | disallow early returns in setup and data functions |  | :warning: |
 | [vue/no-empty-component-block](./no-empty-component-block.md) | disallow the `<template>` `<script>` `<style>` block to be empty |  | :hammer: |
 | [vue/no-multiple-objects-in-class](./no-multiple-objects-in-class.md) | disallow to pass multiple objects into array to class |  | :hammer: |
 | [vue/no-potential-component-option-typo](./no-potential-component-option-typo.md) | disallow a potential typo in your component property | :bulb: | :hammer: |
diff --git a/lib/index.js b/lib/index.js
index b46d395d4..8dd736a5c 100644
--- a/lib/index.js
+++ b/lib/index.js
@@ -86,6 +86,7 @@ module.exports = {
     'no-dupe-v-else-if': require('./rules/no-dupe-v-else-if'),
     'no-duplicate-attr-inheritance': require('./rules/no-duplicate-attr-inheritance'),
     'no-duplicate-attributes': require('./rules/no-duplicate-attributes'),
+    'no-early-return': require('./rules/no-early-return'),
     'no-empty-component-block': require('./rules/no-empty-component-block'),
     'no-empty-pattern': require('./rules/no-empty-pattern'),
     'no-export-in-script-setup': require('./rules/no-export-in-script-setup'),

From 7c0529961bb2014aeb13b18ef6463be12adad3c2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jes=C3=BAs=20=C3=81ngel?= <jesusgonzaleznovez@gmail.com>
Date: Fri, 13 May 2022 17:31:31 +0200
Subject: [PATCH 4/6] fix: minor corrections from code review

---
 docs/rules/README.md               |  2 +-
 docs/rules/no-early-return.md      |  8 +--
 lib/rules/no-early-return.js       | 89 +++++++++++++++---------------
 tests/lib/rules/no-early-return.js | 15 +++--
 4 files changed, 60 insertions(+), 54 deletions(-)

diff --git a/docs/rules/README.md b/docs/rules/README.md
index 413b0fa7b..747ba333f 100644
--- a/docs/rules/README.md
+++ b/docs/rules/README.md
@@ -223,7 +223,7 @@ For example:
 | [vue/no-bare-strings-in-template](./no-bare-strings-in-template.md) | disallow the use of bare strings in `<template>` |  | :hammer: |
 | [vue/no-boolean-default](./no-boolean-default.md) | disallow boolean defaults | :wrench: | :hammer: |
 | [vue/no-duplicate-attr-inheritance](./no-duplicate-attr-inheritance.md) | enforce `inheritAttrs` to be set to `false` when using `v-bind="$attrs"` |  | :hammer: |
-| [vue/no-early-return](./no-early-return.md) | disallow early returns in setup and data functions |  | :warning: |
+| [vue/no-early-return](./no-early-return.md) | disallow early `returns` in `setup` and `data` functions |  | :warning: |
 | [vue/no-empty-component-block](./no-empty-component-block.md) | disallow the `<template>` `<script>` `<style>` block to be empty |  | :hammer: |
 | [vue/no-multiple-objects-in-class](./no-multiple-objects-in-class.md) | disallow to pass multiple objects into array to class |  | :hammer: |
 | [vue/no-potential-component-option-typo](./no-potential-component-option-typo.md) | disallow a potential typo in your component property | :bulb: | :hammer: |
diff --git a/docs/rules/no-early-return.md b/docs/rules/no-early-return.md
index 56939eb5d..bdb9a9193 100644
--- a/docs/rules/no-early-return.md
+++ b/docs/rules/no-early-return.md
@@ -2,19 +2,17 @@
 pageClass: rule-details
 sidebarDepth: 0
 title: vue/no-early-return
-description: disallow early returns in setup and data functions
+description: disallow early `returns` in `setup` and `data` functions
 ---
 # vue/no-early-return
 
-> disallow early returns in setup and data functions
+> disallow early `returns` in `setup` and `data` functions
 
 - :exclamation: <badge text="This rule has not been released yet." vertical="middle" type="error"> ***This rule has not been released yet.*** </badge>
 
 ## :book: Rule Details
 
-This rule helps to identify accidental `return` statements in the `setup` block of a Vue component, these are `return` statements that would exit the `setup` block skipping part of the block itself (not allowing to each the end of the block).
-
-On the other hand, the rule checks the `data` block too, applying the same logic.
+The `setup` and `data` functions of Vue components should only have a single (unconditional) return statement at the end. This rule reports early `return` statements, i.e. those that would exit the function early without allowing to reach the end of the function body.
 
 <eslint-code-block :rules="{'vue/no-early-return': ['error']}">
 
diff --git a/lib/rules/no-early-return.js b/lib/rules/no-early-return.js
index f9247d2d7..25b9bf0e3 100644
--- a/lib/rules/no-early-return.js
+++ b/lib/rules/no-early-return.js
@@ -18,59 +18,62 @@ module.exports = {
   meta: {
     type: 'problem',
     docs: {
-      description: 'disallow early returns in setup and data functions',
+      description: 'disallow early `returns` in `setup` and `data` functions',
       categories: undefined,
       url: 'https://eslint.vuejs.org/rules/no-early-return.html'
     },
     fixable: null,
-    schema: []
+    schema: [],
+    messages: {
+      extraReturnStatement:
+        'Only one (unconditional) return statement is allowed in {{ functionType }} function.'
+    }
   },
 
   /** @param {RuleContext} context */
   create(context) {
-    const rStatementLocs = []
-    return utils.compositingVisitors(
-      utils.defineVueVisitor(context, {
-        ReturnStatement(node) {
-          if (context.getScope().type === 'function') {
-            return
-          }
-          rStatementLocs.push(node.loc)
-        },
+    const returnStatementLocations = []
+    return utils.defineVueVisitor(context, {
+      ReturnStatement(node) {
+        if (context.getScope().type === 'function') {
+          return
+        }
+        returnStatementLocations.push(node.loc)
+      },
 
-        onSetupFunctionExit() {
-          if (rStatementLocs.length === 0) {
-            return
-          }
+      onSetupFunctionExit() {
+        if (returnStatementLocations.length === 0) {
+          return
+        }
 
-          for (const loc of rStatementLocs) {
-            context.report({
-              loc,
-              message: 'Extra return statement in setup function.'
-            })
-          }
-        },
-        onVueObjectEnter(node) {
-          const dataProperty = utils.findProperty(node, 'data')
-          if (
-            !dataProperty ||
-            (dataProperty.value.type !== 'FunctionExpression' &&
-              dataProperty.value.type !== 'ArrowFunctionExpression')
-          ) {
-            return
-          }
-          if (
-            context
-              .getSourceCode()
-              .ast.tokens.filter((t) => t.value === 'return').length > 1
-          ) {
-            context.report({
-              node,
-              message: 'Extra return statement in data function.'
-            })
-          }
+        for (const loc of returnStatementLocations) {
+          context.report({
+            loc,
+            messageId: 'extraReturnStatement',
+            data: { functionType: 'setup' }
+          })
+        }
+      },
+      onVueObjectEnter(node) {
+        const dataProperty = utils.findProperty(node, 'data')
+        if (
+          !dataProperty ||
+          (dataProperty.value.type !== 'FunctionExpression' &&
+            dataProperty.value.type !== 'ArrowFunctionExpression')
+        ) {
+          return
+        }
+        if (
+          context.getSourceCode().ast.tokens.filter((t) => t.value === 'return')
+            .length > 1
+        ) {
+          context.report({
+            node,
+            messageId: 'extraReturnStatement',
+            data: { functionType: 'data' }
+          })
         }
-      })
-    )
+      }
+    })
   }
 }
diff --git a/tests/lib/rules/no-early-return.js b/tests/lib/rules/no-early-return.js
index 6fe3bca12..1eb63d8c2 100644
--- a/tests/lib/rules/no-early-return.js
+++ b/tests/lib/rules/no-early-return.js
@@ -126,11 +126,13 @@ tester.run('no-early-return', rule, {
       `,
       errors: [
         {
-          message: 'Extra return statement in setup function.',
+          messageId: 'extraReturnStatement',
+          data: { functionType: 'setup' },
           line: 13
         },
         {
-          message: 'Extra return statement in setup function.',
+          messageId: 'extraReturnStatement',
+          data: { functionType: 'setup' },
           line: 18
         }
       ]
@@ -152,7 +154,8 @@ tester.run('no-early-return', rule, {
       `,
       errors: [
         {
-          message: 'Extra return statement in setup function.',
+          messageId: 'extraReturnStatement',
+          data: { functionType: 'setup' },
           line: 8
         }
       ]
@@ -173,7 +176,8 @@ tester.run('no-early-return', rule, {
       `,
       errors: [
         {
-          message: 'Extra return statement in data function.',
+          messageId: 'extraReturnStatement',
+          data: { functionType: 'data' },
           line: 3
         }
       ]
@@ -194,7 +198,8 @@ tester.run('no-early-return', rule, {
       `,
       errors: [
         {
-          message: 'Extra return statement in data function.',
+          messageId: 'extraReturnStatement',
+          data: { functionType: 'data' },
           line: 3
         }
       ]

From 156b8178fee14d742f986c991a00277b9d8e541f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jes=C3=BAs=20=C3=81ngel?= <jesusgonzaleznovez@gmail.com>
Date: Fri, 13 May 2022 17:53:29 +0200
Subject: [PATCH 5/6] feat: extend no-early-return rule to cover asyncData

---
 docs/rules/no-early-return.md      |  2 +-
 lib/rules/no-early-return.js       | 40 ++++++++-------
 tests/lib/rules/no-early-return.js | 78 ++++++++++++++++++++++++++++++
 3 files changed, 102 insertions(+), 18 deletions(-)

diff --git a/docs/rules/no-early-return.md b/docs/rules/no-early-return.md
index bdb9a9193..1b189cf3f 100644
--- a/docs/rules/no-early-return.md
+++ b/docs/rules/no-early-return.md
@@ -12,7 +12,7 @@ description: disallow early `returns` in `setup` and `data` functions
 
 ## :book: Rule Details
 
-The `setup` and `data` functions of Vue components should only have a single (unconditional) return statement at the end. This rule reports early `return` statements, i.e. those that would exit the function early without allowing to reach the end of the function body.
+The `setup` and `data` functions of Vue components (and [`asyncData`](https://nuxtjs.org/docs/directory-structure/pages/#asyncdata) of Nuxt.js page components) should only have a single (unconditional) return statement at the end. This rule reports early `return` statements, i.e. those that would exit the function early without allowing to reach the end of the function body.
 
 <eslint-code-block :rules="{'vue/no-early-return': ['error']}">
 
diff --git a/lib/rules/no-early-return.js b/lib/rules/no-early-return.js
index 25b9bf0e3..e81a5a967 100644
--- a/lib/rules/no-early-return.js
+++ b/lib/rules/no-early-return.js
@@ -10,6 +10,8 @@
 
 const utils = require('../utils')
 
+const PROPERTIES_NEED_CHECKING = new Set(['data', 'asyncData'])
+
 // ------------------------------------------------------------------------------
 // Rule Definition
 // ------------------------------------------------------------------------------
@@ -33,6 +35,7 @@ module.exports = {
   /** @param {RuleContext} context */
   create(context) {
     const returnStatementLocations = []
+
     return utils.defineVueVisitor(context, {
       ReturnStatement(node) {
         if (context.getScope().type === 'function') {
@@ -55,23 +58,26 @@ module.exports = {
         }
       },
       onVueObjectEnter(node) {
-        const dataProperty = utils.findProperty(node, 'data')
-        if (
-          !dataProperty ||
-          (dataProperty.value.type !== 'FunctionExpression' &&
-            dataProperty.value.type !== 'ArrowFunctionExpression')
-        ) {
-          return
-        }
-        if (
-          context.getSourceCode().ast.tokens.filter((t) => t.value === 'return')
-            .length > 1
-        ) {
-          context.report({
-            node,
-            messageId: 'extraReturnStatement',
-            data: { functionType: 'data' }
-          })
+        for (const property of PROPERTIES_NEED_CHECKING) {
+          const dataProperty = utils.findProperty(node, property)
+          if (
+            !dataProperty ||
+            (dataProperty.value.type !== 'FunctionExpression' &&
+              dataProperty.value.type !== 'ArrowFunctionExpression')
+          ) {
+            continue
+          }
+          if (
+            context
+              .getSourceCode()
+              .ast.tokens.filter((t) => t.value === 'return').length > 1
+          ) {
+            context.report({
+              node,
+              messageId: 'extraReturnStatement',
+              data: { functionType: 'data' }
+            })
+          }
         }
       }
     })
diff --git a/tests/lib/rules/no-early-return.js b/tests/lib/rules/no-early-return.js
index 1eb63d8c2..8c9f3b729 100644
--- a/tests/lib/rules/no-early-return.js
+++ b/tests/lib/rules/no-early-return.js
@@ -85,6 +85,30 @@ tester.run('no-early-return', rule, {
       </script>
       `
     },
+    {
+      filename: 'test.vue',
+      code: `
+      <script>
+      export default {
+        asyncData () {
+          return { foo: true }
+        }
+      }
+      </script>
+      `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      <script>
+      export default {
+        asyncData (payload) {
+          return { foo: true }
+        }
+      }
+      </script>
+      `
+    },
     {
       filename: 'test.vue',
       code: `
@@ -94,6 +118,16 @@ tester.run('no-early-return', rule, {
       }
       </script>
       `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      <script>
+      export default {
+        asyncData: () => ({ foo: true })
+      }
+      </script>
+      `
     }
   ],
   invalid: [
@@ -182,6 +216,28 @@ tester.run('no-early-return', rule, {
         }
       ]
     },
+    {
+      filename: 'test.vue',
+      code: `
+      <script>
+      export default {
+        asyncData () {
+          if (this.bar) {
+            return { foo: false }
+          }
+          return { foo: true }
+        }
+      }
+      </script>
+      `,
+      errors: [
+        {
+          messageId: 'extraReturnStatement',
+          data: { functionType: 'data' },
+          line: 3
+        }
+      ]
+    },
     {
       filename: 'test.vue',
       code: `
@@ -203,6 +259,28 @@ tester.run('no-early-return', rule, {
           line: 3
         }
       ]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      <script>
+      export default {
+        asyncData: () => {
+          if (maybe) {
+            return { foo: false }
+          }
+          return { foo: true }
+        }
+      }
+      </script>
+      `,
+      errors: [
+        {
+          messageId: 'extraReturnStatement',
+          data: { functionType: 'data' },
+          line: 3
+        }
+      ]
     }
   ]
 })

From d63afa8f8b9a6d177abf9fa7819d86f1d1702e0f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jes=C3=BAs=20=C3=81ngel?= <jesusgonzaleznovez@gmail.com>
Date: Fri, 13 May 2022 18:22:22 +0200
Subject: [PATCH 6/6] tests: found test that makes the rule to fail :(

---
 tests/lib/rules/no-early-return.js | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/tests/lib/rules/no-early-return.js b/tests/lib/rules/no-early-return.js
index 8c9f3b729..64d79e8ab 100644
--- a/tests/lib/rules/no-early-return.js
+++ b/tests/lib/rules/no-early-return.js
@@ -128,6 +128,22 @@ tester.run('no-early-return', rule, {
       }
       </script>
       `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      <script>
+      export default {
+        setup () {
+          const foo = computed(() => {
+            if (s) {
+              return
+            }
+          })
+        }
+      }
+      </script>
+      `
     }
   ],
   invalid: [