Skip to content

fix(Transition): ensure appear callback invoking properly #9412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

fix(Transition): ensure appear callback invoking properly #9412

wants to merge 9 commits into from

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Oct 16, 2023 •
edited
Loading

close #9396
The root cause is that the transitionend callback of enterHook corresponding to onAppear is not invoked. Because el._endId is updated by onEnter

@github-actions
Copy link

github-actions bot commented Oct 16, 2023 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+59 B) 37.7 kB (+23 B) 33.9 kB (+18 B)
vue.global.prod.js 159 kB (+59 B) 57.6 kB (+21 B) 51.2 kB (-26 B)

Usages

Name Size Gzip Brotli
createApp 55.1 kB 21.2 kB 19.3 kB
createSSRApp 59.1 kB 22.9 kB 20.9 kB
defineCustomElement 59.8 kB 22.7 kB 20.7 kB
overall 68.9 kB (+59 B) 26.3 kB (+18 B) 23.9 kB (+60 B)

@edison1105 edison1105 changed the title fix(Transition): ensure remove appear class in enter callbacks fix(Transition): ensure appear callback invoking properly Oct 18, 2023
@edison1105 edison1105 added 🐞 bug Something isn't working scope: transition ready for review This PR requires more reviews labels Sep 3, 2024
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 3, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@9412

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@9412

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@9412

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@9412

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@9412

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@9412

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@9412

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@9412

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@9412

vue

pnpm add https://pkg.pr.new/vue@9412

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@9412

commit: b2b5ffc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🐞 bug Something isn't working ready for review This PR requires more reviews scope: transition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transition: custom appear(-active/to) classes stay on the element after transition ends.
1 participant
@edison1105