Skip to content

fix(runtime-dom): transitionGroup can render :slotted styles #7541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

fix(runtime-dom): transitionGroup can render :slotted styles #7541

wants to merge 30 commits into from

Conversation

baiwusanyu-c
Copy link
Member

close: #7532

@baiwusanyu-c baiwusanyu-c changed the title fix(transitionGroup): transitionGroup can render :slotted styles fix(runtime-dom): transitionGroup can render :slotted styles Jan 16, 2023
@netlify
Copy link

netlify bot commented Jan 16, 2023

❌ Deploy Preview for vuejs-coverage failed.

Name Link
🔨 Latest commit e49ecec
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/63c55e777125a70008ed1274

@vercel
Copy link

vercel bot commented Apr 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
sfc-playground ⬜️ Ignored (Inspect) Apr 6, 2023 0:44am

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 99.1 kB (+44 B) 37.5 kB (+14 B) 33.8 kB (+15 B)
vue.global.prod.js 157 kB (+44 B) 57.3 kB (+12 B) 51 kB (-37 B)

Usages

Name Size Gzip Brotli
createApp 54.5 kB 21.1 kB 19.3 kB
createSSRApp 58.5 kB 22.8 kB 20.7 kB
defineCustomElement 59.1 kB 22.6 kB 20.6 kB
overall 68.1 kB 26.2 kB 23.8 kB

@baiwusanyu-c
Merge remote-tracking branch 'upstream/main' into bwsy/fix/slotted
6bafa10 
# Conflicts:
#	packages/runtime-core/__tests__/scopeId.spec.ts
skirtles-code
skirtles-code reviewed Apr 21, 2024
View reviewed changes
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 20, 2024 •
edited
Loading

commit: 7ca6a18

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@7541

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@7541

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@7541

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@7541

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@7541

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@7541

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@7541

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@7541

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@7541

vue

pnpm add https://pkg.pr.new/vue@7541

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@7541

Open in Stackblitz

edison1105
edison1105 requested changes Aug 20, 2024
View reviewed changes
@edison1105 edison1105 added the ready to merge The PR is ready to be merged. label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skirtles-code skirtles-code skirtles-code left review comments

@edison1105 edison1105 edison1105 approved these changes

Assignees
No one assigned
Labels
ready to merge The PR is ready to be merged. scope: slots scope: transition
Projects
Issue / PR Management
Status: Waiting
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

:slotted styles not being applied if slot is wrapped in TransitionGroup
4 participants
@baiwusanyu-c @edison1105 @skirtles-code @haoqunjiang