types: add UMD global declaration #8545
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyx990803
requested changes
Jul 12, 2023
There was a problem hiding this comment.
Vue 3 only has the namespace object when using the global build. In ESM builds there are only named exports. This will be appended to the main dts file, and affect non-global build usage.
We need a separate d.ts file in dist, e.g. dist/vue.global.d.ts
There was a problem hiding this comment.
It's not necessary. TypeScript will emit an error if users used the global object in the module file.
See https://www.typescriptlang.org/docs/handbook/modules.html#umd-modules
sxzz
added
ready to merge
Size ReportBundles
Usages
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2932