Skip to content

Commit bac1df5

Browse files
committed
Fix duplicate ids on multiple link-list instances
1 parent 61f2002 commit bac1df5

File tree

1 file changed

+23
-24
lines changed

1 file changed

+23
-24
lines changed

src/skip-to-list.vue

Lines changed: 23 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,31 @@
11
<template>
22
<div :class="containerClassNames">
3+
<label>
34

4-
<!-- TODO: fix label to handle multiple instances of nav list -->
5-
<p class="vue-skip-to__label" id="vue-skip-to__label">
6-
<slot>Skip to</slot>
7-
</p>
5+
<p class="vue-skip-to__label">
6+
<slot>Skip to</slot>
7+
</p>
88

9-
<nav
10-
class="vue-skip-to__nav"
11-
aria-labelledby="vue-skip-to__label"
12-
>
13-
<ul class="vue-skip-to__nav-list">
14-
<li
15-
v-for="el in to"
16-
:key="el.anchor"
17-
class="vue-skip-to__nav-list-item"
18-
>
19-
<vue-skip-to
20-
:to="el.anchor"
21-
@focus="labelVisible = true"
22-
@blur="labelVisible = false"
23-
class="vue-skip-to vue-skip-to--relative"
9+
<nav class="vue-skip-to__nav">
10+
<ul class="vue-skip-to__nav-list">
11+
<li
12+
v-for="el in to"
13+
:key="el.anchor"
14+
class="vue-skip-to__nav-list-item"
2415
>
25-
{{ el.label }}
26-
</vue-skip-to>
27-
</li>
28-
</ul>
29-
</nav>
16+
<vue-skip-to
17+
:to="el.anchor"
18+
@focus="labelVisible = true"
19+
@blur="labelVisible = false"
20+
class="vue-skip-to vue-skip-to--relative"
21+
>
22+
{{ el.label }}
23+
</vue-skip-to>
24+
</li>
25+
</ul>
26+
</nav>
3027

28+
</label>
3129
</div>
3230
</template>
3331

@@ -36,6 +34,7 @@ export default {
3634
name: 'VueSkipToList',
3735
3836
props: {
37+
// TODO: allow modifying `<skip-to>` props
3938
to: {
4039
validator: function (val) {
4140
return Array.isArray(val) &&

0 commit comments

Comments
 (0)